Bug 1525819 - Warning dialogue box disappears automatically when click out of the box
Summary: Warning dialogue box disappears automatically when click out of the box
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.7.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 3.9.0
Assignee: Robb Hamilton
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-14 06:19 UTC by Yanping Zhang
Modified: 2018-03-28 14:15 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Doc Text: Cause: By default, dialogs in the console can be dismissed by clicking in the negative space surrounding the dialog. Consequence: The warning dialog could be inadvertently dismissed. Fix: The warning dialog's configuration was changed so it can only be dismissed by clicking one of the buttons in the dialog. Result: The warning dialog can no longer be inadvertently dismissed by the user as clicking one of the dialog's buttons is now required in order to close the dialog.
Clone Of:
Environment:
Last Closed: 2018-03-28 14:15:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 None None None 2018-03-28 14:15:53 UTC

Description Yanping Zhang 2017-12-14 06:19:36 UTC
Description of problem:
When create a special resource by import json/yaml file, it will pop up a dialogue box, with "Create Anyway" and "Cancel" button, if user clicks out of the dialogue box accidentally, the box disappears automatically.

Version-Release number of selected component (if applicable):

openshift v3.7.14

How reproducible:
Always

Steps to Reproduce:
1.Create special resource by import json/yaml, eg import a quota file, and click "Create" button.
{
  "apiVersion": "v1",
  "kind": "ResourceQuota",
  "metadata": {
    "name": "quota" 
  },
  "spec": {
    "hard": {
      "memory": "1Gi", 
      "cpu": "20", 
      "pods": "10", 
      "services": "5", 
      "replicationcontrollers":"5" 
    }
  }
}

2.Click out of the warning dialogue box.
3.

Actual results:
1. A warning dialogue box shows up.
2. The dialogue box disappears automatically.

Expected results:
2. Should not disappear unless user clicks the button on it.

Additional info:

Comment 1 Robb Hamilton 2018-01-08 18:35:00 UTC
PR to resolve: https://github.com/openshift/origin-web-console/pull/2639

Comment 3 Yanping Zhang 2018-01-15 02:37:41 UTC
Checked on OCP v3.9.0-0.19.0, when import a special resource file, eg, a quota file, the warning modal shows and will not disappear when click outside the modal. Import a template file with special resource file, the warning modal also keeps there when click outside of it.

The bug has been fixed to some degree, but I found when import template, there is a modal showing "What do you like to do?", use could choose "Process the template","Save the template". This modal also disappear when click outside it.
@Robb, would you fix it here or in future? If it won't be included in this bug, I would move the bug to "Verified'

Comment 4 Yanping Zhang 2018-01-15 02:42:23 UTC
Sorry, Doc Text is changed by my mistake, recovered it.

Comment 5 Robb Hamilton 2018-01-15 14:35:54 UTC
> @Robb, would you fix it here or in future?

I'll fix it here.  The original BZ didn't mention the second modal, so I didn't fix it.  Note that we have many modals across the console, and the default behavior is to allow clicking on the background in order to close the modal.  We should probably check that all confirmation modals have the default configuration changed.

Comment 6 Robb Hamilton 2018-01-15 15:44:18 UTC
Follow on fix of second modal: https://github.com/openshift/origin-web-console/pull/2658

Comment 7 Yanping Zhang 2018-01-17 01:18:45 UTC
@Robb, As you noted, it is default behavior for many modals to close when clicking on the backgroud, you have fixed some. Thanks for your following up. And about the "Tour Catalog Home" modal I mentioned in bug 1533756 additional info, need it be updated too?

Comment 8 Yadan Pei 2018-01-17 06:37:58 UTC
@yanpzhan, I think the "Tout Catalog Home" is not a modal as we understand. So it's not in the scope of the fix, @robb, could you please confirm?


Now all modals are expected to open when user click background, checked in 3.9.0-0.20.0

Comment 9 Robb Hamilton 2018-01-17 14:04:58 UTC
> @yanpzhan, I think the "Tout Catalog Home" is not a modal as we understand. So it's not in the scope of the fix, @robb, could you please confirm?

Yeah.  Let's keep that separate since it's technically not a modal.

Comment 10 Yanping Zhang 2018-01-18 05:47:19 UTC
Now the issues in the bug have been fixed in OCP v3.9.0-0.20.0, pls move it to ON_QA.

Comment 11 Yadan Pei 2018-02-01 09:19:55 UTC
Move to VERIFIED per comment 10

Comment 14 errata-xmlrpc 2018-03-28 14:15:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489


Note You need to log in before you can comment on or make changes to this bug.