Bug 1525859 - Clean metadata command raises Traceback
Summary: Clean metadata command raises Traceback
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-hosted-engine-setup
Classification: oVirt
Component: Plugins.General
Version: 2.2.1
Hardware: x86_64
OS: Linux
medium
low
Target Milestone: ovirt-4.2.2
: ---
Assignee: Denis Chaplygin
QA Contact: Polina
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-14 08:53 UTC by Artyom
Modified: 2018-03-29 11:14 UTC (History)
3 users (show)

Fixed In Version: ovirt-hosted-engine-setup-2.2.10
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-29 11:14:54 UTC
oVirt Team: SLA
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 86880 0 master MERGED agent: Removed forgottent is_connected call 2018-02-09 09:52:07 UTC

Description Artyom 2017-12-14 08:53:37 UTC
Description of problem:
Clean metadata command raises Traceback
ERROR:ovirt_hosted_engine_ha.agent.agent.Agent:Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/agent/agent.py", line 131, in _run_agent
    return action(he)
  File "/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/agent/agent.py", line 58, in action_clean
    return he.clean(options.force_cleanup)
  File "/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/agent/hosted_engine.py", line 396, in clean
    if self._broker and self._broker.is_connected():
AttributeError: 'BrokerLink' object has no attribute 'is_connected'

Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-2.2.1-1.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Run hosted-engine --clean-metadata
2.
3.

Actual results:
ERROR:ovirt_hosted_engine_ha.agent.agent.Agent:Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/agent/agent.py", line 131, in _run_agent
    return action(he)
  File "/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/agent/agent.py", line 58, in action_clean
    return he.clean(options.force_cleanup)
  File "/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/agent/hosted_engine.py", line 396, in clean
    if self._broker and self._broker.is_connected():
AttributeError: 'BrokerLink' object has no attribute 'is_connected'

Expected results:
No Tracebacks

Additional info:
I did not recognize that it somehow affect functionality of the command

Comment 1 Martin Sivák 2017-12-15 10:21:05 UTC
I think something similar will happen for reinitialize lockspace as well.

Comment 3 Polina 2018-02-20 07:25:14 UTC
verified on version rhv-release-4.2.2-1-001.noarch & rhel 7.5

hosted-engine --clean-metadata
INFO:ovirt_hosted_engine_ha.agent.agent.Agent:ovirt-hosted-engine-ha agent 2.2.5 started
INFO:ovirt_hosted_engine_ha.agent.hosted_engine.HostedEngine:Found certificate common name: 10.35.92.7
INFO:ovirt_hosted_engine_ha.agent.hosted_engine.HostedEngine:Initializing ha-broker connection
INFO:ovirt_hosted_engine_ha.agent.hosted_engine.HostedEngine:Broker initialized, all submonitors started
ERROR:ovirt_hosted_engine_ha.agent.hosted_engine.HostedEngine:Cannot clean unclean metadata block. Consider --force-clean.
INFO:ovirt_hosted_engine_ha.agent.agent.Agent:Agent shutting down
[root@alma07 ~]# systemctl status ovirt-ha-agent
● ovirt-ha-agent.service - oVirt Hosted Engine High Availability Monitoring Agent
   Loaded: loaded (/usr/lib/systemd/system/ovirt-ha-agent.service; enabled; vendor preset: disabled)
   Active: active (running) since Tue 2018-02-20 00:28:36 IST; 8h ago
 Main PID: 32045 (ovirt-ha-agent)
    Tasks: 2
   CGroup: /system.slice/ovirt-ha-agent.service
           └─32045 /usr/bin/python /usr/share/ovirt-hosted-engine-ha/ovirt-ha-agent

Comment 4 Sandro Bonazzola 2018-03-29 11:14:54 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.