Bug 1525904 – Include engine-psql.sh in ovirt-engine-dbscripts package as redhat-support-plugin-rhev package has been obsoleted and rhevm-doc is not a nice place to include that script

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1525904 - Include engine-psql.sh in ovirt-engine-dbscripts package as redhat-support-plugin-rhev package has been obsoleted and rhevm-doc is not a nice place to include that script

Summary:	Include engine-psql.sh in ovirt-engine-dbscripts package as redhat-support-pl...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine (Show other bugs)
Sub Component:
Version:	4.2.0
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	ovirt-4.2.2
Target Release:	---
Assigned To:	Eli Mesika
QA Contact:	Lucie Leistnerova
Docs Contact:

URL:
Whiteboard:
Keywords:	Regression

Depends On:
Blocks:	902971
	Show dependency tree / graph

Reported:	2017-12-14 05:54 EST by Martin Perina
Modified:	2018-05-15 13:48 EDT (History)
CC List:	14 users (show)

See Also:
Fixed In Version:	ovirt-engine-4.2.2.4
Doc Type:	No Doc Update
Doc Text:	undefined
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-05-15 13:46:56 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Infra
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	86610	master	MERGED	db: Add engine-psql.sh to dbscripts	2018-03-08 06:21 EST
oVirt gerrit	88649	ovirt-engine-4.2	MERGED	db: Add engine-psql.sh to dbscripts	2018-03-08 08:36 EST
Red Hat Product Errata	RHEA-2018:1488	None	None	None	2018-05-15 13:48 EDT

Groups: None (edit)

Description Martin Perina 2017-12-14 05:54:07 EST

Script engine-psql.sh was part of redhat-support-plugin-rhev and it was referenced from many KCS articles. In 4.2 redhat-support-plugin-rhev is obsoleted by rhvm-doc, but engine-psql.sh is not part of rhvm-doc package.

Comment 2 Greg Sheremeta 2017-12-14 09:46:41 EST

redhat-support-plugin-rhev wasn't being maintained -- and I missed the existence of this script -- apologies.

I would prefer it not go in rhvm-doc.

Comment 7 Martin Perina 2018-01-05 08:25:49 EST

The script also needs to be adapted to work properly with SCL PG 9.5

Comment 15 Roman Hodain 2018-02-07 09:54:37 EST

Hi Eli,

I have checked the code and it seems that this lime:

psql -U "${USERNAME}" -h "${HOST}" -p "${port}" "${ENGINE_DB_DATABASE}" "$@" | tee -a "${LOGFILE}" 2>&1

Was changed to 

echo "psql $@"

but we need to pass -h "${HOST}" as otherwise the authentication will not work. -h is not possible as it is taken by the script and prints help instead.

Can you check?

Comment 16 Eli Mesika 2018-02-12 11:45:17 EST

(In reply to Roman Hodain from comment #15)
> Hi Eli,
> 
> I have checked the code and it seems that this lime:
> 
> psql -U "${USERNAME}" -h "${HOST}" -p "${port}" "${ENGINE_DB_DATABASE}" "$@"
> | tee -a "${LOGFILE}" 2>&1
> 
> Was changed to 
> 
> echo "psql $@"
> 
> but we need to pass -h "${HOST}" as otherwise the authentication will not
> work. -h is not possible as it is taken by the script and prints help
> instead.
> 
> Can you check?

Can you check setting the host in the command line . e,g :


ENGINE_DB_HOST=<host ip> psql ..........

Comment 17 Roman Hodain 2018-02-19 06:10:47 EST

(In reply to Eli Mesika from comment #16)
> (In reply to Roman Hodain from comment #15)
> > Hi Eli,
> > 
> > I have checked the code and it seems that this lime:
> > 
> > psql -U "${USERNAME}" -h "${HOST}" -p "${port}" "${ENGINE_DB_DATABASE}" "$@"
> > | tee -a "${LOGFILE}" 2>&1
> > 
> > Was changed to 
> > 
> > echo "psql $@"
> > 
> > but we need to pass -h "${HOST}" as otherwise the authentication will not
> > work. -h is not possible as it is taken by the script and prints help
> > instead.
> > 
> > Can you check?
> 
> Can you check setting the host in the command line . e,g :
> 
> 
> ENGINE_DB_HOST=<host ip> psql ..........

Thanks that would work for me.

Comment 18 Lucie Leistnerova 2018-03-19 04:08:29 EDT

engine-psql.sh installed with ovirt-engine-dbscripts-4.2.2.4-0.1.el7.noarch to /usr/share/ovirt-engine/dbscripts/ and works

verified in ovirt-engine-4.2.2.4-0.1.el7.noarch

Comment 22 errata-xmlrpc 2018-05-15 13:46:56 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1488

Note You need to log in before you can comment on or make changes to this bug.