Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/

Bug 1526269

Summary: Package Review: python-magnum-tests-tempest - Magnum Tempest plugin
Product: [Community] RDO Reporter: Yatin Karel <ykarel>
Component: Package ReviewAssignee: Chandan Kumar <chkumar>
Status: CLOSED CURRENTRELEASE QA Contact: hguemar
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: trunkCC: chkumar
Target Milestone: ---Flags: chkumar: rdo-review+
Target Release: trunk   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-09 13:46:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1486366    

Description Yatin Karel 2017-12-15 05:33:00 UTC 
Package Name: python-magnum-tests-tempest
Package Description: Tempest plugin for the magnum project. 
Package URL: https://github.com/openstack/magnum-tempest-plugin.git
RDO Username: karelyatin
Comment 1 Chandan Kumar 2017-12-20 14:05:46 UTC 
License Check:

[chkumar246@ironfist magnum-tempest-plugin]$ licensecheck -r .
./.coveragerc: *No copyright* UNKNOWN
./.gitreview: *No copyright* UNKNOWN
./.mailmap: *No copyright* UNKNOWN
./.testr.conf: *No copyright* UNKNOWN
./CONTRIBUTING.rst: *No copyright* UNKNOWN
./HACKING.rst: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0)
./README.rst: *No copyright* UNKNOWN
./babel.cfg: *No copyright* UNKNOWN
./requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache
./setup.py: Apache (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./magnum_tempest_plugin/config.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/plugin.py: *No copyright* Apache (v2.0)
./tools/pretty_tox.sh: *No copyright* UNKNOWN
./doc/source/conf.py: *No copyright* Apache (v2.0)
./doc/source/contributing.rst: *No copyright* UNKNOWN
./doc/source/index.rst: *No copyright* UNKNOWN
./doc/source/installation.rst: *No copyright* UNKNOWN
./doc/source/readme.rst: *No copyright* UNKNOWN
./magnum_tempest_plugin/common/base.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/common/client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/common/config.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/common/datagen.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/common/manager.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/common/models.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/common/utils.py: *No copyright* Apache (v2.0)
./releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE
./releasenotes/source/index.rst: *No copyright* UNKNOWN
./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN
./magnum_tempest_plugin/tests/api/base.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/contrib/copy_instance_logs.sh: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_bay.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_baymodel.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_baymodel_admin.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_cluster.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_cluster_template.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_cluster_template_admin.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/test_magnum_service.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/clients/bay_client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/clients/baymodel_client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/clients/cert_client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/clients/cluster_client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/clients/cluster_template_client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/clients/magnum_service_client.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/bay_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/baymodel_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/baymodelpatch_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/baypatch_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/cert_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/cluster_id_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/cluster_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/cluster_template_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/cluster_templatepatch_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/clusterpatch_model.py: *No copyright* Apache (v2.0)
./magnum_tempest_plugin/tests/api/v1/models/magnum_service_model.py: *No copyright* Apache (v2.0)
[chkumar246@ironfist magnum-tempest-plugin]$ 


It's a valid Apache v2.0 license
Comment 2 Chandan Kumar 2017-12-22 09:39:13 UTC 
SRPM to use for package-review: https://logs.rdoproject.org/58/11058/2/check/DLRN-rpmbuild/Zcaed51ddf03c413cac8eb871f2c0f48f/centos/current/python-magnum-tests-tempest-0.0.1-0.20171222093301.4f8af5f.el7.centos.src.rpm
Comment 3 Chandan Kumar 2017-12-22 09:55:04 UTC 
The package looks sane, hence the package is APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache", "Unknown or generated", "*No
     copyright* Apache (v2.0)". 28 files have unknown license. Detailed
     output of licensecheck in
     /home/chkumar246/arena/rdo_projects/package_review/python-magnum-
     tests-tempest/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -magnum-tests-tempest , python-magnum-tests-tempest-doc , python3
     -magnum-tests-tempest
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     0.0.1.dev187
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-magnum-tests-tempest-0.0.1-0.20171222093301.4f8af5f.fc28.noarch.rpm
          python-magnum-tests-tempest-doc-0.0.1-0.20171222093301.4f8af5f.fc28.noarch.rpm
          python3-magnum-tests-tempest-0.0.1-0.20171222093301.4f8af5f.fc28.noarch.rpm
          python-magnum-tests-tempest-0.0.1-0.20171222093301.4f8af5f.fc28.src.rpm
python2-magnum-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest.
python2-magnum-tests-tempest.noarch: E: no-changelogname-tag
python2-magnum-tests-tempest.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/magnum_tempest_plugin/tests/contrib/copy_instance_logs.sh /usr/bin/env bash
python-magnum-tests-tempest-doc.noarch: W: summary-not-capitalized C python-magnum-tests-tempest documentation
python-magnum-tests-tempest-doc.noarch: E: no-changelogname-tag
python-magnum-tests-tempest-doc.noarch: W: file-not-utf8 /usr/share/doc/python-magnum-tests-tempest-doc/html/objects.inv
python3-magnum-tests-tempest.noarch: W: summary-not-capitalized C python-magnum-tests-tempest documentation
python3-magnum-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest.
python3-magnum-tests-tempest.noarch: E: no-changelogname-tag
python3-magnum-tests-tempest.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/magnum_tempest_plugin/tests/contrib/copy_instance_logs.sh /usr/bin/env bash
python-magnum-tests-tempest.src: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest.
python-magnum-tests-tempest.src: E: no-changelogname-tag
python-magnum-tests-tempest.src: W: invalid-url Source0: magnum_tempest_plugin-0.0.1.dev187-0.20171222093301.4f8af5f.tar.gz
4 packages and 0 specfiles checked; 9 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
python3-magnum-tests-tempest.noarch: W: summary-not-capitalized C python-magnum-tests-tempest documentation
python3-magnum-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest.
python3-magnum-tests-tempest.noarch: E: no-changelogname-tag
python3-magnum-tests-tempest.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/magnum-tempest-plugin/ <urlopen error [Errno -2] Name or service not known>
python3-magnum-tests-tempest.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/magnum_tempest_plugin/tests/contrib/copy_instance_logs.sh /usr/bin/env bash
python2-magnum-tests-tempest.noarch: E: description-line-too-long C Additionally it provides a plugin to automatically load these tests into Tempest.
python2-magnum-tests-tempest.noarch: E: no-changelogname-tag
python2-magnum-tests-tempest.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/magnum-tempest-plugin/ <urlopen error [Errno -2] Name or service not known>
python2-magnum-tests-tempest.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/magnum_tempest_plugin/tests/contrib/copy_instance_logs.sh /usr/bin/env bash
python-magnum-tests-tempest-doc.noarch: W: summary-not-capitalized C python-magnum-tests-tempest documentation
python-magnum-tests-tempest-doc.noarch: E: no-changelogname-tag
python-magnum-tests-tempest-doc.noarch: W: invalid-url URL: https://git.openstack.org/cgit/openstack/magnum-tempest-plugin/ <urlopen error [Errno -2] Name or service not known>
python-magnum-tests-tempest-doc.noarch: W: file-not-utf8 /usr/share/doc/python-magnum-tests-tempest-doc/html/objects.inv
3 packages and 0 specfiles checked; 7 errors, 6 warnings.



Requires
--------
python3-magnum-tests-tempest (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)
    python3-oslo-config
    python3-oslo-log
    python3-pbr
    python3-six
    python3-tempest

python2-magnum-tests-tempest (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)
    python-oslo-config
    python-oslo-log
    python-pbr
    python-six
    python-tempest

python-magnum-tests-tempest-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-magnum-tests-tempest:
    python3-magnum-tests-tempest
    python3.6dist(magnum-tempest-plugin)
    python3dist(magnum-tempest-plugin)

python2-magnum-tests-tempest:
    python-magnum-tests-tempest
    python2-magnum-tests-tempest
    python2.7dist(magnum-tempest-plugin)
    python2dist(magnum-tempest-plugin)

python-magnum-tests-tempest-doc:
    python-magnum-tests-tempest-doc



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -r -m dlrn-master -b 1526269
Buildroot used: dlrn-fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 4 Chandan Kumar 2018-01-09 13:46:23 UTC 
https://trunk.rdoproject.org/centos7-master/current/python-magnum-tests-tempest-0.0.1-0.20171226071233.4f8af5f.el7.centos.src.rpm is available on trunk.rdoproject.org
Here is the completion remark: https://review.rdoproject.org/r/#/q/topic:add-magnum-tempest-plugin