Bug 1526394 – 'tc actions del' hangs forever

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1526394 - 'tc actions del' hangs forever

Summary:	'tc actions del' hangs forever

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	iproute (Show other bugs)
Sub Component:
Version:	7.5
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	rc
Target Release:	---
Assigned To:	Phil Sutter
QA Contact:	Jaroslav Aster
Docs Contact:

URL:
Whiteboard:
Keywords:	Regression

Duplicates:	1537960 (view as bug list)
Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-12-15 06:07 EST by Phil Sutter
Modified:	2018-04-10 10:31 EDT (History)
CC List:	3 users (show)

See Also:
Fixed In Version:	iproute-4.11.0-13.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-04-10 10:31:17 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHEA-2018:0815	None	None	None	2018-04-10 10:31 EDT

Groups: None (edit)

Description Phil Sutter 2017-12-15 06:07:24 EST

The 'tc actions' subcommand has a problem:

# tc actions add action pedit munge ip sport set 666
# tc actions list action pedit

	action order 0:  pedit action pass keys 1
 	 index 1 ref 1 bind 0
	 key #0  at 20: val 029a0000 mask 0000ffff
# tc actions del action pedit index 1
   <does not return>

This is fixed by a recent upstream commit:

commit 83cf5bc73b858608d59c3c6126a9f37e793e15dd
Author: Chris Mi <chrism@mellanox.com>
Date:   Thu Dec 14 18:09:00 2017 +0900

    tc: fix command "tc actions del" hang issue
    
    If command is RTM_DELACTION, a non-NULL pointer is passed to rtnl_talk().
    Then flag NLM_F_ACK is not set on n->nlmsg_flags and netlink_ack() will
    not be called. Command tc will wait for the reply for ever.
    
    Fixes: 86bf43c7c2fd ("lib/libnetlink: update rtnl_talk to support malloc buff at run time")
    Reviewed-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: Chris Mi <chrism@mellanox.com>
    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Comment 2 Phil Sutter 2017-12-15 06:10:00 EST

I could reproduce this on a recent RHEL7.5 machine from beaker:

# rpm -q kernel iproute
kernel-3.10.0-823.el7.x86_64
iproute-4.11.0-12.el7.x86_64

Comment 6 Phil Sutter 2018-01-24 05:36:12 EST

*** Bug 1537960 has been marked as a duplicate of this bug. ***

Comment 10 errata-xmlrpc 2018-04-10 10:31:17 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0815

Note You need to log in before you can comment on or make changes to this bug.