Bug 1526513 - restart the container if a new image is being pulled
Summary: restart the container if a new image is being pulled
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: Ceph-Ansible
Version: 3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: 2.5
Assignee: Sébastien Han
QA Contact: Vasishta
URL:
Whiteboard:
: 1543741 (view as bug list)
Depends On:
Blocks: 1537536 1539841
TreeView+ depends on / blocked
 
Reported: 2017-12-15 16:56 UTC by Giulio Fidente
Modified: 2022-02-21 18:06 UTC (History)
13 users (show)

Fixed In Version: RHEL: ceph-ansible-3.0.25-1.el7cp Ubuntu: ceph-ansible_3.0.25-2redhat1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1537536 1539841 (view as bug list)
Environment:
Last Closed: 2018-02-23 18:30:46 UTC
Embargoed:

Attachments (Terms of Use)
FIle contains all.yml,osds.yml,hosts,ansible-playbook log (2.01 MB, text/plain)
2018-02-08 13:52 UTC, subhash 		no flags Details
FIle contains ansible-playbook log ,all.yml,osds.yml,hosts content (2.61 MB, text/plain)
2018-02-12 08:46 UTC, subhash 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Github ceph ceph-ansible pull 2273 0 None closed container: restart container when there is a new image 2020-06-05 20:27:51 UTC
Github ceph ceph-ansible pull 2395 0 None closed Restart if new img new 2020-06-05 20:27:51 UTC

Description Giulio Fidente 2017-12-15 16:56:36 UTC 
site-docker.yml does not restart the containers if a new image is pulled, note that we should implement restart safely, without disruption of service
Comment 3 Ken Dreyer (Red Hat) 2018-01-16 22:52:52 UTC 
Would you please tag a new upstream version on stable-3.0 with this change?
Comment 4 Sébastien Han 2018-01-17 13:11:50 UTC 
The tag is already there Ken, see: https://github.com/ceph/ceph-ansible/releases/tag/v3.0.17

Thanks
Comment 10 subhash 2018-02-08 13:52:47 UTC 
Created attachment 1393189 [details]
FIle contains all.yml,osds.yml,hosts,ansible-playbook log

OSD containers are pointing to old image instead of new image,seems like ceph-osd services are not being restarted.when done manually and checked with docker ps it takes the new Image.Moving to assigned state,attaching the ansible-playbook logs pl let me know if you need anything else
Comment 11 Sébastien Han 2018-02-08 14:12:39 UTC 
subhash, I'm looking into this.
Comment 13 Sébastien Han 2018-02-09 09:37:52 UTC 
*** Bug 1543741 has been marked as a duplicate of this bug. ***
Comment 14 Sébastien Han 2018-02-09 16:16:08 UTC 
subhash, could you test with the patches attached to that BZ?
Thanks.
Comment 16 subhash 2018-02-12 08:46:18 UTC 
Created attachment 1394816 [details]
FIle contains ansible-playbook log ,all.yml,osds.yml,hosts content

Tried the patch by using updated fetch_image.yml file from PR#2385 .osds daemons are not restarting.Here by attaching the logs
Comment 17 Sébastien Han 2018-02-12 13:52:01 UTC 
I have everything fixed in 2 different envs (including yours)
Feel free to retry on your env with a different image.

Hopefully, this bug can be moved to VERIFIED today.
Thanks.
Comment 18 Harish NV Rao 2018-02-12 14:06:13 UTC 
Thanks sebastien! We will move the defect to verified state once we have the build with the fix and it works fine. Could you please move the defect to ON_QA?
Comment 22 Sébastien Han 2018-02-14 01:05:43 UTC 
fix is available in https://github.com/ceph/ceph-ansible/releases/tag/v3.0.25
thanks
Comment 25 subhash 2018-02-14 07:38:42 UTC 
No longer observe the issue in ceph-ansible-3.0.25-1.el7cp. All the daemons are restarted when new image is being pulled with site-docker.yml.
Comment 26 Ken Dreyer (Red Hat) 2018-02-23 18:30:46 UTC 
RHCEPH 2.5 shipped in https://access.redhat.com/errata/RHBA-2018:0340
Note You need to log in before you can comment on or make changes to this bug.