Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
This project is now read‑only. Starting Monday, February 2, please use https://ibm-ceph.atlassian.net/ for all bug tracking management.

Bug 1526513

Summary: restart the container if a new image is being pulled
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Giulio Fidente <gfidente>
Component: Ceph-AnsibleAssignee: Sébastien Han <shan>
Status: CLOSED CURRENTRELEASE QA Contact: Vasishta <vashastr>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.0CC: adeza, aschoen, ceph-eng-bugs, ceph-qe-bugs, gabrioux, gmeno, hnallurv, kdreyer, nthomas, sankarshan, shan, tserlin, vpoliset
Target Milestone: rc   
Target Release: 2.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: RHEL: ceph-ansible-3.0.25-1.el7cp Ubuntu: ceph-ansible_3.0.25-2redhat1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1537536 1539841 (view as bug list) Environment:
Last Closed: 2018-02-23 18:30:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1537536, 1539841    
Attachments:
Description Flags
FIle contains all.yml,osds.yml,hosts,ansible-playbook log
none
FIle contains ansible-playbook log ,all.yml,osds.yml,hosts content none

Description Giulio Fidente 2017-12-15 16:56:36 UTC
site-docker.yml does not restart the containers if a new image is pulled, note that we should implement restart safely, without disruption of service

Comment 3 Ken Dreyer (Red Hat) 2018-01-16 22:52:52 UTC
Would you please tag a new upstream version on stable-3.0 with this change?

Comment 4 Sébastien Han 2018-01-17 13:11:50 UTC
The tag is already there Ken, see: https://github.com/ceph/ceph-ansible/releases/tag/v3.0.17

Thanks

Comment 10 subhash 2018-02-08 13:52:47 UTC
Created attachment 1393189 [details]
FIle contains all.yml,osds.yml,hosts,ansible-playbook log

OSD containers are pointing to old image instead of new image,seems like ceph-osd services are not being restarted.when done manually and checked with docker ps it takes the new Image.Moving to assigned state,attaching the ansible-playbook logs pl let me know if you need anything else

Comment 11 Sébastien Han 2018-02-08 14:12:39 UTC
subhash, I'm looking into this.

Comment 13 Sébastien Han 2018-02-09 09:37:52 UTC
*** Bug 1543741 has been marked as a duplicate of this bug. ***

Comment 14 Sébastien Han 2018-02-09 16:16:08 UTC
subhash, could you test with the patches attached to that BZ?
Thanks.

Comment 16 subhash 2018-02-12 08:46:18 UTC
Created attachment 1394816 [details]
FIle contains ansible-playbook log ,all.yml,osds.yml,hosts content

Tried the patch by using updated fetch_image.yml file from PR#2385 .osds daemons are not restarting.Here by attaching the logs

Comment 17 Sébastien Han 2018-02-12 13:52:01 UTC
I have everything fixed in 2 different envs (including yours)
Feel free to retry on your env with a different image.

Hopefully, this bug can be moved to VERIFIED today.
Thanks.

Comment 18 Harish NV Rao 2018-02-12 14:06:13 UTC
Thanks sebastien! We will move the defect to verified state once we have the build with the fix and it works fine. Could you please move the defect to ON_QA?

Comment 22 Sébastien Han 2018-02-14 01:05:43 UTC
fix is available in https://github.com/ceph/ceph-ansible/releases/tag/v3.0.25
thanks

Comment 25 subhash 2018-02-14 07:38:42 UTC
No longer observe the issue in ceph-ansible-3.0.25-1.el7cp. All the daemons are restarted when new image is being pulled with site-docker.yml.

Comment 26 Ken Dreyer (Red Hat) 2018-02-23 18:30:46 UTC
RHCEPH 2.5 shipped in https://access.redhat.com/errata/RHBA-2018:0340