Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://sagitter.fedorapeople.org/giacpy/giacpy.spec SRPM URL: https://sagitter.fedorapeople.org/giacpy/giacpy-0.6.2-1.fc27.src.rpm Description: A Cython frontend to the c++ library Giac (Computer Algebra System) Fedora Account System Username: sagitter
- Grab the source from Pythonhosted: https://files.pythonhosted.org/packages/source/g/giacpy/giacpy-%{version}.tar.gz - I don't think the packaging is right. The main package should be python-giacpy, with two subpackages python2-giacpy and python3-giacpy - The whole build process is wrong, I mean, separating python2 and python3 in two folders, building them separately, all of this is unnecessary. See the sample file to get an idea on how to package it: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file - Here's my take on it: %global srcname giacpy %global giacver 1.4.9.1 # Architectures currently not supported # http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=19&t=1723 ExcludeArch: aarch64 %{power64} s390x Name: python-%{srcname} Version: 0.6.2 Release: 1%{?dist} Summary: Python binding for Giac License: GPLv2+ URL: http://webusers.imj-prg.fr/~frederic.han/xcas/giacpy/ Source0: https://files.pythonhosted.org/packages/source/g/%{srcname}/%{srcname}-%{version}.tar.gz %description A Cython frontend to the c++ library Giac (Computer Algebra System) %package -n python2-%{srcname} Summary: Python2 binding for Giac %{?python_provide:%python_provide python2-%{srcname}} BuildRequires: giac-devel >= %{giacver} BuildRequires: gmp-devel BuildRequires: python2-devel BuildRequires: python2-Cython Requires: qcas%{?_isa} %description -n python2-%{srcname} A Cython frontend to the c++ library Giac (Computer Algebra System) %package -n python3-%{srcname} Summary: Python3 binding for Giac %{?python_provide:%python_provide python3-%{srcname}} BuildRequires: giac-devel >= %{giacver} BuildRequires: gmp-devel BuildRequires: python3-devel BuildRequires: python3-Cython Requires: qcas%{?_isa} %description -n python3-%{srcname} A Cython frontend to the c++ library Giac (Computer Algebra System) %prep %autosetup -n %{srcname}-%{version} rm -rf %{srcname}.egg-info %build %py2_build %py3_build %install %py2_install %py3_install %check pushd giacpy export PYTHONPATH=$RPM_BUILD_ROOT%{python2_sitearch} %{__python2} -m doctest giacpy.pyx -v export PYTHONPATH=$RPM_BUILD_ROOT%{python3_sitearch} %{__python3} -m doctest giacpy.pyx -v popd %files -n python2-%{srcname} %doc README.txt %license giacpy/GPL-2 %{python2_sitearch}/%{srcname}/ %{python2_sitearch}/%{srcname}-%{version}-py?.?.egg-info/ %files -n python3-%{srcname} %doc README.txt %license giacpy/GPL-2 %{python3_sitearch}/%{srcname}/ %{python3_sitearch}/%{srcname}-%{version}-py?.?.egg-info/ %changelog * Sat Dec 02 2017 Antonio Trande <sagitterATfedoraproject.org> - 0.6.2-1 - Initial package
Spec URL: https://sagitter.fedorapeople.org/giacpy/python-giacpy.spec SRPM URL: https://sagitter.fedorapeople.org/giacpy/python-giacpy-0.6.5-1.fc27.src.rpm - Release 0.6.5 - Source package renamed with python- suffix as required by Python guidelines - Source url grabbed by pythonhosted.org's repository - Building processes restricted to the original directory
- You should put the development files in two -devel subpackages, python2-giacpy-devel and python3-giacpy-devel: Issues: ======= - Header files in -devel subpackage, if present. Note: python2-giacpy : /usr/lib64/python2.7/site- packages/giacpy/giacpymisc.h python3-giacpy : /usr/lib64/python3.6/site- packages/giacpy/giacpymisc.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages python2-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/giacpy/giacpy.cpp python2-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/giacpy/giacpymisc.h python3-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/giacpy/giacpy.cpp python3-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/giacpy/giacpymisc.h Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python2-giacpy : /usr/lib64/python2.7/site- packages/giacpy/giacpymisc.h python3-giacpy : /usr/lib64/python3.6/site- packages/giacpy/giacpymisc.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GPL". 12 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-giacpy/review-python- giacpy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-giacpy , python3-giacpy [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-giacpy-0.6.5-1.fc28.x86_64.rpm python3-giacpy-0.6.5-1.fc28.x86_64.rpm python-giacpy-debuginfo-0.6.5-1.fc28.x86_64.rpm python-giacpy-debugsource-0.6.5-1.fc28.x86_64.rpm python-giacpy-0.6.5-1.fc28.src.rpm python2-giacpy.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end python2-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/giacpy/giacpy.cpp python2-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/giacpy/giacpymisc.h python3-giacpy.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end python3-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/giacpy/giacpy.cpp python3-giacpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/giacpy/giacpymisc.h python-giacpy-debugsource.x86_64: W: no-documentation python-giacpy.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end 5 packages and 0 specfiles checked; 0 errors, 8 warnings.
Spec URL: https://sagitter.fedorapeople.org/giacpy/python-giacpy.spec SRPM URL: https://sagitter.fedorapeople.org/giacpy/python-giacpy-0.6.5-1.fc27.src.rpm - Release 0.6.5 - Enable qcas support - Packaging of the development files
Why do you remove the CPP file instead of including it to the -devel subpackages?
Because it's unnecessary.
Well the install script includes it for a reason I suppose. Package approved anyway.
(In reply to Robert-André Mauchin from comment #7) > Well the install script includes it for a reason I suppose. Not always. http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=24&t=1987#p9784 > > Package approved anyway. Thank you.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-giacpy
python-giacpy-0.6.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6942b9aeae
python-giacpy-0.6.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d1ab3e4970
python-giacpy-0.6.5-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-28145db148
python-giacpy-0.6.5-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e0bc7a4b2
python-giacpy-0.6.5-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e0bc7a4b2
python-giacpy-0.6.5-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-28145db148
python-giacpy-0.6.5-3.fc26 qcas-0.5.3-5.fc26 giac-1.4.9.45-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-20e6c0f7cc
python-giacpy-0.6.5-3.fc27 qcas-0.5.3-5.fc27 giac-1.4.9.45-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6fd9d49e4d
giac-1.4.9.45-2.fc26, python-giacpy-0.6.5-3.fc26, qcas-0.5.3-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-20e6c0f7cc
giac-1.4.9.45-2.fc27, python-giacpy-0.6.5-3.fc27, qcas-0.5.3-5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6fd9d49e4d
giac-1.4.9.45-2.fc26, python-giacpy-0.6.5-3.fc26, qcas-0.5.3-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
giac-1.4.9.45-2.fc27, python-giacpy-0.6.5-3.fc27, qcas-0.5.3-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.