Bug 1526799 - [UI] - Add/Edit VM's vNIC dropdown: add external provider indication if relevant
Summary: [UI] - Add/Edit VM's vNIC dropdown: add external provider indication if relevant
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: ---
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.2.5
: 4.2.5
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-17 13:46 UTC by Michael Burman
Modified: 2019-04-28 09:21 UTC (History)
8 users (show)

Fixed In Version: ovirt-engine-4.2.5
Clone Of:
Environment:
Last Closed: 2018-07-31 15:26:15 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: ovirt-4.3+
danken: devel_ack+


Attachments (Terms of Use)
record1 (1.21 MB, application/x-gzip)
2017-12-17 13:46 UTC, Michael Burman
no flags Details
external network indication (73.19 KB, image/png)
2018-07-03 12:01 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 92242 0 master MERGED webadmin: Add information about external network into vm nic creation 2018-06-15 09:54:25 UTC
oVirt gerrit 92281 0 ovirt-engine-4.2 MERGED webadmin: Add information about external network into vm nic creation 2018-06-20 06:10:42 UTC

Description Michael Burman 2017-12-17 13:46:54 UTC
Created attachment 1369024 [details]
record1

Description of problem:
[UI] - Add/Edit VM's vNIC - Add indication in the Profile drop down list that the profile is an external network profile.

In the the add/edit VM's vNIC, we have the 'Profile' drop down list to choose which profile we would like to assign to the VM's vNIC, we also have a nice place there for the profile's description, but we using it only for 'Empty' profiles. 
We should add an indication for external network provider profiles, which will make it easier to understand which profile belong to a regular network and which profile is an external network profile. We already have a place for it, we just need to add this info. 

Version-Release number of selected component (if applicable):
4.2.0.2-0.1.el7

How reproducible:
100

Steps to Reproduce:
1. Create or import a network from external provider
2. Add this network to a VM's vNIC

Actual results:
No indication in the profile drop down list about this network been an external network.

Comment 1 Dan Kenigsberg 2017-12-17 19:05:56 UTC
Why is it important for the user to tell if a profile is native-based or external-based?

Comment 2 Michael Burman 2017-12-18 06:17:48 UTC
(In reply to Dan Kenigsberg from comment #1)
> Why is it important for the user to tell if a profile is native-based or
> external-based?

From my daily work this info can be useful as i have a lot of networks in the DC with similar names, for example: net1, net-1, net_1 and so on..some of them native based and some ovn networks, when assigning then this networks to the VM's vNIC via the profile drop down list, i sometimes can't recall which is which and which network is a native based or ovn external network. 

I'm not saying it's the most important, but it can be useful and nice, specially that we have a perfect place for it in the drop down list already. Adding external provider name can be something that can be used.

Comment 3 Ales Musil 2018-05-14 07:50:50 UTC
Hi Michael, 

just for clarification the title says that it should display provider name, in the description is just some indication. So is the indication sufficient? Because mapping the provider name would require larger changes.

Comment 4 Michael Burman 2018-05-14 09:14:30 UTC
(In reply to Ales Musil from comment #3)
> Hi Michael, 
> 
> just for clarification the title says that it should display provider name,
> in the description is just some indication. So is the indication sufficient?
> Because mapping the provider name would require larger changes.

Hi Ales, to which description you refer to? i would like to see some indication in the VM's vNIC drop down list. Not in network's description. 
Yes, i asked to add the provider or at least some indication if it's native one or ovn network. Because it may have similar names. Lets talk in the chat)

Comment 5 Michael Burman 2018-07-03 11:57:13 UTC
Verified on - 4.2.5-0.1.el7ev

Comment 6 Michael Burman 2018-07-03 12:01:12 UTC
Created attachment 1456217 [details]
external network indication

external network indication in the VM's drop down profile list

Comment 7 Sandro Bonazzola 2018-07-31 15:26:15 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.