Bug 1527134 – Removing a disk with a non-existent snapshot fails

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1527134 - Removing a disk with a non-existent snapshot fails

Summary:	Removing a disk with a non-existent snapshot fails

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine (Show other bugs)
Sub Component:
Version:	4.1.7
Hardware:	Unspecified Linux

Priority	unspecified Severity medium
Target Milestone:	ovirt-4.2.1
Target Release:	---
Assigned To:	nobody nobody
QA Contact:	Natalie Gavrielov
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-12-18 10:56 EST by Gordon Watson
Modified:	2018-05-15 13:48 EDT (History)
CC List:	10 users (show)

See Also:
Fixed In Version:	ovirt-engine-4.2.1.1
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-05-15 13:46:56 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Knowledge Base (Solution)	3291611	None	None	None	2017-12-18 11:14 EST
oVirt gerrit	85568	master	MERGED	core: ImagesHandler#prepareSnapshotConfigWithAlternateImage	2017-12-19 09:05 EST
Red Hat Product Errata	RHEA-2018:1488	None	None	None	2018-05-15 13:48 EDT

Groups: None (edit)

Description Gordon Watson 2017-12-18 10:56:27 EST

Description of problem:

Attempting to remove a disk that has a snapshot that no longer exists will fail and report an NPE;

2017-12-05 08:01:50,748 ERROR [org.ovirt.engine.core.bll.RemoveImageCommand] (org.ovirt.thread.pool-6-thread-50) [3cc86586] Exception: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.ImagesHandler.prepareSnapshotConfigWithAlternateImage(ImagesHandler.java:835) [bll.jar:]



Version-Release number of selected component (if applicable):

RHV 4.1.7


How reproducible:

100%

Steps to Reproduce:
1. Create a VM.
2. Add a disk.
3. Create a snapshot.
4. Delete the snapshots table entry.
5. 'Remove permanently' from the GUI.


Actual results:


Expected results:


Additional info:

Comment 3 Natalie Gavrielov 2018-02-07 09:38:36 EST

Allon,

I tried the scenario described in comment 0, and now the snapshot that was deleted from the db is removed automatically from the GUI (after a few seconds), is this the expected behavior?

Comment 4 Allon Mureinik 2018-02-07 10:13:05 EST

(In reply to Natalie Gavrielov from comment #3)
> Allon,
> 
> I tried the scenario described in comment 0, and now the snapshot that was
> deleted from the db is removed automatically from the GUI (after a few
> seconds), is this the expected behavior?

If a snapshot is removed from the DB I'd indeed expect it to be removed from the UI.
The verification here is to attempt to remove a disk that references that snapshot and see it doesn't crash horribly.

Comment 5 Natalie Gavrielov 2018-02-07 10:25:21 EST

Verified using:
rhvm-4.2.1.6-0.1.el7.noarch
vdsm-4.20.17-1.el7ev.x86_64

Now disk can be removed from the GUI, no NPE.

Comment 10 errata-xmlrpc 2018-05-15 13:46:56 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1488

Note You need to log in before you can comment on or make changes to this bug.