Bug 1527335 - wrong self.logger calls: self.log.error should be self.logger.error
Summary: wrong self.logger calls: self.log.error should be self.logger.error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-hosted-engine-setup
Classification: oVirt
Component: General
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.2.2
: 2.2.3
Assignee: Ido Rosenzwig
QA Contact: Nikolai Sednev
URL:
Whiteboard:
Depends On:
Blocks: 1458709
TreeView+ depends on / blocked
 
Reported: 2017-12-19 09:22 UTC by Ido Rosenzwig
Modified: 2018-03-29 10:53 UTC (History)
3 users (show)

Fixed In Version: ovirt-hosted-engine-setup-2.2.3
Clone Of:
Environment:
Last Closed: 2018-03-29 10:53:41 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 85575 0 master MERGED src: plugins: fix typo mistakes 2018-09-03 09:37:19 UTC

Description Ido Rosenzwig 2017-12-19 09:22:15 UTC
Description of problem:

typo mistakes: 
Some files contain self.log.error instead of self.logger.error

Comment 1 Nikolai Sednev 2018-02-14 12:28:11 UTC
Please provide more detailed reproduction steps.

Comment 2 Ido Rosenzwig 2018-02-14 12:31:10 UTC
hosted-engine --deploy --noansible with default answers

Comment 3 Nikolai Sednev 2018-02-14 12:37:55 UTC
(In reply to Ido Rosenzwig from comment #2)
> hosted-engine --deploy --noansible with default answers

"typo mistakes: 
Some files contain self.log.error instead of self.logger.error"

After deployment, what I should look for? Where I should check the logs or what?

Comment 4 Ido Rosenzwig 2018-02-14 12:48:57 UTC
No. just check that deployment finish successfully.

self.log.error is a typo mistake that may fail the deployment, it should be self.logger.error for it to work properly.

Nothing specific to check beside successful deployment

Comment 5 Nikolai Sednev 2018-02-14 13:55:32 UTC
Deployment is working fine on NFS, Gluster and FC.
ovirt-hosted-engine-ha-2.2.4-1.el7ev.noarch
ovirt-hosted-engine-setup-2.2.9-1.el7ev.noarch
rhvm-appliance-4.2-20180202.0.el7.noarch
Linux 3.10.0-693.17.1.el7.x86_64 #1 SMP Sun Jan 14 10:36:03 EST 2018 x86_64 x86_64 x86_64 GNU/Linux

Comment 6 Sandro Bonazzola 2018-03-29 10:53:41 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.