RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1527653 - nfs-server.service should use systemctl rather than reading pidfile and kill
Summary: nfs-server.service should use systemctl rather than reading pidfile and kill
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: nfs-utils
Version: 7.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Steve Dickson
QA Contact: Yongcheng Yang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-19 18:55 UTC by Robbie Harwood
Modified: 2018-10-30 11:48 UTC (History)
6 users (show)

Fixed In Version: nfs-utils-1.3.0-0.55.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-30 11:48:04 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3311 0 None None None 2018-10-30 11:48:44 UTC

Description Robbie Harwood 2017-12-19 18:55:49 UTC 
nfs-server.service, in the [Service] section, contains this line:

    ExecStartPre=-/bin/sh -c '/bin/kill -HUP `cat /run/gssproxy.pid`'

It would be better if instead it called `systemctl reload gssproxy` (or `systemctl reload-or-restart gssproxy` if you prefer), which will accomplish the same thing.

I would of course prefer that this be resolved in Fedora first.  However, the unit file on Fedora doesn't appear to contain anything that resembles this line.  I am curious if that is also a bug, or if the code just behaves differently there.

Thanks!
Comment 2 Steve Dickson 2017-12-19 21:08:01 UTC 
(In reply to Robbie Harwood from comment #0)
> nfs-server.service, in the [Service] section, contains this line:
> 
>     ExecStartPre=-/bin/sh -c '/bin/kill -HUP `cat /run/gssproxy.pid`'
> 
> It would be better if instead it called `systemctl reload gssproxy` (or
> `systemctl reload-or-restart gssproxy` if you prefer), which will accomplish
> the same thing.
> 
> I would of course prefer that this be resolved in Fedora first.  However,
> the unit file on Fedora doesn't appear to contain anything that resembles
> this line.  I am curious if that is also a bug, or if the code just behaves
> differently there.
How important is this? Can it wait for 7.6 or try to get
it in 7.5?
Comment 4 Robbie Harwood 2017-12-20 18:02:32 UTC 
Sorry, forgot to set flag.  It can wait.
Comment 5 Yongcheng Yang 2018-01-31 02:05:23 UTC 
Hi Steve, would this issue wait for 7.6 or try to get in 7.5?
Comment 6 Robbie Harwood 2018-01-31 08:13:01 UTC 
Per comment#4 this can wait.
Comment 7 Yongcheng Yang 2018-03-28 11:17:21 UTC 
Deferring to 7.6 now :)
Comment 8 Yongcheng Yang 2018-06-28 08:53:39 UTC 
Looks like the nfs calls `systemctl restart gssproxy` instead of `reload` as comment #0 mentioned. It seems to result in the same consequences as expected.

However, I don't know whether there's any concern about it.

~~~~~~~~~~~~~~~~~~~~~~~~
Checked with version -55
~~~~~~~~~~~~~~~~~~~~~~~~
[root@test ~]# rpm -q nfs-utils
nfs-utils-1.3.0-0.55.el7.x86_64
[root@test ~]# systemctl restart gssproxy ; systemctl status gssproxy -l
● gssproxy.service - GSSAPI Proxy Daemon
   Loaded: loaded (/usr/lib/systemd/system/gssproxy.service; disabled; vendor preset: disabled)
   Active: active (running) since Thu 2018-06-28 04:38:21 EDT; 5ms ago
  Process: 20836 ExecStart=/usr/sbin/gssproxy -D (code=exited, status=0/SUCCESS)
 Main PID: 20837 (gssproxy)               <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
   CGroup: /system.slice/gssproxy.service
           └─20837 /usr/sbin/gssproxy -D

Jun 28 04:38:21 test systemd[1]: Starting GSSAPI Proxy Daemon...
Jun 28 04:38:21 test gssproxy[20836]: [2018/06/28 08:38:21]: Debug Enabled (level: 1)
Jun 28 04:38:21 test gssproxy[20836]: [2018/06/28 08:38:21]: Problem with kernel communication!  NFS server will not work
Jun 28 04:38:21 test gssproxy[20836]: [2018/06/28 08:38:21]: Client connected (fd = 11)[2018/06/28 08:38:21]:  (pid = 20837) (uid = 0) (gid = 0)[2018/06/28 08:38:21]:  (context = system_u:system_r:kernel_t:s0)[2018/06/28 08:38:21]:
Jun 28 04:38:21 test systemd[1]: Started GSSAPI Proxy Daemon.
[root@test ~]# 
[root@test ~]# systemctl restart nfs ; systemctl status gssproxy -l
● gssproxy.service - GSSAPI Proxy Daemon
   Loaded: loaded (/usr/lib/systemd/system/gssproxy.service; disabled; vendor preset: disabled)
   Active: active (running) since Thu 2018-06-28 04:38:28 EDT; 10ms ago
  Process: 20890 ExecStart=/usr/sbin/gssproxy -D (code=exited, status=0/SUCCESS)
 Main PID: 20891 (gssproxy)                 <<<<<<<<<<<<<<<<<<<<< PID changes
   CGroup: /system.slice/gssproxy.service
           └─20891 /usr/sbin/gssproxy -D

Jun 28 04:38:28 test systemd[1]: Starting GSSAPI Proxy Daemon...
Jun 28 04:38:28 test gssproxy[20890]: [2018/06/28 08:38:28]: Debug Enabled (level: 1)
Jun 28 04:38:28 test gssproxy[20890]: [2018/06/28 08:38:28]: Problem with kernel communication!  NFS server will not work
Jun 28 04:38:28 test gssproxy[20890]: [2018/06/28 08:38:28]: Client connected (fd = 11)[2018/06/28 08:38:28]:  (pid = 20891) (uid = 0) (gid = 0)[2018/06/28 08:38:28]:  (context = system_u:system_r:kernel_t:s0)[2018/06/28 08:38:28]:
Jun 28 04:38:28 test systemd[1]: Started GSSAPI Proxy Daemon.
[root@test ~]# 

~~~~~~~~~~~~~~~~~~~~~~~~~~
Compared with previous -54
~~~~~~~~~~~~~~~~~~~~~~~~~~
[root@test nfs]# rpm -q nfs-utils
nfs-utils-1.3.0-0.54.el7.x86_64
[root@test nfs]# systemctl restart gssproxy ; systemctl status gssproxy -l
● gssproxy.service - GSSAPI Proxy Daemon
   Loaded: loaded (/usr/lib/systemd/system/gssproxy.service; disabled; vendor preset: disabled)
   Active: active (running) since Thu 2018-06-28 04:47:57 EDT; 6ms ago
  Process: 10725 ExecReload=/bin/kill -HUP $MAINPID (code=exited, status=0/SUCCESS)
  Process: 10894 ExecStart=/usr/sbin/gssproxy -D (code=exited, status=0/SUCCESS)
 Main PID: 10895 (gssproxy)          <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
   CGroup: /system.slice/gssproxy.service
           └─10895 /usr/sbin/gssproxy -D

Jun 28 04:47:57 test systemd[1]: Starting GSSAPI Proxy Daemon...
Jun 28 04:47:57 test gssproxy[10894]: [2018/06/28 08:47:57]: Debug Enabled (level: 1)
Jun 28 04:47:57 test gssproxy[10894]: [2018/06/28 08:47:57]: Problem with kernel communication!  NFS server will not work
Jun 28 04:47:57 test gssproxy[10894]: [2018/06/28 08:47:57]: Client connected (fd = 11)[2018/06/28 08:47:57]:  (pid = 10895) (uid = 0) (gid = 0)[2018/06/28 08:47:57]:  (context = system_u:system_r:kernel_t:s0)[2018/06/28 08:47:57]:
Jun 28 04:47:57 test systemd[1]: Started GSSAPI Proxy Daemon.
[root@test nfs]# systemctl restart nfs ; systemctl status gssproxy -l
● gssproxy.service - GSSAPI Proxy Daemon
   Loaded: loaded (/usr/lib/systemd/system/gssproxy.service; disabled; vendor preset: disabled)
   Active: active (running) since Thu 2018-06-28 04:47:57 EDT; 7s ago
  Process: 10725 ExecReload=/bin/kill -HUP $MAINPID (code=exited, status=0/SUCCESS)
  Process: 10894 ExecStart=/usr/sbin/gssproxy -D (code=exited, status=0/SUCCESS)
 Main PID: 10895 (gssproxy)          <<<<<<<<<<<<<<<<<< PID *not* changes
   CGroup: /system.slice/gssproxy.service
           └─10895 /usr/sbin/gssproxy -D

Jun 28 04:47:57 test gssproxy[10894]: [2018/06/28 08:47:57]: Problem with kernel communication!  NFS server will not work
Jun 28 04:47:57 test gssproxy[10894]: [2018/06/28 08:47:57]: Client connected (fd = 11)[2018/06/28 08:47:57]:  (pid = 10895) (uid = 0) (gid = 0)[2018/06/28 08:47:57]:  (context = system_u:system_r:kernel_t:s0)[2018/06/28 08:47:57]:
Jun 28 04:47:57 test systemd[1]: Started GSSAPI Proxy Daemon.
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: Received SIGHUP; re-reading config. <<<<<<<<<<<<<<
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: Keytab /etc/krb5.keytab has no content (-1765328203)
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: Service: nfs-server, Enckey: [ephemeral], Enctype: 18
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: Keytab /etc/krb5.keytab has no content (-1765328203)
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: Service: nfs-client, Enckey: [ephemeral], Enctype: 18
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: Debug Enabled (level: 1)
Jun 28 04:48:05 test gssproxy[10894]: [2018/06/28 08:48:05]: New config loaded successfully. <<<<<<<<<<<<<<<<<<<
[root@test nfs]#
Comment 10 Yongcheng Yang 2018-07-23 10:19:44 UTC 
Moving to VERIFIED according to comment #8
Comment 12 errata-xmlrpc 2018-10-30 11:48:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3311
Note You need to log in before you can comment on or make changes to this bug.