1528261 – remove --pool-inactive from thin_trim manpage

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1528261 - remove --pool-inactive from thin_trim manpage

Summary: remove --pool-inactive from thin_trim manpage

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	device-mapper-persistent-data
Sub Component:
Version:	7.5
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	Joe Thornber
QA Contact:	Lin Li
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1774000
TreeView+	depends on / blocked

Reported:	2017-12-21 11:21 UTC by Jakub Krysl
Modified:	2021-09-03 12:03 UTC (History)
CC List:	9 users (show)
Fixed In Version:	device-mapper-persistent-data-0.8.5-2.el7
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Clones:	1774000 (view as bug list)
Environment:
Last Closed:	2020-03-31 20:11:26 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2020:1188	0	None	None	None	2020-03-31 20:11:33 UTC

Description Jakub Krysl 2017-12-21 11:21:55 UTC

Description of problem:
Option --pool-inactive is still listed in thin_trim manpage but not in thin_trim --help:
# man thin_trim
NAME
       thin_trim - Issue discard requests for free pool space (offline tool).

SYNOPSIS
       thin_trim [options] --metadata-dev {device|file} --data-dev {device|file}

DESCRIPTION
       thin_trim sends discard requests to the pool device for unprovisioned areas.

       This tool cannot be run on live metadata.

OPTIONS
       -h, --help
              Print help and exit.

       -V, --version
              Print version information and exit.

       --pool-inactive
              Indicates you are aware the pool should be inactive.

           Suppresses a warning message and prompt.

# thin_trim --help
Usage: thin_trim [options] --metadata-dev {device|file} --data-dev {device|file}
Options:
  {-h|--help}
  {-V|--version}

According to message given when this option is used, the option is obsolete and should be removed from manpage too.
# thin_trim --pool-inactive --metadata-dev dev --data-dev dev                       
--pool-inactive no longer required since we ensure the metadata device is opened exclusively. 

Version-Release number of selected component (if applicable):
device-mapper-persistent-data-0.7.3-3.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. man thin_trim
2. thin_trim --help
1. thin_trim --pool-inactive --metadata-dev dev --data-dev dev                       
--pool-inactive no longer required since we ensure the metadata device is opened exclusively. 

Actual results:
--pool-inactive option in manpage but not --help

Expected results:
The option --pool-inactive is gone from manpage

Additional info:

Comment 2 Jakub Krysl 2019-10-02 11:41:03 UTC

Mass migration to lilin.

Comment 5 Lin Li 2019-11-29 07:17:49 UTC

Reproduced on device-mapper-persistent-data-0.8.5-1.el7
[root@storageqe-71 ~]# rpm -qa | grep device-mapper-persistent-data
device-mapper-persistent-data-0.8.5-1.el7.x86_64

[root@storageqe-71 ~]# man thin_trim
NAME
       thin_trim  -  Issue  discard  requests  for free pool space
       (offline tool).

SYNOPSIS
       thin_trim [options] --metadata-dev {device|file} --data-dev {device|file}
DESCRIPTION
       thin_trim sends discard requests to  the  pool  device  for
       unprovisioned areas.

       This tool cannot be run on live metadata.

OPTIONS
       -h, --help
              Print help and exit.

       -V, --version
              Print version information and exit.

       --pool-inactive           <-------------------------------------------------------
              Indicates you are aware the pool should be inactive.     

           Suppresses a warning message and prompt.



Verified on device-mapper-persistent-data-0.8.5-2.el7
[root@storageqe-71 ~]# rpm -qa | grep device-mapper-persistent-data
device-mapper-persistent-data-0.8.5-2.el7.x86_64

[root@storageqe-71 ~]# man thin_trim
NAME
       thin_trim - Issue discard requests for free pool space (offline tool).

SYNOPSIS
       thin_trim [options] --metadata-dev {device|file} --data-dev {device|file}

DESCRIPTION
       thin_trim  sends  discard  requests  to  the pool device for unprovisioned
       areas.

       This tool cannot be run on live metadata.

OPTIONS
       -h, --help
              Print help and exit.
       -V, --version
              Print version information and exit.




Test result: ---pool-inactive removed from thin_trim manpage

Comment 7 errata-xmlrpc 2020-03-31 20:11:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1188

Note You need to log in before you can comment on or make changes to this bug.