Created attachment 1371564 [details] spec file of python-pqclient-0.0.1-1.fc25.src.rpm python-pqclient is a library package required by Ironic plugin driver for FUJITSU Server PRIMEQUEST's ManageMent Board (MMB). Source code; https://github.com/openstack/python-pqclient PyPI: https://pypi.python.org/pypi/python-pqclient Please see the Ironic spec below for details or Ironic plugin driver. Support a new hardware type for Fujitsu PRIMEQUEST MMB http://specs.openstack.org/openstack/ironic-specs/specs/approved/support-fujitsu-pq-mmb-driver.html We were recommended by Red Hat engineer that we should contribute the package to RDO before including into OSP. So, could you please review spec file and add python-pqclient into RDO? Yasuyuki Kobayashi
Created attachment 1371565 [details] srpm
Hi Haikel, Would you please review spec file below? https://bugzilla.redhat.com/attachment.cgi?id=1371564 Yasuyuki
Hi Yasuyuki, The process to review packages for RDO is slightly different to the Fedora one. It is detailed in [1]. Since the bz is already opened, I will take care of the final detail in step 1 (run an initial licensecheck). Once it is done, you should open a review in review.rdoproject.org to request the package addition to the rdoinfo repository. [1] - https://www.rdoproject.org/documentation/add-packages/
I can't find the repository at https://github.com/openstack/python-pqclient or https://git.openstack.org/cgit/openstack/python-pqclient, where is it?
Hi Javier, Thank you for reviewing the spec file. We're working on the patch below to host our code in the repository but not yet merged at this moment... https://review.openstack.org/#/c/527612/ Best regards, Yasuyuki
Hi Javier, Any updates on spec review? Is it pre-requisite for reviewee to have the git repository for being reviewed spec file? Best regards, Yasuyuki
Hi Yasuyuki, Yes, we need to have a source git repository somewhere to use for the review. I don't know if the repository is being migrated from elsewhere, in that case we could use the current location instead, and change it later when the git repo is officially created under git.openstack.org.
Hi Javier, Thank you for the suggestion! I'll check our engineer about ETA of landing the code in openstack git repository. If it takes long, I'll go with your suggestion. Best regards, Yasuyuki
Hi Javier, Unfortunately, it take for a while to have the code in openstack git repository. So, I'd like to use git repository below. https://github.com/furukawa3/python-pqclient Would you please run an initial licensecheck)? I don't find place to specify git repository URL in spec file and the URL will be specified in rdoinfo/rdo.yml. So, I suppose I don't need to modify spec file attached this bug for now. Best regards, Yasuyuki
Hi Yasuyuki, I have checked the repo, and there is no actual code in it, just the initial cookiecutter output. I think we should wait until there is real code inside it before trying to package the client. Regards, Javier
Hi Javier, According to BZ#1530116#C3, FJ has decided to stop development of MMB drivers for PRIMEQUEST servers for now and closed the RFE as WONTFIX. So, I'll close this BZ as well. Thank you very much for your work on this BZ. Best regards, Yasuyuki