Bug 1528862 - Review Request: python-tasklib - Python Task Warrior library
Summary: Review Request: python-tasklib - Python Task Warrior library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mairi Dulaney
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-24 17:05 UTC by Ankur Sinha (FranciscoD)
Modified: 2018-01-10 02:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-09 16:49:14 UTC
Type: ---
Embargoed:
jdulaney: fedora-review+


Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2017-12-24 17:05:15 UTC
Spec URL: https://ankursinha.fedorapeople.org/python-tasklib/python-tasklib.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-tasklib/python-tasklib-1.1.0-1.fc27.src.rpm

Description: 
tasklib is a Python library for interacting with taskwarrior databases, using a
queryset API similar to that of Django’s ORM.

Supports Python 2.6, 2.7, 3.2, 3.3 and 3.4 with taskwarrior 2.1.x and above.
Older versions of taskwarrior are untested and may not work.

Here's a copr for test builds:
https://copr.fedorainfracloud.org/coprs/ankursinha/tasklib/
Fedora Account System Username: ankursinha

Comment 1 Mairi Dulaney 2017-12-24 21:27:44 UTC
A couple of notes:

Are you missing a couple of Requires?   install_requirements = ['six>=1.4', 'pytz', 'tzlocal'] from setup.py


You have a couple spurious newlines at the end of your spec file

Comment 2 Ankur Sinha (FranciscoD) 2017-12-24 22:00:50 UTC
Ah, yeh - added them to BR, forgot to add them as Requires.

Update spec/srpm:

Spec URL: https://ankursinha.fedorapeople.org/python-tasklib/python-tasklib.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-tasklib/python-tasklib-1.1.0-2.fc27.src.rpm

Cheers!

Merry Christmas too! :)

Comment 3 Mairi Dulaney 2017-12-24 23:26:16 UTC
Okay, looks good, approved!

Happy Festivus!

Comment 4 Gwyn Ciesla 2017-12-27 12:50:20 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-tasklib

Comment 5 Fedora Update System 2017-12-27 17:51:28 UTC
python-tasklib-1.1.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd1f96f911

Comment 6 Fedora Update System 2017-12-27 17:52:23 UTC
python-tasklib-1.1.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4cd4fe7eac

Comment 7 Fedora Update System 2017-12-27 22:38:11 UTC
python-tasklib-1.1.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd1f96f911

Comment 8 Fedora Update System 2017-12-27 23:11:18 UTC
python-tasklib-1.1.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4cd4fe7eac

Comment 9 Fedora Update System 2018-01-09 16:49:14 UTC
python-tasklib-1.1.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2018-01-10 02:02:57 UTC
python-tasklib-1.1.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.