Bug 152889
| Summary: | mc CAN-2004-0226,0231,0232,0494,1004,1005,1009,1090,1091,1092,1093,1174,1175,1176,2005-0763 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Fedora Legacy | Reporter: | David Lawrence <dkl> | ||||||||
| Component: | mc | Assignee: | Dominic Hargreaves <dom> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | |||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | unspecified | CC: | barryn, bressers, deisenst, jimpop, jnovy, leonard-rh-bugzilla, marc.deslauriers, m.koshelev, pekkas, sheltren | ||||||||
| Target Milestone: | --- | Keywords: | Security | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | http://www.debian.org/security/2005/dsa-639 | ||||||||||
| Whiteboard: | 2, 1, LEGACY, rh73, rh90 | ||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2005-08-10 23:49:57 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
David Lawrence
2005-03-30 23:31:05 UTC
One more advisory for RHL 7.3: CAN-2005-0763, see bug 153982. David, could you be so kind to remove that "leonard at" address from this entry and replace it with "leonard-rh-bugzilla at" please? I'd say just tackle the rh9/fc1 bugs here, then finish off the rh73 update separately. One more issue. I've used the Debian patch for CAN-2004-0226, but there seem to be some discrepancies between it and the original patch from Jakub (compare Fedora legcay b 1548 c 10 & 15, this issue is not in the original patch). I'll bring up these discrepancies for discussion once I've sorted them out. Packages as QA'd by Marc for rh9 and fc1 are on their way to updates-testing. Do I need to abandon that? No. Those are fine (apart from the fact that the patches are in big blobs instead of separated out). The real problems are with RHL 7.3 (mc-4.5.55). For RHL 7.3 I've decided to use the patch for CAN-2004-0226 from RHEL 2.1 as it is more complete than the Debian patch. Apart from some fixing to get the patches applied I also added a temp file fix for lib/cedit.menu that went into CVS but is missing from RHEL 2.1. The original patch is split out so we now have separate patches for CAN-2004-0226, CAN-2004-0231 and CAN-2004-0232. Feel free to comment if you think some of the hunks ended up in the wrong patch. The original CAN-2004-0226 patch also contained vfs/extfs quoting fixes which were later assigned CAN-2004-0494. There are a few hunks in the original patch that appear not to be security fixes but I left them in as separate patches anyway (small ftpfs and fish fixes). -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Packages fixing CAN-2004-0226, CAN-2004-0231, CAN-2004-0232, CAN-2004-0494 as well as the ten CAN issues from this report can be found at http://www.ottolander.nl/opensource/srpms/rh73/mc-4.5.55-9.legacy.src.rpm and http://www.ottolander.nl/opensource/rpms/rh73/mc-4.5.55-9.legacy.i386.rpm . a633d19f13591dc5c7f629ee0af49569 mc-4.5.55-9.legacy.src.rpm 38e67b66cf025ba7f2b2929e443b793d mc-4.5.55-9.legacy.i386.rpm * Fri Apr 08 2005 Leonard den Ottolander <leonard * den ottolander nl> 4.5.55-9.legacy - - Use CAN-2004-0226 patch from RHEL 2.1 as it is more complete than the Debian patch. - - Split original CAN-2004-0226 patch in 6 parts: CAN-2004-0226 (buffer overflows), CAN-2004-0231 (temp file fixes), CAN-2004-0232 (format string vulnerabilities), CAN-2004-0494 (vfs quoting fixes), ftpfs, and fish. - - Add one modified hunk from Debian to src/complete.c (CAN-2004-0226) - - Don't use CAN-2004-0494 parts from RHEL 2.1 CAN-2004-0226 patch as the current patch is more complete. - - Rename mc-4.5.55-extfs.patch to mc-4.5.55-CAN-2004-0494.patch. - - Removed some redundant hunks and fixed a few in CAN-2004-0494 patch. - - Add missing hunk for lib/cedit.menu to CAN-2004-0231 patch. - - One cpio.c hunk removed from CAN-2004-1005 patch (already in -0226) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFCVtzfm7FzjwvzBAsRAqOtAKDWttr3Hs679uEy2uwVaiVQs6/ipQCguLEm 647e4vjs/hIDhT+qAQeKxeE= =kqI6 -----END PGP SIGNATURE----- Created attachment 113092 [details] debian patch for CAN-2005-0763 Last Debian update includes patch for CAN-2005-0763. Attaching here. Michael, thanks for reminding me. I extracted that patch from the Debian patch set but forgot to apply it. New rpms coming up. I already opened a bug report for this issue at bug 153982. Ok, here are new testing rpms: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Packages fixing CAN-2004-0226, CAN-2004-0231, CAN-2004-0232, CAN-2004-0494, CAN-2004-1004, CAN-2004-1005, CAN-2004-1009, CAN-2004-1090, CAN-2004-1091, CAN-2004-1092, CAN-2004-1093, CAN-2004-1174, CAN-2004-1175, CAN-2004-1176 and CAN-2005-0763 can be found at http://www.ottolander.nl/opensource/srpms/rh73/mc-4.5.55-10.legacy.src.rpm and http://www.ottolander.nl/opensource/rpms/rh73/mc-4.5.55-10.legacy.i386.rpm . 14b9a07a84f7d2a1a9d376032fbe2f8f mc-4.5.55-10.legacy.src.rpm 20ccec65fe8ed40a782ba8f2bc3d1c40 mc-4.5.55-10.legacy.i386.rpm * Wed Apr 13 2005 Leonard den Ottolander <leonard * den ottolander nl> 4.5.55-10.legacy - - Add patch for CAN-2005-0763 * Fri Apr 08 2005 Leonard den Ottolander <leonard * den ottolander nl> 4.5.55-9.legacy - - Use CAN-2004-0226 patch from RHEL 2.1 as it is more complete than the Debian patch. - - Split original CAN-2004-0226 patch in 6 parts: CAN-2004-0226 (buffer overflows), CAN-2004-0231 (temp file fixes), CAN-2004-0232 (format string vulnerabilities), CAN-2004-0494 (vfs quoting fixes), ftpfs, and fish. - - Add one modified hunk from Debian to src/complete.c (CAN-2004-0226) - - Don't use CAN-2004-0494 parts from RHEL 2.1 CAN-2004-0226 patch as the current patch is more complete. - - Rename mc-4.5.55-extfs.patch to mc-4.5.55-CAN-2004-0494.patch. - - Removed some redundant hunks and fixed a few in CAN-2004-0494 patch. - - Add missing hunk for lib/cedit.menu to CAN-2004-0231 patch. - - One cpio.c hunk removed from CAN-2004-1005 patch (already in -0226) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFCXTkQm7FzjwvzBAsRAtm9AJ9jNn0cKhIGOoOsN/qMnCKlYNr3HwCg0Oc6 43rcl9X3DgymibNWH83k5nY= =Ea5f -----END PGP SIGNATURE----- Last testing package (mc-4.5.55-10.legacy) is broken. mc segfaults on file editing. Steps to reproduce: - istall rpm - start mc (tested on root login) - press F4 on any text file (for example /etc/hosts) = immediate crash OR = message "Error in file /root/.cedit/Syntax on line XXX" - dissmiss message to enter editor - press down key = crash Tested on RH73 clean install. Yes, I can immediately reproduce this. I'll have a look at the patches and see if I can fix it. GNU gdb Red Hat Linux (5.2-2) Copyright 2002 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "i386-redhat-linux"... (no debugging symbols found)... Core was generated by `/usr/bin/mc -P'. Program terminated with signal 11, Segmentation fault. Reading symbols from /usr/lib/libslang.so.1...(no debugging symbols found)... done. Loaded symbols for /usr/lib/libslang.so.1 Reading symbols from /usr/lib/libgpm.so.1...(no debugging symbols found)... done. Loaded symbols for /usr/lib/libgpm.so.1 Reading symbols from /usr/lib/libglib-1.2.so.0...done. Loaded symbols for /usr/lib/libglib-1.2.so.0 Reading symbols from /lib/libext2fs.so.2...done. Loaded symbols for /lib/libext2fs.so.2 Reading symbols from /lib/libcom_err.so.2...done. Loaded symbols for /lib/libcom_err.so.2 Reading symbols from /lib/libtermcap.so.2...done. Loaded symbols for /lib/libtermcap.so.2 Reading symbols from /lib/i686/libc.so.6...done. Loaded symbols for /lib/i686/libc.so.6 Reading symbols from /lib/libdl.so.2...done. Loaded symbols for /lib/libdl.so.2 Reading symbols from /lib/i686/libm.so.6...done. Loaded symbols for /lib/i686/libm.so.6 Reading symbols from /usr/lib/libncurses.so.5...done. Loaded symbols for /usr/lib/libncurses.so.5 Reading symbols from /lib/ld-linux.so.2...done. Loaded symbols for /lib/ld-linux.so.2 Reading symbols from /lib/libnss_files.so.2...done. Loaded symbols for /lib/libnss_files.so.2 Reading symbols from /lib/libnss_nisplus.so.2...done. Loaded symbols for /lib/libnss_nisplus.so.2 Reading symbols from /lib/libnsl.so.1...done. Loaded symbols for /lib/libnsl.so.1 #0 0x4207a7eb in chunk_alloc () from /lib/i686/libc.so.6 (gdb) bt #0 0x4207a7eb in chunk_alloc () from /lib/i686/libc.so.6 #1 0x4207a158 in malloc () from /lib/i686/libc.so.6 #2 0x0808a811 in getch () #3 0x0808aebe in getch () #4 0x0808b041 in getch () #5 0x080945c7 in getch () #6 0x0807bec1 in getch () #7 0x0807bf51 in getch () #8 0x0807db53 in getch () #9 0x0806bd41 in strcpy () #10 0x08065d67 in strcpy () #11 0x08065e6e in strcpy () #12 0x080661cd in strcpy () #13 0x08066297 in strcpy () #14 0x080808bf in getch () #15 0x08080a55 in getch () #16 0x0808159e in getch () #17 0x42017589 in __libc_start_main () from /lib/i686/libc.so.6 (gdb) quit Missed the removal of a strcat in gtkedit/syntax.c open_include_file(). Also replaced a strcpy() by a g_strconcat() in the same function. And got rid of some redundant -1s in strncpy()s in syntax.c. These are not in the Debian patch nor in CVS as they are redundant. Removing strcat() fixes the crash. New packages coming up. -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Packages fixing CAN-2004-0226, CAN-2004-0231, CAN-2004-0232, CAN-2004-0494, CAN-2004-1004, CAN-2004-1005, CAN-2004-1009, CAN-2004-1090, CAN-2004-1091, CAN-2004-1092, CAN-2004-1093, CAN-2004-1174, CAN-2004-1175, CAN-2004-1176 and CAN-2005-0763 can be found at http://www.ottolander.nl/opensource/srpms/rh73/mc-4.5.55-11.legacy.src.rpm and http://www.ottolander.nl/opensource/rpms/rh73/mc-4.5.55-11.legacy.i386.rpm . 4bd22e99dd6aa0d9bd089b12a0e288e4 mc-4.5.55-11.legacy.src.rpm 35d0187221dab6f6b090210fafdb8a10 mc-4.5.55-11.legacy.i386.rpm * Sat Apr 17 2005 Leonard den Ottolander <leonard * den ottolander nl> 4.5.55-11.legacy - - Missed the removal of a strcat in gtkedit/syntax.c open_include_file() in CAN-2004-0226 causing crash in mcedit. Cleaned up syntax.c a bit more in accordance with the Debian patch and CVS (redundant -1s in strncpy()s) * Wed Apr 13 2005 Leonard den Ottolander <leonard * den ottolander nl> 4.5.55-10.legacy - - Add patch for CAN-2005-0763 * Fri Apr 08 2005 Leonard den Ottolander <leonard * den ottolander nl> 4.5.55-9.legacy - - Use CAN-2004-0226 patch from RHEL 2.1 as it is more complete than the Debian patch. - - Split original CAN-2004-0226 patch in 6 parts: CAN-2004-0226 (buffer overflows), CAN-2004-0231 (temp file fixes), CAN-2004-0232 (format string vulnerabilities), CAN-2004-0494 (vfs quoting fixes), ftpfs, and fish. - - Add one modified hunk from Debian to src/complete.c (CAN-2004-0226) - - Don't use CAN-2004-0494 parts from RHEL 2.1 CAN-2004-0226 patch as the current patch is more complete. - - Rename mc-4.5.55-extfs.patch to mc-4.5.55-CAN-2004-0494.patch. - - Removed some redundant hunks and fixed a few in CAN-2004-0494 patch. - - Add missing hunk for lib/cedit.menu to CAN-2004-0231 patch. - - One cpio.c hunk removed from CAN-2004-1005 patch (already in -0226) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFCYQX8m7FzjwvzBAsRAiymAJ4j8TzD0pkATnRzmbEwFnuAmrmeswCffH/V ryvCY4BNkpwsM8So1OX95gM= =uhGE -----END PGP SIGNATURE----- -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Candidate package for rh9 and fc1. 331bcec08ee0a3bf47b6b5651ce2a27816f8ec30 redhat/9/updates-testing/SRPMS/mc-4.6. 0-18.2.fc0.9.legacy.src.rpm 1ff0fb79aab253a3c7fe4a6324dc2402c6b8f437 redhat/9/updates-testing/i386/mc-4.6.0 -18.2.fc0.9.legacy.i386.rpm 529796f562e9e49739170ad86bc427a45a5d2f05 fedora/1/updates-testing/SRPMS/mc-4.6. 0-18.2.fc1.0.legacy.src.rpm f5959c3196abe94223f9d43b4b78f78c88c98554 fedora/1/updates-testing/i386/mc-4.6.0 -18.2.fc1.0.legacy.i386.rpm -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCcVB6YzuFKFF44qURArMjAKD00/ncHDwQtrVgu69QC3ypQfDxXwCffZe/ FC8Kn0o4dLv/SvQOJxsFwHU= =F+WQ -----END PGP SIGNATURE----- *** Bug 153982 has been marked as a duplicate of this bug. *** CAN-2005-0763 only affects RHL 7.3. *** Bug 152705 has been marked as a duplicate of this bug. *** *** Bug 152770 has been marked as a duplicate of this bug. *** -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 ++PUBLISH RHL 7,3 Kudos to Leonard for working though all these mc issues and providing all the fixes for 7.3. Thanks! a8a885c4d1b456c11ac5ee76befe7b97d5f957d8 mc-4.5.55-11.legacy.i386.rpm Works as expected. - -Jim P. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFC0ak+MyG7U7lo69MRAm3aAJ9F3hD0teBqZ0OatkEUmNnJe8RSwACgm1VU TDHrw1PE75cDpzPSATNU/3c= =jDnZ -----END PGP SIGNATURE----- 7.3 packages were pushed to updates-testing. *** Bug 148865 has been marked as a duplicate of this bug. *** This bug tracks the fc2 packages also. Created attachment 117257 [details] Difference between my .i386.rpm and updates-testing The attachment is the diff -u of my .i386.rpm and FL's in updates-testing. -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I downloaded the binary FC1 package, SHA1SUM PACKAGE f5959c3196abe94223f9d43b4b78f78c88c98554 fedora/1/updates-testing/i386/mc-4.6.0-18.2.fc1.0.legacy.i386.rpm, from http://download.fedoralegacy.org/, as was posted in the FL Update Test Update Notification FEDORALEGACY-2005-152889, at <http://www.redhat.com/archives/fedora-legacy-list/2005-July/msg00039.html>. I haven't yet loaded it into my machine to test, but doing a comparison of this binary package with the binary package I produced (when I created the .src.rpm) yields some problems. It is my guess that all of the problems are due to missing dependencies when the binary package is created in the build environment. Summary: To build correctly (for at least FC1), mc may need: 1) the groff package (but not a show-stopper), and 2) the gnome-libs package. Details (with many thanks to Charles Anderson for his rpm-build-compare.sh script): 1) /usr/share/mc/mc.ext, lines 151-152 & others. In the rpm in updates-testing, the "Open" line in mc.ext for manpages calls nroff with merely a "-man" argument, rather than the arguments "-c -Tlatin1 -mandoc". I think this is due to files missing when the groff package is not present on the build system. There are also other "roff" "groff" "nroff" extensions in mc.ext that appear to have incor- rect arguments (see attachment). For example, - ------------------------------------------------------------------------------ - --- mc-4.6.0-18.2.fc1.0.legacy.dde.i386.rpm-root/usr/share/mc/mc.ext 2005-07-14 03:59:23.000000000 -0500 +++ mc-4.6.0-18.2.fc1.0.legacy.i386.rpm-root/usr/share/mc/mc.ext 2005-07-14 03:59:24.000000000 -0500 @@ -149,8 +149,8 @@ View=%view{ascii} file %f && nm %f regex/(([^0-9]|^[^\.]*)\.([1-9][a-z]?|n)|\.man)$ - - Open=nroff -c -Tlatin1 -mandoc %f | %var{PAGER:more} - - View=%view{ascii,nroff} nroff -c -Tlatin1 -mandoc %f + Open=nroff -man %f | %var{PAGER:more} + View=%view{ascii,nroff} nroff -man %f # Troff with me macros. # Exception - "read.me" is not a nroff file. - ------------------------------------------------------------------------------ 2) Line 304 of /usr/share/mc/mc.ext (for the .htm and .html file extensions), is buggy and will not properly open a browser window when running X-Windows (or GNOME or KDE). It is missing the "gnome-moz-remote" command, which is supplied in the gnome-libs package. - ------------------------------------------------------------------------------ @@ -300,7 +300,7 @@ # html regex/\.([Hh]tml?|HTML?)$ - - Open=if test -n "gnome-moz-remote" && test -n "$DISPLAY"; then (gnome-moz-remote file://%d/%p &) >/dev/null 2>&1; else links %f 2>/dev/null || lynx -force_html %f; fi + Open=if test -n "" && test -n "$DISPLAY"; then ( file://%d/%p &) >/dev/null 2>&1; else links %f 2>/dev/null || lynx -force_html %f; fi View=%view{ascii} lynx -dump -force_html %f # StarOffice 5.2 - ------------------------------------------------------------------------------ -David -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFC6XLsxou1V/j9XZwRAkw6AJ0R052Z34FCn2nRwNQIk69ApURNSgCgw9Uk xQ9Rv30pwXiPnG6jdx07918= =QIzt -----END PGP SIGNATURE----- Thanks for the report David. Updated packages are being pushed to updates-testing right now. Created attachment 117261 [details] PGP-signed portion of comment 25 Enclosed attachment duplicates the PGP-signed portion of comment 25, since pasting that into the comment box broke the message & signature. I'll try to be more careful next time. I wish bugzilla had a "preview" button in addition to a "submit" button. -David +VERIFY for FC1. Any other verifies, please? (I'll count Gilbert's as one, though unsigned, but won't start a timeout yet..) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 +VERIFY for 7.3 Works like a champ. 7dd653902f620c9ab66fc187c92e1e8c70af4b6f mc-4.5.55-12.legacy.i386.rpm - -Jim P. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFC8p/3MyG7U7lo69MRAo4ZAKCA0vsFPaS6U4+dnSRy1ZHgpgzacwCfeMFX I1/AQXxrisHl9eVvKpKVWaY= =V2AL -----END PGP SIGNATURE----- Thanks! -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Verify for RH9 and FC2 packages: 82c7263b65d3959003c6043131dad7248fa7c40e mc-4.6.0-18.3.fc0.9.legacy.i386.rpm a8270921b5ded8b829c7fda54d7bac77145df129 mc-4.6.1-0.13.FC2.1.legacy.i386.rpm Signature OK Installs OK mc binary runs OK RH9 VERIFY++ FC2 VERIFY++ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (Darwin) iD8DBQFC9E1DKe7MLJjUbNMRAvSHAKCcgv5pIVqzgaJ89F5FBvpM9edMwACgpq32 L7UCEf4e8UQIcik0vrhnV3U= =F5/w -----END PGP SIGNATURE----- Packages were finally released! Hurrah! :) *** Bug 127973 has been marked as a duplicate of this bug. *** |