Bug 1528984 - [RFE][UI] Username related message doesn't look good when adding infra provider
Summary: [RFE][UI] Username related message doesn't look good when adding infra provider
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Martin Hradil
QA Contact: Parthvi Vala
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-25 14:19 UTC by Mor
Modified: 2019-12-12 13:33 UTC (History)
10 users (show)

Fixed In Version: 5.11.0.18
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:33:21 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot of the window (38.22 KB, image/png)
2017-12-25 14:19 UTC, Mor
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:33:36 UTC

Description Mor 2017-12-25 14:19:07 UTC
Created attachment 1372159 [details]
screenshot of the window

Description of problem:
When adding new infrastructure provider, there's a message at the bottom of the window: "Required. Should have privileged access, such as root or administrator.". This message should be colored in red, and needs to reposition near the username field.

Version-Release number of selected component (if applicable):
5.9.0.12.20171205180333_3e32b3d 

How reproducible:
100%

Steps to Reproduce:
1. Compute-->Infrastructure-->Providers-->Configuration-->Add new infrastructure provider.
2. Select provider type: "Red Hat Virtualization"

Actual results:
Message position and color is not as expected.

Expected results:
See description.

Additional info:
See attached screenshot.

Comment 10 CFME Bot 2019-08-05 10:51:33 UTC
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/90a8e7aa6b6698dc36b1bfdc16ad92e905aa7db5
commit 90a8e7aa6b6698dc36b1bfdc16ad92e905aa7db5
Author:     Martin Hradil <mhradil>
AuthorDate: Mon Jan 28 11:03:28 2019 -0500
Commit:     Martin Hradil <mhradil>
CommitDate: Mon Jan 28 11:03:28 2019 -0500

    Move "Should have privileged access" message under the userid field

    and removed the "Required" bit, since the field already has a separate required error message when required and missing.

    The previous logic was written wrong, the condition was interpreted in ruby, not javascript, except for the last string.
    Thus this only checked emstype != azure_stack, as opposed to the whole condition listed.

    Fixed and moved into a function.

    (The limit to default tab comes from these messages being explicitly part of the default tab html.)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1528984

 app/assets/javascripts/controllers/ems_common/ems_common_form_controller.js | 20 +
 app/views/layouts/angular-bootstrap/_auth_credentials_angular_bootstrap.html.haml | 2 +
 app/views/layouts/angular/_multi_auth_credentials.html.haml | 3 -
 3 files changed, 22 insertions(+), 3 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/8d06e8bc8a5e453a3e8a5d71262be80c70233e0b
commit 8d06e8bc8a5e453a3e8a5d71262be80c70233e0b
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Jul 25 08:34:39 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Jul 25 08:34:39 2019 -0400

    AuthCredentials - move user should have privieged access message under the user field

    as opposed to outside the template

    https://bugzilla.redhat.com/show_bug.cgi?id=1528984

 app/assets/javascripts/components/auth-credentials.js | 1 +
 app/views/configuration_manager/_shared_form.html.haml | 2 +-
 app/views/static/auth-credentials.html.haml | 2 +
 3 files changed, 4 insertions(+), 1 deletion(-)

Comment 11 CFME Bot 2019-08-05 15:36:42 UTC
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/492d0a81e6a98b4db0d9486b2ef171ee6c405698
commit 492d0a81e6a98b4db0d9486b2ef171ee6c405698
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Mon Aug  5 06:50:31 2019 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Mon Aug  5 06:50:31 2019 -0400

    Merge pull request #5207 from himdel/multi-auth

    Provider edit - move message about a username near the field, fix everything

    (cherry picked from commit 5a944f82158cd9a028a0187bca2d1e9265fdb213)

    https://bugzilla.redhat.com/show_bug.cgi?id=1528984

 app/assets/javascripts/components/auth-credentials.js | 1 +
 app/assets/javascripts/controllers/ems_common/ems_common_form_controller.js | 20 +
 app/views/configuration_manager/_shared_form.html.haml | 2 +-
 app/views/layouts/angular-bootstrap/_auth_credentials_angular_bootstrap.html.haml | 2 +
 app/views/layouts/angular/_multi_auth_credentials.html.haml | 3 -
 app/views/static/auth-credentials.html.haml | 2 +
 6 files changed, 26 insertions(+), 4 deletions(-)

Comment 12 Parthvi Vala 2019-08-07 13:53:17 UTC
FIXED. Verified on 5.11.0.18.20190806180636_1dd6378.

Comment 14 errata-xmlrpc 2019-12-12 13:33:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.