Bug 1528999 - [RFE] Improve host's upgrade_check() function - so it'll return a boolean if an upgrade is available
Summary: [RFE] Improve host's upgrade_check() function - so it'll return a boolean if ...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Ondra Machacek
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-25 19:04 UTC by Yaniv Kaul
Modified: 2020-04-01 14:50 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-04-01 14:46:02 UTC
oVirt Team: Infra
Embargoed:
oourfali: ovirt-future?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)

Description Yaniv Kaul 2017-12-25 19:04:25 UTC
Description of problem:
Currently, it's just ignites the process to check for upgrade, which is somewhat useless (I assume one can check the event of the result, etc. - messy).

Just make is synchronous and return a True/False if upgrade is available.

Comment 1 Yaniv Kaul 2017-12-25 19:05:25 UTC
Example:
host_service = connection.system_service().hosts_service().host_service(host.id)
is_upgrade = host_service.upgrade_check()

To my surprise, is_upgrade is None. I expected a Boolean.

Comment 2 Martin Perina 2017-12-26 11:40:26 UTC
This is quite problematic, because the whole "check-for-upgrade" flow needs to be asynchronous:

1. By default it's executed periodically by engine itself and because it may take really long time to fetch repositories updates on the host

2. If we make it synchronous, the also UI would be blocked when check for upgrade is executed form webadmin

So the only option is probably to execute check-for-upgrade flow asynchronously and then periodically check host status (or job status) until the check-for-upgrade flow finished.

Comment 3 Michal Skrivanek 2020-03-19 15:42:03 UTC
We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it.
If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly.

Comment 4 Michal Skrivanek 2020-04-01 14:46:02 UTC
ok, closing. Please reopen if still relevant/you want to work on it.

Comment 5 Michal Skrivanek 2020-04-01 14:50:10 UTC
ok, closing. Please reopen if still relevant/you want to work on it.


Note You need to log in before you can comment on or make changes to this bug.