Bug 1529024 - Review Request: python-tld - Extract the top level domain from the URL given
Summary: Review Request: python-tld - Extract the top level domain from the URL given
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Björn Esser (besser82)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1827622 (view as bug list)
Depends On:
Blocks: 1827587
TreeView+ depends on / blocked
 
Reported: 2017-12-26 01:06 UTC by William Moreno
Modified: 2020-04-29 19:09 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-23 21:43:22 UTC
Type: ---
Embargoed:
besser82: fedora-review+


Attachments (Terms of Use)

Description William Moreno 2017-12-26 01:06:50 UTC
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-tld.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-tld-0.7.9-1.fc28.src.rpm
Description: Extract the top level domain from the URL given
Fedora Account System Username: williamjmorenor

Comment 1 Björn Esser (besser82) 2017-12-29 17:43:12 UTC
Package looks good to me, but `%{python3_sitelib}/*`…  You shoudn't greedy-glob there, since you might own the `__pycache__` directory, which is owned by python3 itself.

Please fix `Requires: python3-six` ---> `Requires: python2-six` for the python2-pkg during import!

Package APPROVED!

Comment 2 Gwyn Ciesla 2018-01-04 13:59:53 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-tld. You may commit to the branch "f27" in about 10 minutes.

Comment 3 Fedora Update System 2018-01-06 03:52:55 UTC
python-tld-0.7.9-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-92a62ff939

Comment 4 Fedora Update System 2018-01-06 21:10:04 UTC
python-tld-0.7.9-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-92a62ff939

Comment 5 Fedora Update System 2018-01-23 21:43:22 UTC
python-tld-0.7.9-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Artur Frenszek-Iwicki 2020-04-29 19:09:22 UTC
*** Bug 1827622 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.