Description of problem: node-zero is currently a set of ansible playbooks packaged inside ovirt-hosted-engine-setup. We should probably refactor it later on to be more modular and standards-, or at least best-practices-, compliant. This should probably include: * Move the code to roles and use them * Make the structure compliant with ansible-galaxy * Make it compliant with linux-system-roles: https://linux-system-roles.github.io/
Can you please detail what we gain from this?
(In reply to Sandro Bonazzola from comment #1) > Can you please detail what we gain from this? I do not think I had anything particular in mind when opening this bug - just the normal things you gain from following best practices. Writing everything in long playbooks, and using 'include_tasks' for code reuse, seems like using CPP (C Pre-Processor) for all your code reuse, not breaking it to functions/files (and modules/packages/etc for more modern languages). You can do that, but most people eventually prefer to use more modern means. Ansible is still young, but it seems to me like the equivalent there is to break your code to roles - that seems the norm. Ansible Galaxy works in terms of roles - you can't share and reuse there snippets using include_tasks. linux-system-roles does the same.
(BTW, note that current summary line wasn't written by me - I wrote "refactor node-zero").
Being developed on github: https://github.com/oVirt/ovirt-ansible-hosted-engine-setup
Not sure I'm getting the point of what to be tested here. Please provide me with reproduction steps and proper documentation.
Developed on https://github.com/oVirt/ovirt-ansible-hosted-engine-setup and shipped in a new ovirt-ansible-hosted-engine-setup rpm.
Moving to post since we still miss to switch the setup code from playbook to role
During NFS deployment I met these: [ INFO ] skipping: [localhost] [ ERROR ] [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using [ ERROR ] `result|success` use `result is success`. This feature will be removed in [ ERROR ] version 2.9. Deprecation warnings can be disabled by setting [ ERROR ] deprecation_warnings=False in ansible.cfg. Please specify the storage you would like to use (glusterfs, iscsi, fc, nfs)[nfs]: Deployment over NFS was successful.
Successfully deployed over FC with the same issue as described in comment #8. ovirt-hosted-engine-setup-2.3.2-1.el7ev.noarch ovirt-hosted-engine-ha-2.3.0-1.el7ev.noarch rhvm-appliance-4.3-20190115.0.el7.x86_64 Linux 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 15 17:36:42 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux Server release 7.6 (Maipo)
Successfully deployed over iSCSI with the same issue as described in comment #8. ovirt-hosted-engine-setup-2.3.2-1.el7ev.noarch ovirt-hosted-engine-ha-2.3.0-1.el7ev.noarch rhvm-appliance-4.3-20190115.0.el7.x86_64 Linux 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 15 17:36:42 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux Server release 7.6 (Maipo)
Successfully deployed over Gluster with the same issue as described in comment #8. ovirt-hosted-engine-setup-2.3.2-1.el7ev.noarch ovirt-hosted-engine-ha-2.3.0-1.el7ev.noarch rhvm-appliance-4.3-20190115.0.el7.x86_64 Linux 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 15 17:36:42 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Red Hat Enterprise Linux Server release 7.6 (Maipo)
(In reply to Nikolai Sednev from comment #8) > During NFS deployment I met these: > > [ INFO ] skipping: [localhost] > [ ERROR ] [DEPRECATION WARNING]: Using tests as filters is deprecated. > Instead of using It has been fixed with https://github.com/oVirt/ovirt-ansible-hosted-engine-setup/pull/69 It will be shipped with ovirt-ansible-hosted-engine-setup-1.0.7
Latest availabe to QA for DS at the moment: ovirt-ansible-hosted-engine-setup-1.0.5-1.el7ev.noarch
Deployment over bonded interface failed. https://bugzilla.redhat.com/show_bug.cgi?id=1670152
(In reply to Nikolai Sednev from comment #14) > Deployment over bonded interface failed. > https://bugzilla.redhat.com/show_bug.cgi?id=1670152 Failure was as a result of outdated old CPU family on hosts and unrelated to bond or VLAN. During bond and bonded VLAN I noticed that bridge was properly created: orchid-vds2-vlan162 ~]# brctl show bridge name bridge id STP enabled interfaces ;vdsmdummy; 8000.000000000000 no ovirtmgmt 8000.001a647a9462 no bond1.162 virbr0 8000.525400adb219 yes virbr0-nic vnet0 All storage type deployments were successful, forth to described above, moving to verified as conditionally pass. If there will be new issues, I'll reopen.
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.