Bug 1529292 - uploaded image alignment should be validated
Summary: uploaded image alignment should be validated
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.2.1
: ---
Assignee: Daniel Erez
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-27 13:12 UTC by Daniel Erez
Modified: 2018-02-12 11:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
On 'Upload Image' dialog, the sector alignment of the selected file should be validated. I.e. the selected file must be aligned to 512 bytes (size in bytes is a multiple of 512); otherwise, the file is not recognized as a valid image for upload. Note that this restriction is due to the sector size defined in vdsm (i.e. 512 bytes).
Clone Of:
Environment:
Last Closed: 2018-02-12 11:47:03 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 85775 0 master MERGED webadmin: validate image alignment on upload 2017-12-27 16:25:04 UTC

Description Daniel Erez 2017-12-27 13:12:31 UTC
Description of problem:
Upon uploading an image, its sector size alignment should be validated.
I.e. validate that the image's size is a multiple of 512 bytes.


Steps to Reproduce:
1. Navigate to upload image dialog.
2. Select an image of size non divisible by 512.
3. Press OK.

Actual results:
No validation error.

Expected results:
A validation error, stating that the selected file is not a valid image, should be displayed.

Comment 1 Jiri Belka 2018-01-26 17:29:15 UTC
ok, ovirt-engine-webadmin-portal-4.2.1.3-0.1.el7.noarch
ovirt-imageio-proxy-1.2.1-0.el7ev.noarch


i tried to upload a raw image which which size was not multiplied by 512 - got error about bad image format in Upload dialog. upload of a raw image multiplied by 512 was initialized but there's no more progres on the action itself.

but i was not able to initialize upload of a qcow2 at all - https://bugzilla.redhat.com/show_bug.cgi?id=1539104

Comment 2 Sandro Bonazzola 2018-02-12 11:47:03 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.