Bug 1529644 - Review Request: python-sphinx-autodoc-typehints - Type hints support for the Sphinx autodoc extension
Summary: Review Request: python-sphinx-autodoc-typehints - Type hints support for the ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Björn 'besser82' Esser
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-29 05:00 UTC by Tristan Cacqueray
Modified: 2018-01-03 01:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-03 01:54:38 UTC
Type: Bug
Embargoed:
besser82: fedora-review+


Attachments (Terms of Use)

Description Tristan Cacqueray 2017-12-29 05:00:27 UTC
Spec URL: https://fedorapeople.org/~tdecacqu/pkgs/python-sphinx-autodoc-typehints.spec
SRPM URL: https://fedorapeople.org/~tdecacqu/pkgs/python-sphinx-autodoc-typehints-1.2.3-1.fc27.src.rpm

Description:
This extension allows you to use Python 3 annotations for documenting
acceptable argument types and return value types of functions.

Fedora Account System Username: tdecacqu

Comment 1 Björn 'besser82' Esser 2017-12-29 17:56:45 UTC
Package looks good to me.  No issues spotted.

A small hint for some optimization:

  Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

Package APPROVED!

Comment 2 Björn 'besser82' Esser 2017-12-29 17:56:56 UTC
Maybe you could have a look at one of my packages waiting for review in exchange?

https://bugzilla.redhat.com/show_bug.cgi?id=1529352
https://bugzilla.redhat.com/show_bug.cgi?id=1529593
https://bugzilla.redhat.com/show_bug.cgi?id=1529705

Comment 3 Gwyn Ciesla 2018-01-02 15:18:51 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-autodoc-typehints. You may commit to the branch "f27" in about 10 minutes.

Comment 4 Tristan Cacqueray 2018-01-03 01:54:38 UTC
Thanks Björn and Gwyn!


Note You need to log in before you can comment on or make changes to this bug.