Spec URL: https://jjames.fedorapeople.org/yices/yices.spec SRPM URL: https://jjames.fedorapeople.org/yices/yices-2.5.4-1.fc28.src.rpm Description: Yices 2 is an efficient SMT solver that decides the satisfiability of formulas containing uninterpreted function symbols with equality, linear real and integer arithmetic, bitvectors, scalar types, and tuples. Yices 2 can process input written in the SMT-LIB notation (both versions 2.0 and 1.2 are supported). Alternatively, you can write specifications using the Yices 2 specification language, which includes tuples and scalar types. Yices 2 can also be used as a library in other software. Fedora Account System Username: jjames
- Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20172800 bytes in 347 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - Fix the line encodings for these files: yices-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yices-tools/examples/jinpeng.ys yices-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yices-tools/examples/problem_with_input.ys Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20172800 bytes in 347 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (unspecified)", "LGPL (v3 or later)", "BSD (3 clause)", "GPL (v3)". 2598 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/yices/review- yices/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 20305920 bytes in /usr/share yices- tools-2.5.4-1.fc28.x86_64.rpm:20224000 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: yices-2.5.4-1.fc28.x86_64.rpm yices-devel-2.5.4-1.fc28.x86_64.rpm yices-tools-2.5.4-1.fc28.x86_64.rpm yices-debuginfo-2.5.4-1.fc28.x86_64.rpm yices-debugsource-2.5.4-1.fc28.x86_64.rpm yices-2.5.4-1.fc28.src.rpm yices.x86_64: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability yices.x86_64: W: spelling-error %description -l en_US bitvectors -> bit vectors, bit-vectors, bisectors yices.x86_64: W: spelling-error %description -l en_US tuples -> letups yices.x86_64: W: shared-lib-calls-exit /usr/lib64/libyices.so.2.5.4 exit.5 yices-devel.x86_64: W: only-non-binary-in-usr-lib yices-devel.x86_64: W: no-documentation yices-tools.x86_64: W: only-non-binary-in-usr-lib yices-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yices-tools/examples/jinpeng.ys yices-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yices-tools/examples/problem_with_input.ys yices-debugsource.x86_64: W: no-documentation yices.src: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability yices.src: W: spelling-error %description -l en_US bitvectors -> bit vectors, bit-vectors, bisectors yices.src: W: spelling-error %description -l en_US tuples -> letups 6 packages and 0 specfiles checked; 0 errors, 13 warnings.
Thank you for the review. I have added a -doc subpackage, fixed the end of line encodings, and fixed permissions on a generated file. New URLs: Spec URL: https://jjames.fedorapeople.org/yices/yices.spec SRPM URL: https://jjames.fedorapeople.org/yices/yices-2.5.4-2.fc28.src.rpm
Ok, package approved.
Thank you again for the review.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/yices. You may commit to the branch "f27" in about 10 minutes.
yices-2.5.4-2.fc27 libpoly-0.1.4-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-97bef6cb30
libpoly-0.1.4-1.fc27, yices-2.5.4-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-97bef6cb30
libpoly-0.1.4-1.fc27, yices-2.5.4-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.