Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23974674

Updated sources and scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23974819
fix arch's that don't have qt5-qtwebengine available

 - gtk-update-icon-cache is invoked in %postun and %posttrans if package
   contains icons.
  Note: icons in calligraplan
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache


 - Are the *so dl-opened or did you forget to split them in a devel subpackage and call ldconfig?

- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in calligraplan-libs
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries



 - update-desktop-database and update-mime-database should not be used in F25 and later: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-database

 - Package should Requires: hicolor-icon-theme

 - The Requires should be %{name}%{_isa} = %{version}-%{release}

%package  libs
Summary:  Runtime libraries for %{name}
Obsoletes: calligra-plan-libs < 3.0.90
Requires: %{name} = %{version}-%{release}

 - Remove this test locale from install:

calligraplan.x86_64: E: incorrect-locale-subdir /usr/share/locale/x-test/LC_MESSAGES/calligraplan.mo
calligraplan.x86_64: E: invalid-lc-messages-dir /usr/share/locale/x-test/LC_MESSAGES/calligraplan.mo
calligraplan.x86_64: E: invalid-lc-messages-dir /usr/share/locale/x-test/LC_MESSAGES/calligraplan_scheduler_rcps.mo
calligraplan.x86_64: E: invalid-lc-messages-dir /usr/share/locale/x-test/LC_MESSAGES/calligraplan_scheduler_tj.mo
calligraplan.x86_64: E: invalid-lc-messages-dir /usr/share/locale/x-test/LC_MESSAGES/calligraplanlibs.mo
calligraplan.x86_64: E: invalid-lc-messages-dir /usr/share/locale/x-test/LC_MESSAGES/calligraplanwork.mo
calligraplan.x86_64: E: invalid-lc-messages-dir /usr/share/locale/x-test/LC_MESSAGES/krossmoduleplan.mo

 - Missing a Provides?

calligraplan-libs.x86_64: W: obsolete-not-provided calligra-plan-libs

 - Some dirs are left with no owner:

[!]  Note: Directories without known owners: /usr/share/locale/x-test,
     /usr/share/config.kcfg, /usr/share/icons/hicolor/1024x1024,
     /usr/share/locale/x-test/LC_MESSAGES, /usr/share/icons/hicolor,
     /usr/share/kxmlgui5

* added /usr/share/kxmlgui5 ownership in kf5-kxmlgui packaging

* kf5-kiconthemes already Requires: hicolor-icon-theme

* hicolor-icon-theme already includes scriptlet triggers (though apparently packaging guidelines aren't updated to reflect that yet):
https://src.fedoraproject.org/rpms/hicolor-icon-theme/blob/master/f/hicolor-icon-theme.spec#_32

* -libs pkg dep on main package should not use %%{_?isa}, that's the whole point of making a -libs subpkg so that the other content is not multilib'd.

items I'll address:
* remove *.so symlinks (ie, lack of -devel subpkg), they're not used anywhere else

* remove x-test locale

* can add Provides: calligra-plan-libs too I suppose, though nothing else should use it.

* Scriptlets: drop desktop/mime, add ldconfig

Spec URL: https://rdieter.fedorapeople.org/rpms/calligra/calligraplan.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/calligra/calligraplan-3.0.91-1.fc27.src.rpm

%changelog
* Tue Jan 02 2018 Rex Dieter <rdieter> - 3.0.91-2
- drop x-test locale
- -libs: +ldconfig scriptlet, delete lib.so symlinks, Provides: calligra-plan-libs

 - /usr/share/config.kcfg still has no owner

 - /usr/share/icons/hicolor (%{_kf5_datadir}/icons/*/*/*) should not be owned by this package since it is owned by hicolor-icon-theme

 - /sbin/ldconfig should probably be called in calligraplan-libs too

%post -n libs -p /sbin/ldconfig
%postun -n libs -p /sbin/ldconfig


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in calligraplan-libs
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2 or later)",
     "Unknown or generated", "LGPL", "LGPL (v2.1)", "BSD (3 clause)", "LGPL
     (v2.1 or later)", "GPL (v2)". 641 files have unknown license. Detailed
     output of licensecheck in /home/bob/packaging/review/calligraplan
     /review-calligraplan/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[-]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/icons/hicolor/1024x1024
[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/1024x1024, /usr/share/icons/hicolor,
     /usr/share/kxmlgui5, /usr/share/config.kcfg
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/icons/hicolor/16x16/mimetypes(hicolor-icon-theme),
     /usr/share/icons/hicolor/22x22/apps(hicolor-icon-theme, fedora-logos),
     /usr/share/calligraplanwork/icons/hicolor/48x48(calligra-plan),
     /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme, fedora-logos),
     /usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme, fedora-logos),
     /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme),
     /usr/share/icons/hicolor/128x128/mimetypes(hicolor-icon-theme),
     /usr/share/calligraplanwork/templates/Simple/.source(calligra-plan),
     /usr/share/calligraplan/icons/hicolor/48x48/actions(calligra-plan),
     /usr/share/calligraplanwork/icons/hicolor/32x32/actions(calligra-
     plan), /usr/share/calligraplan/templates/Simple(calligra-plan),
     /usr/share/icons/hicolor/48x48/mimetypes(hicolor-icon-theme),
     /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-
     logos), /usr/share/calligraplanwork/icons/hicolor/16x16/actions
     (calligra-plan), /usr/share/icons/hicolor/64x64/mimetypes(hicolor-
     icon-theme), /usr/share/icons/hicolor/scalable/mimetypes(hicolor-icon-
     theme), /usr/share/calligraplan/about(calligra-plan),
     /usr/lib64/qt5/plugins/calligraplan(calligra-plan-libs),
     /usr/share/calligraplan/icons/hicolor(calligra-plan),
     /usr/share/calligraplan/icons(calligra-plan),
     /usr/share/calligraplanwork/icons/hicolor/22x22/actions(calligra-
     plan), /usr/share/kxmlgui5/calligraplan(calligra-plan),
     /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos),
     /usr/share/calligraplan/icons/hicolor/scalable/actions(calligra-plan),
     /usr/share/calligraplan(calligra-plan),
     /usr/share/calligraplanwork/icons/hicolor/22x22(calligra-plan),
     /usr/share/calligraplanwork/templates(calligra-plan),
     /usr/share/calligraplanwork/icons/hicolor/32x32(calligra-plan),
     /usr/share/calligraplan/templates(calligra-plan),
     /usr/share/calligraplanwork(calligra-plan),
     /usr/share/icons/hicolor/512x512/apps(hicolor-icon-theme),
     /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora-
     logos), /usr/share/calligraplanwork/icons/hicolor/64x64(calligra-
     plan), /usr/share/calligraplanwork/icons/hicolor(calligra-plan),
     /usr/share/icons/hicolor/22x22/mimetypes(hicolor-icon-theme),
     /usr/share/calligraplanwork/icons/hicolor/16x16(calligra-plan),
     /usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme),
     /usr/share/kxmlgui5/calligraplanwork(calligra-plan),
     /usr/lib64/qt5/plugins/calligraplan/schedulers(calligra-plan-libs),
     /usr/share/calligraplanwork/icons/hicolor/128x128(calligra-plan),
     /usr/share/calligraplanwork/icons/hicolor/48x48/actions(calligra-
     plan), /usr/share/calligraplan/icons/hicolor/48x48(calligra-plan),
     /usr/share/calligraplan/icons/hicolor/22x22/actions(calligra-plan),
     /usr/share/calligraplan/icons/hicolor/22x22(calligra-plan),
     /usr/share/calligraplan/icons/hicolor/scalable(calligra-plan),
     /usr/share/calligraplanwork/icons(calligra-plan),
     /usr/share/icons/hicolor/32x32/mimetypes(hicolor-icon-theme),
     /usr/share/calligraplanwork/icons/hicolor/128x128/actions(calligra-
     plan), /usr/share/calligraplanwork/templates/Simple(calligra-plan),
     /usr/share/calligraplan/templates/Simple/.source(calligra-plan),
     /usr/share/calligraplanwork/icons/hicolor/64x64/actions(calligra-plan)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     calligraplan-libs
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 6328320 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: calligraplan-3.0.91-2.fc28.x86_64.rpm
          calligraplan-libs-3.0.91-2.fc28.x86_64.rpm
          calligraplan-debuginfo-3.0.91-2.fc28.x86_64.rpm
          calligraplan-debugsource-3.0.91-2.fc28.x86_64.rpm
          calligraplan-3.0.91-2.fc28.src.rpm
calligraplan.x86_64: W: obsolete-not-provided koffice-kplato
calligraplan.x86_64: W: obsolete-not-provided koffice-kplato-libs
calligraplan.x86_64: E: invalid-soname /usr/lib64/libkdeinit5_calligraplan.so libkdeinit5_calligraplan.so
calligraplan.x86_64: E: invalid-soname /usr/lib64/libkdeinit5_calligraplanwork.so libkdeinit5_calligraplanwork.so
calligraplan.x86_64: W: no-documentation
calligraplan.x86_64: W: non-conffile-in-etc /etc/xdg/calligraplanrc
calligraplan.x86_64: W: non-conffile-in-etc /etc/xdg/calligraplanworkrc
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplan/templates/.source
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplan/templates/.source
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplan/templates/Simple/.directory
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplan/templates/Simple/.source
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplan/templates/Simple/.source
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplanwork/templates/Simple/.directory
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplanwork/templates/Simple/.source
calligraplan.x86_64: W: hidden-file-or-dir /usr/share/calligraplanwork/templates/Simple/.source
calligraplan.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/calligraplan.svgz
calligraplan.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/calligraplanwork.svgz
calligraplan.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/mimetypes/application-x-vnd.kde.kplato.svgz
calligraplan.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/mimetypes/application-x-vnd.kde.kplato.work.svgz
calligraplan.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/mimetypes/application-x-vnd.kde.plan.svgz
calligraplan.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/mimetypes/application-x-vnd.kde.plan.work.svgz
calligraplan.x86_64: W: no-manual-page-for-binary calligraplan
calligraplan.x86_64: W: no-manual-page-for-binary calligraplanwork
calligraplan-libs.x86_64: W: no-documentation
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libkplatokernel.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libkplatokernel.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libkplatomodels.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libkplatomodels.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libkplatoui.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libkplatoui.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplankundo2.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplankundo2.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanmain.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanmain.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanodf.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanodf.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanplugin.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanplugin.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanprivate.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanprivate.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanstore.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanstore.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanwidgets.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanwidgets.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanwidgetutils.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanwidgetutils.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libplanworkfactory.so.15.0.0
calligraplan-libs.x86_64: E: library-without-ldconfig-postun /usr/lib64/libplanworkfactory.so.15.0.0
calligraplan-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
calligraplan-debugsource.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 27 errors, 23 warnings.

Spec URL: https://rdieter.fedorapeople.org/rpms/calligra/calligraplan.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/calligra/calligraplan-3.0.91-3.el7.src.rpm

* Wed Jan 03 2018 Rex Dieter <rdieter> 3.0.91-3
- -libs: really add ldconfig scriptlet
- fix icon dir ownership


Ownership of /usr/share/config.kcfg is not a problem specific to this package, and should be owned elsewhere.

/usr/share/config.kcfg ownership added:
https://src.fedoraproject.org/rpms/kf5/c/8a1196371df990a8d43be24464b726f2c3fc38db

Ok then the package is approved.

Thanks for the review!

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/calligraplan

imported, thanks all