Bug 1530846 - gitk fails to start
Summary: gitk fails to start
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fontconfig
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Akira TAGOH
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-04 03:35 UTC by Filipe Rosset
Modified: 2018-03-21 05:36 UTC (History)
20 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-20 11:22:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Filipe Rosset 2018-01-04 03:35:41 UTC
[filiperosset@raw aime]$ gitk 
Error in startup script: bad screen distance "4.5"
    while executing
"$canv conf -scrollregion [list 0 0 $canvxmax $ymax]"
    (procedure "setcanvscroll" line 6)
    invoked from within
"setcanvscroll"
    (procedure "initlayout" line 17)
    invoked from within
"initlayout"
    (procedure "getcommits" line 4)
    invoked from within
"getcommits {}"
    (file "/usr/bin/gitk" line 12613)
[filiperosset@raw aime]$ rpm -qi gitk
Name        : gitk
Version     : 2.15.1
Release     : 3.fc28


full logs/versions: https://paste.fedoraproject.org/paste/48I8mTfWiEnZm3VpvTWGJQ

Comment 1 Todd Zullinger 2018-01-04 05:57:42 UTC
Can you let us know what locale you're using?

I'm able to run gitk without error in a rawhide container, using the default locale settings.  If I set LANG=it_IT.utf8 and run gitk, then it fails.

I don't know if this is a gitk or tk issue.  It affects rawhide but not f26.  There haven't been any significant changes to gitk recently, which makes me think some other change is causing the problem.  I'm not terribly familiar with tk, so hopefully someone else might have some ideas.

Comment 2 Filipe Rosset 2018-01-04 23:38:03 UTC
I'm using pt_BR.UTF-8
If I set en_US.UTF-8 than it works

Comment 3 Fedora End Of Life 2018-02-20 15:22:07 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 4 Paolo Bonzini 2018-03-20 11:18:41 UTC
The culprit is LC_NUMERIC.  Tcl is usually very careful to keep LC_NUMERIC="C", otherwise various functions in Tcl start expecting a decimal comma instead of a point (Tcl is string-based).

However, fontconfig's FcConfigEnsure is now calling setlocale(LC_ALL, "") and this breaks gitk among other programs.

The fix in the upstream fontconfig repository is this:

https://github.com/behdad/fontconfig/commit/98eaef69af1350e459bf9c175476d3b772968874

Could it please be backported?

Comment 5 Paolo Bonzini 2018-03-20 11:22:17 UTC
Fixed by fontconfig-2.13.0-3.fc28.x86_64 (patch fontconfig-locale.patch).


Note You need to log in before you can comment on or make changes to this bug.