Bug 1531289 - Update to massif-visualizer-0.7.0
Summary: Update to massif-visualizer-0.7.0
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: massif-visualizer
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-04 22:19 UTC by Sandro Mani
Modified: 2018-02-15 18:29 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-15 17:06:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
massif-visualizer.spec (2.16 KB, text/plain)
2018-01-04 22:19 UTC, Sandro Mani
no flags Details
Patch (5.15 KB, patch)
2018-02-15 10:47 UTC, Sandro Mani
no flags Details | Diff

Description Sandro Mani 2018-01-04 22:19:31 UTC
Created attachment 1377218 [details]
massif-visualizer.spec

The attached spec file is for 0.7.0. I'm happy to help maintaining the package if desired.

Comment 1 Sandro Mani 2018-01-23 12:04:19 UTC
Ping?

Comment 2 Rex Dieter 2018-01-26 15:57:41 UTC
The .spec provided is a good start.

I'd prefer if URLs stayed on .kde.org domain rather than point to github.com mirror, but that's minor (non-blocker)

Having one less kde4-based app would be nice too.

Comment 3 Sandro Mani 2018-02-10 21:27:20 UTC
@Lubomir Rintel: Ping? You obviously are active since you just submitted a build today, could you please reply?

Comment 4 Lubomir Rintel 2018-02-15 10:09:00 UTC
Hi. Thanks for the SPEC file. It seems to be a complete rewrite though, that's sort of difficult to review.

A patch set with explanation of changes would be a better idea.

Comment 5 Sandro Mani 2018-02-15 10:47:24 UTC
Created attachment 1396373 [details]
Patch

Thanks for your reply. Find attached a git formatted patch which is more closely aligned to the previous spec. Comments:

- Group tag is obsolete
- Use various convenience macros (%autosetup, %make_build, %make_install)
- Validate appdata file which is now shipped
- Remove obsolete scriptlets

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25068582

Comment 6 Lubomir Rintel 2018-02-15 17:06:46 UTC
(In reply to Sandro Mani from comment #5)
> Created attachment 1396373 [details]
> Patch
> 
> Thanks for your reply. Find attached a git formatted patch which is more
> closely aligned to the previous spec. Comments:
> 
> - Group tag is obsolete
> - Use various convenience macros (%autosetup, %make_build, %make_install)
> - Validate appdata file which is now shipped
> - Remove obsolete scriptlets
> 
> Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25068582

Thank you. Meanwhile I've updated the package (and kgraphview too) to newer version. I've basically done only minimal changes. That also means that your patch no longer applies -- sorry.

I'm now closing this ticket since the upgrade has been done.

I've made you a maintainer of the package (an kgraphview too, since that one is related) -- thanks for stepping up to do the maintenance work, it's much valued.

While I don't see too much point in changes such as dropping Group or replacing macros with a different ones of equivalent functionality I don't really mind them. Feel free to go ahead and do changes as you like, but please keep them in separate commits and avoid mixing cleanups with actual changes to the package.

Comment 7 Sandro Mani 2018-02-15 18:29:24 UTC
Seems like today is "Don't mind old stuff in spec Day" (see also the "Removal of BuildRoot" thread on -devel) ;)

In any event, thanks for the update!


Note You need to log in before you can comment on or make changes to this bug.