RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1531290 - Evil sed command in iptables.spec file
Summary: Evil sed command in iptables.spec file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: iptables
Version: 7.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Phil Sutter
QA Contact: Tomas Dolezal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-04 22:30 UTC by Rolf Fokkens
Modified: 2018-10-30 09:39 UTC (History)
3 users (show)

Fixed In Version: iptables-1.4.21-27.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-30 09:38:43 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3093 0 None None None 2018-10-30 09:39:04 UTC

Description Rolf Fokkens 2018-01-04 22:30:29 UTC
Description of problem:
The iptables.spec file contains the following line:

  sed -i -e 's;^\(After=.*\)$;Before=ip6tables.service\n\1;' %{SOURCE3}

This has the evil side effect of changing a sources file of the RPM. When building with mock this may not be an issue, but it is an issue in the following situation:

  rpmbuild -bb iptables.spec (this has a side effect)
  rpmbuild -bs iptables.spec (now the side effect is in the resulting src.rpm)

A better way might be this:

  # install systemd service files
  install -d -m 755 %{buildroot}/%{_unitdir}
  sed -e 's;iptables;ip6tables;g' \
      -e 's;IPv4;IPv6;g' \
      -e 's;/usr/libexec/ip6tables;/usr/libexec/iptables;g' \
      -e 's;^\(After=.*\)$;\1,iptables.service;' \
      < %{SOURCE3} > ip6tables.service
  sed -e 's;^\(After=.*\)$;Before=ip6tables.service\n\1;' %{SOURCE3} > iptables.service
  install -c -m 644 iptables.service %{buildroot}/%{_unitdir}
  install -c -m 644 ip6tables.service %{buildroot}/%{_unitdir}

So instead of changing the source file, just create an in between file and move on from there

Version-Release number of selected component (if applicable):
iptables-1.4.21-18.2.el7_4

How reproducible:
100%

Steps to Reproduce:
1. rpm -i iptables-1.4.21-18.2.el7_4.src.rpm
2. rpmbuild -bb iptables.spec
3. rpmbuild -bs iptables.spec
4. Enjoy corrupted src.rpm

Actual results:
Accident waiting to happen

Expected results:
Happy RPM building

Additional info:
I would assume there are quality guidelines against this, but I'm not sure

Comment 2 Rolf Fokkens 2018-04-02 15:03:23 UTC
Well, it happened again (still?) : same issue in iptables-1.4.21-18.3.el7_4.src.rpm

I'm not sure, but I think we should consider this bad practice:
* Unwanted side effects
* Unneeded

Comment 3 Phil Sutter 2018-04-04 21:14:19 UTC
Hi Rolf,

(In reply to Rolf Fokkens from comment #2)
> Well, it happened again (still?) : same issue in
> iptables-1.4.21-18.3.el7_4.src.rpm
> 
> I'm not sure, but I think we should consider this bad practice:
> * Unwanted side effects
> * Unneeded

Thanks for your detailed report. Sadly this ticket didn't make it into RHEL7.5 due to missing capacity on QE side. We will reconsider for RHEL7.6.

Thanks, Phil

Comment 8 errata-xmlrpc 2018-10-30 09:38:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3093


Note You need to log in before you can comment on or make changes to this bug.