Bug 1531511 - User could not pull a private image from a docker registry when a pull secret is defined
Summary: User could not pull a private image from a docker registry when a pull secret...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Master
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.9.0
Assignee: Maciej Szulik
QA Contact: Wang Haoran
URL:
Whiteboard:
: 1529867 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-05 11:56 UTC by Chuan Yu
Modified: 2021-06-10 14:06 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: oc create secret was creating malformed secret for pulling images. Consequence: User could not pull an image from a private repository. Fix: Fix the format of the secret for pulling images. Result: The ability to pull images from a private repository works as expected.
Clone Of:
Environment:
Last Closed: 2018-03-28 14:17:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 None None None 2018-03-28 14:17:57 UTC

Comment 2 Ben Parees 2018-01-05 14:32:59 UTC
I believe this to either be an issue w/ the format of the docker secret being created, or it not being properly supplied to the registry with the pull request, I do not believe it is an actual issue w/ registry authentication.

Comment 3 Wang Haoran 2018-01-08 05:38:42 UTC
issues tracked in origin : https://github.com/openshift/origin/issues/17197

Comment 4 Maciej Szulik 2018-01-11 14:02:45 UTC
master is fixed in https://github.com/openshift/origin/pull/18003
3.8 is not affected
3.7 is fixed in https://github.com/openshift/origin/pull/18062

Comment 6 Wang Haoran 2018-01-12 04:54:32 UTC
Moved to MODIFIED, as new puddles are not built out.

Comment 8 Wang Haoran 2018-01-23 08:02:57 UTC
Tested on:
oc v3.9.0-0.22.0
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://qe-geliu-39privatemen-1.westus.cloudapp.azure.com:8443
openshift v3.9.0-0.22.0
kubernetes v1.9.1+a0ce1bc657


1. oc create secret docker-registry haowang1 --docker-email=*** --docker-user-name=*** --docker-password=** 
 Works as expected.
2. oc secrets new haowang2 .dockerconfigjson=/home/haoran/.docker/config.json 
 Also works as expected
3. oc secrets new-dockercfg haowang --docker-email=*** --docker-user-name=*** --docker-password=** 
This is totally not worked

Comment 9 Maciej Szulik 2018-01-23 11:59:46 UTC
Thanks, good catch. I've fixed it in https://github.com/openshift/origin/pull/18226.

Comment 10 openshift-github-bot 2018-01-28 14:19:02 UTC
Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/1a849c6d6e31c1d7977c53e4e2514fa07f68dcd9
Merge pull request #18226 from soltysh/bug1531511

Automatic merge from submit-queue.

Fix oc secrets new-dockercfg to create secret identical like oc create secret

It looks like I missed one more create secret thing. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531511

/assign @juanvallejo

Comment 11 Wang Haoran 2018-01-30 02:08:59 UTC
Will verify this in next puddle

Comment 12 Wang Haoran 2018-02-02 09:31:27 UTC
It works well with:
oc v3.9.0-0.34.0
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://host-8-243-252.host.centralci.eng.rdu2.redhat.com:8443
openshift v3.9.0-0.34.0
kubernetes v1.9.1+a0ce1bc657



I but still have some concerns, the "oc secrets new-dockercfg" cmd was originally create a .dockercfg secret source, but now it's .dockerconfig source, does that mean we will not support the old secret type? If you guys are intended to this, I will move to verify.

Comment 13 Maciej Szulik 2018-02-05 12:43:43 UTC
That is correct. This is the direction upstream is going as well.

Comment 14 Bruno Andrade 2018-02-15 11:55:33 UTC
*** Bug 1529867 has been marked as a duplicate of this bug. ***

Comment 17 errata-xmlrpc 2018-03-28 14:17:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489

Comment 19 Maciej Szulik 2018-04-24 06:45:33 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=1476330 for details about 3.7.z fix.


Note You need to log in before you can comment on or make changes to this bug.