Bug 1531670 - Review Request: rust-error-chain - Error boilerplate library
Summary: Review Request: rust-error-chain - Error boilerplate library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1531857 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-05 18:41 UTC by Igor Gnatenko
Modified: 2018-01-06 19:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-06 19:10:54 UTC
Type: ---
Embargoed:
lemenkov: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2018-01-05 18:41:06 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-error-chain.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-error-chain-0.11.0-1.fc28.src.rpm
Description: Error boilerplate library.
FAS account: ignatenkobrain

Comment 1 Igor Gnatenko 2018-01-06 08:37:49 UTC
*** Bug 1531857 has been marked as a duplicate of this bug. ***

Comment 2 Peter Lemenkov 2018-01-06 11:14:03 UTC
I'll review it.

Comment 3 Peter Lemenkov 2018-01-06 11:24:25 UTC
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

The package is mostly autogenerated, so everything is built according to the Guidelines.

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (MIT or Apache 2.0).
+ The files, containing the text of the license(s) for the package, are included as %license.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The package successfully compiles and builds into binary rpms on at least one primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No C/C++ header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files without a suffix (e.g. libfoo.so) in some of the dynamic linker's default paths.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other packages.
+ All filenames in rpm packages are valid UTF-8.

APPROVED.

Comment 4 Gwyn Ciesla 2018-01-06 16:48:06 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-error-chain


Note You need to log in before you can comment on or make changes to this bug.