Bug 1531987 - increment of a boolean expression warning
Summary: increment of a boolean expression warning
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-07 03:40 UTC by Varsha
Modified: 2018-03-15 11:24 UTC (History)
3 users (show)

Fixed In Version: glusterfs-4.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-08 04:23:51 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Varsha 2018-01-07 03:40:43 UTC
Description of problem:
On compiling following warning is generated:

dht-common.c: In function ‘dht_readdirp_cbk’:
dht-common.c:6475:56: warning: increment of a boolean expression [-Wbool-operation]
                                 layout->search_unhashed++;

How reproducible:
Always

Steps to Reproduce:
1. ./autogen.sh
2. ./configure
3. make

Additional info:
(GCC) 7.2.1
flex 2.6.1

Comment 1 Worker Ant 2018-01-07 07:27:21 UTC
REVIEW: https://review.gluster.org/19156 (cluster/dht: Change datatype of search_unhashed variable) posted (#1) for review on master by

Comment 2 Worker Ant 2018-01-11 03:21:16 UTC
COMMIT: https://review.gluster.org/19156 committed in master by  with a commit message- cluster/dht: Change datatype of search_unhashed variable

Variable search_unhashed is of type boolean, change it to integer type.
This fixes the warning increment of a boolean expression.

BUG: 1531987

Change-Id: Ibf153f6a9ad704da38bff346b6a21a71323ed9bb
Signed-off-by: Varsha Rao <varao>

Comment 3 Shyamsundar 2018-03-15 11:24:53 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.