Bug 1532040 - Webadmin: Available LUNs are grayed out in block domain creation prompt
Summary: Webadmin: Available LUNs are grayed out in block domain creation prompt
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.1
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.1
: ---
Assignee: shani
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-07 16:10 UTC by Elad
Modified: 2018-02-12 11:51 UTC (History)
8 users (show)

Fixed In Version: ovirt-engine-4.2.1.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-12 11:51:03 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+
ylavi: exception+
pnovotny: testing_plan_complete-


Attachments (Terms of Use)
Screenshot from Webadmin (69.54 KB, image/png)
2018-01-07 16:10 UTC, Elad
no flags Details
Solution suggested by Eldan (274.15 KB, image/png)
2018-01-11 08:03 UTC, shani
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 86187 0 master MERGED webadmin: Change the lines' color on iSCSI LUNs table 2018-01-11 14:36:46 UTC

Description Elad 2018-01-07 16:10:42 UTC
Created attachment 1378145 [details]
Screenshot from Webadmin

Description of problem:
In Block storage domain creation prompt, the LUNs that are available for domain creation are grayed out.

Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-4.2.1-0.2.el7.noarch
rhvm-4.2.1-0.2.el7.noarch


Steps to Reproduce:
1. Open new storage domain creation prompt
2. Pick iSCSI, discover targets and login to them
3. Observe the available LUNs 

Actual results:
Available LUNs are grayed out

Expected results:
Available LUNs should not be grayed out

Additional info:
Screenshot from Webadmin

Comment 1 Elad 2018-01-07 16:21:36 UTC
The same also for manage domain prompt

Comment 2 Nir Soffer 2018-01-07 17:39:35 UTC
Elad, how do you know that the luns are available?

Please attach engine and vdsm logs.

Comment 3 Elad 2018-01-07 20:18:48 UTC
Their 'Add' button is clickable.

Comment 4 Yaniv Kaul 2018-01-08 09:37:53 UTC
Shani, can you take a look?

Comment 5 shani 2018-01-08 10:34:59 UTC
Hi,

After a discussion with Eldan, we had some changes [1] on that popup (same changes appear also for managing an exists iSCSI storage domain, as you've mentioned).

As a part of that change only included LUNs' lines are black colored. 
When creating a new iSCSI storage domain, since it has no LUNs, all lines should remain gray colored.
As you've described, the 'Add' button indicates that the LUN is available for using it. (Otherwise, there's 'N/A' label). 

By pressing the 'Add' button, the selected LUN's line should change its color to dark-blue.

Therefore, this is not a bug.
This is the expected behavior following those changes.

[1]
https://gerrit.ovirt.org/#/c/85544/

Comment 6 Yaniv Kaul 2018-01-08 10:53:48 UTC
(In reply to shani from comment #5)
> Hi,
> 
> After a discussion with Eldan, we had some changes [1] on that popup (same
> changes appear also for managing an exists iSCSI storage domain, as you've
> mentioned).
> 
> As a part of that change only included LUNs' lines are black colored. 
> When creating a new iSCSI storage domain, since it has no LUNs, all lines
> should remain gray colored.
> As you've described, the 'Add' button indicates that the LUN is available
> for using it. (Otherwise, there's 'N/A' label). 
> 
> By pressing the 'Add' button, the selected LUN's line should change its
> color to dark-blue.
> 
> Therefore, this is not a bug.
> This is the expected behavior following those changes.
> 
> [1]
> https://gerrit.ovirt.org/#/c/85544/

I must say this is not very intuitive to me (and as we can see, to Elad as well).
For example, why not have the joined ones in BOLD, the available in black and the  unavailable in gray?
I suggest keeping this bug open and thinking of alternatives before closing as NOTABUG.

Comment 7 Tal Nisan 2018-01-08 11:26:48 UTC
I agree, grayed out usually means disabled, I think the available ones should be in black.
Shani can you please consult with Eldan on that? It should be a quick fix and we'd like to see it in 4.2.1

Comment 9 shani 2018-01-11 08:03:18 UTC
Created attachment 1379868 [details]
Solution suggested by Eldan

Comment 10 Pavel Novotny 2018-01-26 16:11:43 UTC
Verified in
ovirt-engine-4.2.1.3-0.1.el7.noarch
ovirt-engine-webadmin-portal-4.2.1.3-0.1.el7.noarch

As was suggested by Eldan,
now the lines with available LUNs have black color
and selected LUNs are in bold black.

Comment 11 Sandro Bonazzola 2018-02-12 11:51:03 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.