1532195 – -cpuid help broken with IBRS because of too long model-id

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1532195 - -cpuid help broken with IBRS because of too long model-id

Summary: -cpuid help broken with IBRS because of too long model-id

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	qemu-kvm-rhev
Sub Component:
Version:	7.5
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	medium
Target Milestone:	rc
Target Release:	---
Assignee:	Eduardo Habkost
QA Contact:	Guo, Zhiyi
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1609081
TreeView+	depends on / blocked

Reported:	2018-01-08 10:39 UTC by Dr. David Alan Gilbert
Modified:	2023-09-15 00:06 UTC (History)
CC List:	15 users (show)
Fixed In Version:	qemu-kvm-rhev-2.12.0-1.el7
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2018-11-01 11:04:08 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Description Dr. David Alan Gilbert 2018-01-08 10:39:38 UTC

Description of problem:

running qemu-kvm -cpuid help I see:

....
x86        IvyBridge  Intel Xeon E3-12xx v2 (Ivy Bridge)              
x86     Nehalem-IBRS  Intel Core i7 9xx (Nehalem Core i7, IBRS update)4�j
x86          Nehalem  Intel Core i7 9xx (Nehalem Class Core i7)       
....

The junk after Nehalem-IBRS is random.

Version-Release number of selected component (if applicable):
qemu-kvm-rhev-2.10.0-16.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. /usr/libexec/qemu-kvm -cpu help

Actual results:
....
x86        IvyBridge  Intel Xeon E3-12xx v2 (Ivy Bridge)              
x86     Nehalem-IBRS  Intel Core i7 9xx (Nehalem Core i7, IBRS update)4�j
x86          Nehalem  Intel Core i7 9xx (Nehalem Class Core i7)       
....


Expected results:
No junk at the end

Additional info:

Comment 2 Guo, Zhiyi 2018-01-08 10:55:52 UTC

This issue can be observed on both 7.4.z, 7.3.z and 7.2.z qemu-kvm-rhev packages

Comment 7 Chet Burgess 2018-03-22 20:29:12 UTC

I can confirm that this is also happening on the version that is shipped as part of OSP 8.

qemu-kvm-rhev-2.9.0-16.el7_4.13.x86_64

cfb.mc ~$ /usr/libexec/qemu-kvm -cpu help | grep Nehalem-IBRS
x86     Nehalem-IBRS  Intel Core i7 9xx (Nehalem Core i7, IBRS update)IyF��U

Comment 8 Eduardo Habkost 2018-04-11 14:15:39 UTC

Moving back to ASSIGNED, it needs a new patch.

Comment 11 Eduardo Habkost 2018-05-08 14:55:51 UTC

For reference, upstream fix in QEMU 2.12.0:

commit 807e9869b8c4119b81df902625af818519e01759
Author: Eduardo Habkost <ehabkost>
Date:   Tue Jan 9 13:45:13 2018 -0200

    i386: Change X86CPUDefinition::model_id to const char*
    
    It is valid to have a 48-character model ID on CPUID, however the
    definition of X86CPUDefinition::model_id is char[48], which can
    make the compiler drop the null terminator from the string.
    
    If a CPU model happens to have 48 bytes on model_id, "-cpu help"
    will print garbage and the object_property_set_str() call at
    x86_cpu_load_def() will read data outside the model_id array.
    
    We could increase the array size to 49, but this would mean the
    compiler would not issue a warning if a 49-char string is used by
    mistake for model_id.
    
    To make things simpler, simply change model_id to be const char*,
    and validate the string length using an assert() on
    x86_register_cpudef_type().
    
    Reported-by: "Dr. David Alan Gilbert" <dgilbert>
    Signed-off-by: Eduardo Habkost <ehabkost>
    Message-Id: <20180109154519.25634-2-ehabkost>
    Signed-off-by: Eduardo Habkost <ehabkost>

Comment 14 Eduardo Habkost 2018-05-21 20:04:47 UTC

Setting to MODIFIED because it's in the 2.12 rebase.

Comment 16 jingzhao 2018-06-05 09:26:39 UTC

Reproduce the issue with qemu-kvm-rhev-2.10.0-21.el7.x86_64

/usr/libexec/qemu-kvm -cpu help
......
x86        IvyBridge  Intel Xeon E3-12xx v2 (Ivy Bridge)              
x86     Nehalem-IBRS  Intel Core i7 9xx (Nehalem Core i7, IBRS update)T�OIaU
x86          Nehalem  Intel Core i7 9xx (Nehalem Class Core i7)  

Verified the issue with qemu-kvm-rhev-2.12.0-3.el7.x86_64

/usr/libexec/qemu-kvm -cpu help
.....
x86        IvyBridge  Intel Xeon E3-12xx v2 (Ivy Bridge)              
x86     Nehalem-IBRS  Intel Core i7 9xx (Nehalem Core i7, IBRS update)
x86          Nehalem  Intel Core i7 9xx (Nehalem Class Core i7)

Comment 20 errata-xmlrpc 2018-11-01 11:04:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3443

Comment 21 Red Hat Bugzilla 2023-09-15 00:06:02 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days

Note You need to log in before you can comment on or make changes to this bug.