Spec URL: http://fedora.danny.cz/smc-tools.spec SRPM URL: http://fedora.danny.cz/smc-tools-1.0.0-1.fc27.src.rpm Description: The Shared Memory Communication Tools (smc-tools) package enables usage of SMC sockets in Linux. Fedora Account System Username: sharkcz Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24072434 rpmlint output: smc-tools.x86_64: W: no-soname /usr/lib64/ld_pre_smc.so 3 packages and 0 specfiles checked; 0 errors, 1 warnings. The library is only meant for LD_PRELOAD use-case, not as a linked library, so lack of soname should be OK.
- Shouldn't you still run ldconfig in %post and %postun? https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries - Use %make_build for parallel building: %make_build CFLAGS="-Iinclude %{optflags}" - Please add comments explaining what the patches do Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "EPL", "Unknown or generated", "EPL (v1.0)". 6 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/smc-tools/review-smc-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: smc-tools-1.0.0-1.fc28.x86_64.rpm smc-tools-debuginfo-1.0.0-1.fc28.x86_64.rpm smc-tools-debugsource-1.0.0-1.fc28.x86_64.rpm smc-tools-1.0.0-1.fc28.src.rpm smc-tools.x86_64: W: no-soname /usr/lib64/ld_pre_smc.so smc-tools-debugsource.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
Updated spec URL: http://fedora.danny.cz/smc-tools.spec Updated SRPM URL: http://fedora.danny.cz/smc-tools-1.0.0-2.fc27.src.rpm Changes: - use make macro in build - comment patches, they were sent to upstream - use distro LDFLAGS during build Regarding ldconfig, it should not be necessary, because the *.so file isn't used as a regular shared library (you won't link against it), but is used with LD_PRELOAD mechanism only.
All good, package approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/smc-tools. You may commit to the branch "f27" in about 10 minutes.
Closing, imported and built. The patches will be merged in next upstream release.