Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1532279

Summary:	rhevm-setup-plugins should require updating itself
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Yedidyah Bar David <didi>
Component:	rhevm-setup-plugins	Assignee:	Ido Rosenzwig <irosenzw>
Status:	CLOSED ERRATA	QA Contact:	Jiri Belka <jbelka>
Severity:	high	Docs Contact:
Priority:	high
Version:	unspecified	CC:	bburmest, didi, lsurette, lsvaty, ykaul
Target Milestone:	ovirt-4.2.2
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rhvm-setup-plugins-4.2.5-1.el7ev	Doc Type:	If docs needed, set a value
Doc Text:	Added an update check for rhevm-setup-plugins package at the beginning of ovirt-engine installation.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-15 17:33:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2018-01-08 14:49:31 UTC

Description of problem:

When running engine-setup, it (also) checks if there are updates to setup packages, and if so, lists the packages to be updated and aborts.

rhevm-setup-plugins should register itself in this set of packages, so that if there are updates to it, engine-setup will abort.

Note that fixing this bug will only affect attempts to upgrade from a fixed version, not from a non-fixed version to a fixed one.

Comment 2 Jiri Belka 2018-03-07 13:51:27 UTC

ok

# rpm -q ovirt-engine-setup rhvm-setup-plugins
ovirt-engine-setup-4.2.2.2-0.1.el7.noarch
rhvm-setup-plugins-4.2.5-1.el7ev.noarch

# grep rhevm-setup-plugins /var/log/yum.log 
Feb 23 17:07:53 Installed: rhevm-setup-plugins-4.1.5-1.el7ev.noarch
Mar 07 14:32:37 Erased: rhevm-setup-plugins-4.1.5-1.el7ev.noarch

Comment 3 Yedidyah Bar David 2018-03-07 13:59:16 UTC

Not sure how you could verify this, actually.

Reproduction/Verification flow is:

1. Install and setup engine
2. yum update 'ovirt\*setup\*'
3. Have newer rhvm-setup-plugins in the repo, but do not update it
4. engine-setup

With a broken engine-setup, it will continue happily. With a fixed one, it should abort, asking to update rhvm-setup-plugins.

Current build is the latest provided to QE, so you don't have an update for step 3.

You can try to verify using this jenkins build:

https://rhv-devops-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/rhvm-setup-plugins_master_build-artifacts-rhel7-x86_64/28/

Comment 4 Jiri Belka 2018-03-07 15:38:48 UTC

ok, misunderstood.

is this what i should see?

...
          Replying "No" will abort Setup. You can pass the option "--offline" to prevent installing or updating packages.
          Do you wish to update them now? (Yes, No) [Yes]: 
[ INFO  ] Checking for an update for Setup...
          An update for the Setup packages rhvm-setup-plugins was found. Please update that package by running:
          "yum update rhvm-setup-plugins"
          and then execute Setup again.
[ ERROR ] Failed to execute stage 'Environment customization': Please update the Setup packages
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20180307163435-ys5i1c.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20180307163504-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of setup failed

Comment 5 Yedidyah Bar David 2018-03-07 15:45:20 UTC

Exactly.

Comment 8 errata-xmlrpc 2018-05-15 17:33:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1473

Comment 9 Franta Kust 2019-05-16 13:06:33 UTC

BZ<2>Jira Resync