Spec URL: https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5345/24075345/python2-django1.11-1.11.9-1.fc28.src.rpm Description: This package provides Django in version 1.11 LTS, the last release to support Python 2. Django is a high-level Python Web framework that encourages rapid development and a clean, pragmatic design. It focuses on automating as much as possible and adhering to the DRY (Don't Repeat Yourself) principle. Fedora Account System Username: pviktori Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24075345 COPR: https://copr.fedorainfracloud.org/coprs/pviktori/python2-django1.11/ This compat package is part of the Django 2.0 change: http://fedoraproject.org/wiki/Changes/Django20 Note that the change is not accepted yet. I'll withdraw this request (or not add the package) if the change is rejected. This package currently conflicts with python2-django; see the change for how we'll sort that out.
> python-memcached, python-sphinx There's python2-memcached [1] and python2-sphinx [2]. > Requires: python2-pytz This seems like part of the test requires, I suggest to move it down a bit by an extra new line before it. > # build documentation > ... > cp -ar docs .. What is the purpose of this cp? > # remove .po files > find $RPM_BUILD_ROOT -name "*.po" | xargs rm -f Please use %{buildroot}, as you do in the rest of the file. > %{__python} ./runtests.py --settings=test_sqlite --verbosity=2 --parallel 1 Use %{__python2} explicitly. [1] https://koji.fedoraproject.org/koji/buildinfo?buildID=1011376 [2] https://koji.fedoraproject.org/koji/buildinfo?buildID=1015148
Spec URL: https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1548/24111548/python2-django1.11-1.11.9-1.fc28.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24111548 Thanks! I fixed those issues. The `cp` was useless here.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./tests/app_loading/eggs/brokenapp.egg ./tests/app_loading/eggs/nomodelapp.egg ./tests/app_loading/eggs/omelet.egg ./tests/app_loading/eggs/modelapp.egg ./tests/utils_tests/eggs/test_egg.egg ./tests/user_commands/eggs/basic.egg ./tests/template_tests/eggs/tagsegg.egg See: http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages The prebuilt package has been taken from koji [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "PSF (v2)", "*No copyright* BSD (unspecified)", "BSD (3 clause)", "*No copyright* Apache (v2.0)". 5210 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/review-python2-django1.11/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sv, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/sq, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ja, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/sl, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ca, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/cs, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ka/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/fi/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/hr/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/bg/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/gl/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hu, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hr, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/mn/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/he, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sl/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/udm, /usr/lib/python2.7/site-packages/django/conf/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/tr/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/cs/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ar, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/et/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/nl/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/conf/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ca/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/redirects/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/fa/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/uk/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/udm, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/fr, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/fi, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/dsb/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/fa, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/el/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/be/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/is/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/es_CO, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/mn, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/mk, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/lv/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/redirects/locale/ast, /usr/lib/python2.7/site-packages/django/conf/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sq/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/dsb, /usr/lib/python2.7 /site-packages/django/contrib/admin/locale/hsb, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/dsb, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/tr, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/kk, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/ka, /usr/lib/python2.7 /site-packages/django/contrib/sessions/locale/hsb, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/da, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/de, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/es_MX, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ar/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/hsb, /usr/lib/python2.7/site-packages/django/conf/locale/hsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ne/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/es_CO/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/lt/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/es_AR/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ru, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hant/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/is, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/it, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ia, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/id, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ro/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ro, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/be, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/bg, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/kk/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/eo/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ko, /usr/lib/python2.7/site-packages/django/contrib/redirects/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/de/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ko/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/pt, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/pl, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/gl, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/gd, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/es_AR, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hans, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/es_MX/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hant, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/pt_BR, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/nb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ne, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/nl, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ja/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/pt/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/et, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/eu, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/es, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/el, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/hu/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/en, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/eo, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ia/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/ast, /usr/lib/python2.7 /site-packages/django/contrib/redirects/locale/udm, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/zh_Hans/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/nb/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/uk, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sv/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/lv, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/lt, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/he/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/eu/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/id/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/hsb/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/gd/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/mk/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/hsb, /usr/lib/python2.7 /site-packages/django/contrib/messages, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/da/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hsb [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sv, /usr/lib/python2.7/site- packages/django/conf/locale/hsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sq, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ja, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ne/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/tr, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/es_CO/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/sl, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ca, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/lt/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/cs, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/es_AR/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ru, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hant/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/is, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/it, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hans/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ia, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/id, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ka/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ro/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ro, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/fi/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/hr/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/be, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/bg, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/bg/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/gl/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/kk/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/eo/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hu, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hr, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ja/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/mn/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/he, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sl/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/eu/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/udm, /usr/lib/python2.7/site-packages/django/conf/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/sites/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/tr/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/cs/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ar, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/dsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/et/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/de/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ko/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/pt, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/gis/locale/hsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/nl/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/fa/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/gl, /usr/lib/python2.7/site-packages/django/conf/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/gd, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ca/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/udm, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/es_AR, /usr/lib/python2.7/site-packages/django/contrib/redirects/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hans, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/pl, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/es_MX/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/zh_Hant, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/pt_BR, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/uk/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/nb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ne, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/udm, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/fr, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/nl, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/fi, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/mk/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/dsb/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/fa, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/el/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/be/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/is/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sv/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/pt/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/et, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/eu, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/mn, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/hsb, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/es, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/el, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/hu/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/en, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/eo, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ia/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/ast, /usr/lib/python2.7 /site-packages/django/contrib/redirects/locale/udm, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/lv/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/redirects/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/nb/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/conf/locale/udm, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/sq/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/contenttypes/locale/dsb, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/uk, /usr/lib/python2.7 /site-packages/django/contrib/postgres/locale/es_CO, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/lv, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/lt, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/hsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/he/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/redirects/locale/hsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/id/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/hsb/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ko, /usr/lib/python2.7/site-packages/django/contrib/auth/locale/dsb, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/kk, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/gd/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ka, /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/hsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/mk, /usr/lib/python2.7/site-packages/django/contrib/flatpages/locale/ast, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/da, /usr/lib/python2.7/site-packages/django/contrib/messages, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/de, /usr/lib/python2.7/site-packages/django/contrib/admin/locale/ast, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/da/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/es_MX, /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hsb, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/ar/LC_MESSAGES, /usr/lib/python2.7/site- packages/django/contrib/postgres/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-packages/django/contrib/admindocs/locale/hsb [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. It does not build for me in mock [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-django1.11-1.11.9-1.fc28.noarch.rpm python2-django1.11-doc-1.11.9-1.fc28.noarch.rpm python2-django1.11-1.11.9-1.fc28.src.rpm python2-django1.11.noarch: W: spelling-error %description -l en_US Django -> Fandango python2-django1.11.noarch: W: obsolete-not-provided python-django python2-django1.11.noarch: W: obsolete-not-provided python2-django python2-django1.11.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/django/bin/django-admin.py /usr/bin/env python python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/app_template/__init__.py-tpl python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/app_template/migrations/__init__.py-tpl python2-django1.11.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/django/conf/project_template/manage.py-tpl /usr/bin/env python python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/project_template/project_name/__init__.py-tpl python2-django1.11.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/django/contrib/admin/static/admin/js/vendor/xregexp/xregexp.js python2-django1.11.noarch: W: no-manual-page-for-binary django-admin-1.11 python2-django1.11.src: W: spelling-error %description -l en_US Django -> Fandango 3 packages and 0 specfiles checked; 6 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- python2-django1.11-doc.noarch: W: invalid-url URL: http://www.djangoproject.com/ <urlopen error [Errno -2] Name or service not known> python2-django1.11.noarch: W: spelling-error %description -l en_US Django -> Fandango python2-django1.11.noarch: W: invalid-url URL: http://www.djangoproject.com/ <urlopen error [Errno -2] Name or service not known> python2-django1.11.noarch: W: obsolete-not-provided python-django python2-django1.11.noarch: W: obsolete-not-provided python2-django python2-django1.11.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/django/bin/django-admin.py /usr/bin/env python python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/app_template/__init__.py-tpl python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/app_template/migrations/__init__.py-tpl python2-django1.11.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/django/conf/project_template/manage.py-tpl /usr/bin/env python python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/project_template/project_name/__init__.py-tpl python2-django1.11.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/django/contrib/admin/static/admin/js/vendor/xregexp/xregexp.js python2-django1.11.noarch: W: no-manual-page-for-binary django-admin-1.11 2 packages and 0 specfiles checked; 6 errors, 6 warnings. Requires -------- python2-django1.11-doc (rpmlib, GLIBC filtered): python2-django1.11 python2-django1.11 (rpmlib, GLIBC filtered): /usr/bin/env /usr/bin/python2 python(abi) python2-pytz Provides -------- python2-django1.11-doc: python2-django1.11-doc python2-django1.11: bundled(jquery) bundled(xregexp) python2-django1.11 python2.7dist(django) python2dist(django) Source checksums ---------------- https://files.pythonhosted.org/packages/source/D/Django/Django-1.11.9.tar.gz : CHECKSUM(SHA256) this package : 353d129f22e1d24980d6061666f435781141c2dfd852f14ffc8a670175821034 CHECKSUM(SHA256) upstream package : 353d129f22e1d24980d6061666f435781141c2dfd852f14ffc8a670175821034 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --prebuilt -n python2-django1.11 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Please fix the unowned directories and files, and you may want to fix the script executable flags on js. Otherwise looks good to me.
Also, note the /usr/bin/env.
Spec URL: https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7064/24267064/python2-django1.11-1.11.9-1.fc28.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24267064 Thanks for the review. I did the changes. Remaining rpmlint complaints I get: python2-django1.11-doc.noarch: W: invalid-url URL: http://www.djangoproject.com/ <urlopen error [Errno -2] Name or service not known> -- local connection issue python2-django1.11.noarch: W: spelling-error %description -l en_US Django -> Fandango -- bogus python2-django1.11.noarch: W: obsolete-not-provided python-django python2-django1.11.noarch: W: obsolete-not-provided python2-django -- intentional; see the Change and its contingency plan python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/app_template/__init__.py-tpl python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/app_template/migrations/__init__.py-tpl python2-django1.11.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/django/conf/project_template/manage.py-tpl /usr/bin/env python python2-django1.11.noarch: E: zero-length /usr/lib/python2.7/site-packages/django/conf/project_template/project_name/__init__.py-tpl -- intentional; note that these are template files python2-django1.11.noarch: W: no-manual-page-for-binary django-admin-1.11 2 packages and 0 specfiles checked; 4 errors, 6 warnings. -- see comment in specfile Also, the automatic dependency on /usr/bin/env is not needed, but it doesn't really do any harm.
The python provide macro should be used, so the main package provides python-django1.11.
Please add this to the doc subpackage: Obsoletes: python-django-doc < 2 Obsoletes: python2-django-doc < 2
Spec URL: https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9252/24299252/python2-django1.11-1.11.9-1.fc28.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24299251 python_provide macros and Obsoletes added.
all issues are resolved now. Package approved!
Waiting for repo creation, which failed somehow: https://pagure.io/releng/fedora-scm-requests/issue/4231
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python2-django1.11
Pushed and built in Rawhide. https://koji.fedoraproject.org/koji/taskinfo?taskID=24400283 Thank you to all involved!