Bug 1532681 - run dommemstat --period 5 during upgrade to 4.2
Summary: run dommemstat --period 5 during upgrade to 4.2
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.20.4
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Dan Kenigsberg
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-09 15:17 UTC by Yaniv Bronhaim
Modified: 2018-01-12 16:12 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-01-12 16:12:41 UTC
oVirt Team: Virt
Embargoed:


Attachments (Terms of Use)

Description Yaniv Bronhaim 2018-01-09 15:17:36 UTC
Description of problem:
In https://gerrit.ovirt.org/#/c/80721/ we enable polling of balloon driver stats during vm creation. we use this information in Bug #1529271 to report memory stats.
In 4.2 for already running vms we need to run manually "dommemstat --period 5 [vm-name] to receive the information. This RFE is about doing this during upgrade of vdsm for all running vms.


How reproducible:
update vdsm 4.1 to 4.2 with running vms

check that vm xml includes stats field under memballoon:
<memballoon model='virtio'>
   <stats period='5' />
   <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
</memballoon>

Comment 1 Michal Skrivanek 2018-01-10 06:47:24 UTC
Why would we change already running VMs? Cluster level 4.2 VMs will have this, <4.2 won't

Comment 2 Shirly Radco 2018-01-10 07:48:26 UTC
We need to get vm memory statistics for the metrics store.
As I understand only a restart of all vms will enable that, which we can't have as a requirement just for collecting vm metrics.

This is a very important statistics and we must have it as part of 4.2.
This fix should enable the collection without a need to restart the vms.

Comment 3 Yaniv Bronhaim 2018-01-12 16:12:41 UTC
This can be avoided with the change in bug #1532692 . When we provide by default GA info the memory stats are included.


Note You need to log in before you can comment on or make changes to this bug.