Spec URL: https://tpopela.fedorapeople.org/webkit2gtk3.spec SRPM URL: https://tpopela.fedorapeople.org/webkit2gtk3-2.19.5-2.fc27.src.rpm Description: Hi, I'm asking for a review of the webkitgtk4 package rename to webkit2gtk3. The reason behind is that the number on the end is not tight to the GTK+ version, but to the API version. The problem is that it brings some confusion among our users (that we saw during the webkitgtk and webkitgtk3 deprecations) - please see https://lists.fedoraproject.org/archives/list/devel%40lists.fedoraproject.org/message/ERLSWM4UBLEXMXKXZUEMS2P6HEBGOAQV/ . The are currently no plans for GTK+ 4 based WebKitGTK+, but we should be ready for it. We want to rename the package only in rawhide (F28+). F26 and F27 will still have webkitgtk4. Fedora Account System Username: tpopela
I should also note, that other distributions (Debian, Suse) are using the webkit2gtk3 name.
That's incorrect according to my findings. Debian and Ubuntu are using webkit2gtk source package name and libwebkit2gtk-4.0-37 for the binary package with the library and libwebkit2gtk-4.0-dev for the development files: https://packages.debian.org/source/sid/webkit2gtk openSUSE indeed uses webkit2gtk3: https://build.opensuse.org/package/show/GNOME:Factory/webkit2gtk3
I've verified the obsoletes and provides and they all look good to me and all subpackages should be correctly covered for webkitgtk4->webkit2gtk3 rename. Beyond that, the packaging and upstream sources are the same as in the existing webkitgtk4 package and no changes there. APPROVED
(In reply to Kalev Lember from comment #2) > That's incorrect according to my findings. Debian and Ubuntu are using > webkit2gtk source package name and libwebkit2gtk-4.0-37 for the binary > package with the library and libwebkit2gtk-4.0-dev for the development > files: https://packages.debian.org/source/sid/webkit2gtk Indeed. Thank you for correcting me!
yes webkit2gtk , maybe the correct name , also checked arch Linux [1] - Look at this commit [2] internally is webkit2gtk-4.0 - When Gtk+ 4 [3] the same webkit2gtk IIRC should support the 2 gtk+ 3 and 4 . For these reasons, IMHO, seems to me webkit2gtk is more appropriate , or even webkit2gtk-4.0 (with - , to not confuse with gtk4) . Best regards, [1] https://www.archlinux.org/packages/extra/x86_64/webkit2gtk/ [2] https://github.com/hyperair/geany-plugins/commit/1fd266a97b9fedb0ae463a2cf9a409af27bb0ae6 [3] https://blogs.gnome.org/desrt/2016/06/13/gtk-4-0-is-not-gtk-4/ https://wiki.gnome.org/Projects/GTK%2B/Roadmap/GTK4
(In reply to Sergio Monteiro Basto from comment #5) > yes webkit2gtk , maybe the correct name , also checked arch Linux [1] > > - Look at this commit [2] internally is webkit2gtk-4.0 > - When Gtk+ 4 [3] the same webkit2gtk IIRC should support the 2 gtk+ 3 and 4 > . > > For these reasons, IMHO, seems to me webkit2gtk is more appropriate , or > even webkit2gtk-4.0 (with - , to not confuse with gtk4) . > > Best regards, > > [1] > https://www.archlinux.org/packages/extra/x86_64/webkit2gtk/ > > [2] > https://github.com/hyperair/geany-plugins/commit/ > 1fd266a97b9fedb0ae463a2cf9a409af27bb0ae6 > > [3] > https://blogs.gnome.org/desrt/2016/06/13/gtk-4-0-is-not-gtk-4/ > https://wiki.gnome.org/Projects/GTK%2B/Roadmap/GTK4 Could be, but from webkit2gtk you can't distinguish anything and we are on the same boat as we are now before the rename. But with webkit2gtk3 you can clearly distinguish on what WebKit and GTK+ versions it is based on.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/webkit2gtk3
(In reply to Tomas Popela from comment #6) > Could be, but from webkit2gtk you can't distinguish anything and we are on > the same boat as we are now before the rename. But with webkit2gtk3 you can > clearly distinguish on what WebKit and GTK+ versions it is based on. OK
I strongly recommend sticking with the name webkit2gtk3 to avoid confusion with any future webkitgtk4 package. And we can drop the 2 in the middle in future packages, since WebKit2 has been renamed to WebKit upstream, except in the GTK+ 3 API where it's part of the API. In the future, WebKitGTK+ for GTK+ 4 can just be called webkitgtk4. (What we have now. Which is what has prompted this renaming.) And for GTK+ 5, we can call it webkitgtk5.