Created attachment 1380219 [details] screenshot Description of problem: OPS UI screen is stuck on the new alert profile screen when pressing the cancel button. The workaround is to click on one of the other menus in the Navigation bar to get out of the screen. Version-Release number of selected component (if applicable): 5.9.0.16 How reproducible: 100% Steps to Reproduce: 1. create a new alert profile 2. press the cancel button 3. Actual results: the screen blinks but nothing happens Expected results: expected to be brought back to the alert profiles list view Additional info: [----] I, [2018-01-11T12:10:29.470568 #2722:3b94e04] INFO -- : Parameters: {"pressed"=>"alert_profile_new"} [----] I, [2018-01-11T12:10:29.497063 #2722:3b94e04] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/views/layouts/_flash_msg.html.haml (0.0ms) [----] I, [2018-01-11T12:10:29.498432 #2722:3b94e04] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/views/miq_policy/_alert_profile_details.html.haml (1.9ms) [----] I, [2018-01-11T12:10:29.499242 #2722:3b94e04] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/views/layouts/_x_edit_buttons.html.haml (0.5ms) [----] I, [2018-01-11T12:10:29.499774 #2722:3b94e04] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/views/layouts/_x_adv_searchbox.html.haml (0.3ms) [----] I, [2018-01-11T12:10:29.503707 #2722:3b94e04] INFO -- : Completed 200 OK in 33ms (Views: 1.3ms | ActiveRecord: 1.6ms) [----] I, [2018-01-11T12:10:33.237876 #2722:3b94a1c] INFO -- : Started POST "/miq_policy/alert_profile_edit?button=cancel" for 127.0.0.1 at 2018-01-11 12:10:33 -0800 [----] I, [2018-01-11T12:10:33.240211 #2722:3b94a1c] INFO -- : Processing by MiqPolicyController#alert_profile_edit as JS [----] I, [2018-01-11T12:10:33.240287 #2722:3b94a1c] INFO -- : Parameters: {"button"=>"cancel"} [----] F, [2018-01-11T12:10:33.251583 #2722:3b94a1c] FATAL -- : Error caught: [NoMethodError] undefined method `[]' for nil:NilClass /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/controllers/miq_policy_controller/alert_profiles.rb:5:in `alert_profile_load' /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/controllers/miq_policy_controller/alert_profiles.rb:9:in `alert_profile_edit_cancel' /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/controllers/miq_policy_controller/alert_profiles.rb:84:in `alert_profile_edit' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/abstract_controller/base.rb:188:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal/rendering.rb:30:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/abstract_controller/callbacks.rb:20:in `block in process_action' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:126:in `call' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:455:in `call' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:101:in `__run_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:90:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/abstract_controller/callbacks.rb:19:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal/rescue.rb:20:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/notifications.rb:164:in `block in instrument' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/notifications.rb:164:in `instrument' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal/instrumentation.rb:30:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal/params_wrapper.rb:248:in `process_action' /opt/rh/cfme-gemset/gems/activerecord-5.0.6/lib/active_record/railties/controller_runtime.rb:18:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/abstract_controller/base.rb:126:in `process' /opt/rh/cfme-gemset/gems/actionview-5.0.6/lib/action_view/rendering.rb:30:in `process' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal.rb:190:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_controller/metal.rb:262:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/routing/route_set.rb:50:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/routing/route_set.rb:32:in `serve' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/journey/router.rb:39:in `block in serve' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/journey/router.rb:26:in `each' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/journey/router.rb:26:in `serve' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/routing/route_set.rb:727:in `call' /opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/etag.rb:25:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/conditional_get.rb:38:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/head.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:232:in `context' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:226:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/cookies.rb:613:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:97:in `__run_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:750:in `_run_call_callbacks' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:90:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/callbacks.rb:36:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/remote_ip.rb:79:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' /opt/rh/cfme-gemset/gems/railties-5.0.6/lib/rails/rack/logger.rb:36:in `call_app' /opt/rh/cfme-gemset/gems/railties-5.0.6/lib/rails/rack/logger.rb:26:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/request_id.rb:24:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/method_override.rb:22:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/runtime.rb:22:in `call' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/executor.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/sendfile.rb:111:in `call' /opt/rh/cfme-gemset/gems/railties-5.0.6/lib/rails/engine.rb:522:in `call' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/configuration.rb:232:in `call' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:578:in `handle_request' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:415:in `process_client' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:275:in `block in run' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread' [----] I, [2018-01-11T12:10:33.252879 #2722:3b94a1c] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/views/layouts/_exception_contents.html.haml (0.6ms) [----] I, [2018-01-11T12:10:33.253316 #2722:3b94a1c] INFO -- : Completed 200 OK in 13ms (Views: 1.4ms | ActiveRecord: 1.0ms) /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/cookies.rb:613:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:97:in `__run_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:750:in `_run_call_callbacks' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/callbacks.rb:90:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/callbacks.rb:36:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/remote_ip.rb:79:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' /opt/rh/cfme-gemset/gems/railties-5.0.6/lib/rails/rack/logger.rb:36:in `call_app' /opt/rh/cfme-gemset/gems/railties-5.0.6/lib/rails/rack/logger.rb:26:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/request_id.rb:24:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/method_override.rb:22:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/runtime.rb:22:in `call' /opt/rh/cfme-gemset/gems/activesupport-5.0.6/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' /opt/rh/cfme-gemset/gems/actionpack-5.0.6/lib/action_dispatch/middleware/executor.rb:12:in `call' /opt/rh/cfme-gemset/gems/rack-2.0.3/lib/rack/sendfile.rb:111:in `call' /opt/rh/cfme-gemset/gems/railties-5.0.6/lib/rails/engine.rb:522:in `call' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/configuration.rb:232:in `call' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:578:in `handle_request' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:415:in `process_client' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/server.rb:275:in `block in run' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.7.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread' [----] I, [2018-01-11T12:10:33.252879 #2722:3b94a1c] INFO -- : Rendered /opt/rh/cfme-gemset/bundler/gems/manageiq-ui-classic-8c858b18c5c7/app/views/layouts/_exception_contents.html.haml (0.6ms) [----] I, [2018-01-11T12:10:33.253316 #2722:3b94a1c] INFO -- : Completed 200 OK in 13ms (Views: 1.4ms | ActiveRecord: 1.0ms)
https://github.com/ManageIQ/manageiq-ui-classic/pull/3235
I would just add a note that the same problem occurs also when editing an existing alert profile, not just when adding/creating a new one.
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/0d972478c7b307de515a49c4d6424a0d06d3aa86 commit 0d972478c7b307de515a49c4d6424a0d06d3aa86 Author: Harpreet Kataria <hkataria> AuthorDate: Fri Jan 12 12:06:35 2018 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Fri Jan 12 15:32:53 2018 -0500 Need to call alert_profile_edit_load_edit when cancel is pressed alert_profile_edit_load_edit method loads `@edit` that's being used in alert_profile_load method. Issue was introduced during cleanup in https://github.com/ManageIQ/manageiq-ui-classic/pull/2026 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533633 .../miq_policy_controller/alert_profiles.rb | 2 +- .../miq_policy_controller/alert_profiles_spec.rb | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-)