Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
when
nmcli> set team.runner-agg-select-policy
Allowed values for 'runner-agg-select-policy' property: lacp_prio, lacp_prio_stable, bandwidth, count, port_config
Enter 'runner-agg-select-policy' value:
nmcli> print
<snip>
team.config: {"runner": {"name": "lacp", "tx_hash": ["eth", "ipv4", "ipv6"], "tx_balancer": {"balancing_interval": 0}, "agg_select_policy": "count"}}
team.notify-peers-count: 0 (disabled)
team.notify-peers-interval: 0 (default)
team.mcast-rejoin-count: 0 (disabled)
team.mcast-rejoin-interval: 0 (default)
team.runner: lacp
team.runner-hwaddr-policy: --
team.runner-tx-hash: eth,ipv4,ipv6
team.runner-tx-balancer: --
team.runner-tx-balancer-interval: 0
team.runner-active: yes
team.runner-fast-rate: no
team.runner-sys-prio: 255 (default)
team.runner-min-ports: 0 (default)
team.runner-agg-select-policy: --
^^ here it should go to default value for the runner as -- is incorrect and it leads to inconsistent state
nmcli> sa
Connection 'team' (f2cf351b-a3a0-4e63-979b-7103c716a205) successfully updated.
nmcli> ac
Error: connection is not saved. Type 'save' first.
This issue is quite generic and should work with all values that has some defaults (so here min-ports,sys-prio, etc)
Version-Release number of selected component (if applicable):
1.10.3
Comment 1Francesco Giudici
2018-01-19 11:52:26 UTC
Created attachment 1383340[details]
libnm-core: ensure alignment of team.config and other team properties
There are two different behaviors here:
1) string properties specific to runners (runner-hwaddr-policy, runner-tx-hash and runner-agg-select-policy) and runner-tx-hash: when set in nmcli editor, the alignment with the team.config property is not performed. When performed (when saving for instance) the alignment routine is run, bringing back the expected default value (runner dependent). This caused nmcli editor to report "connection is not saved" when quitting as the connection did not changed indeed despite the save. Moreover, what previewed with the "print" command was wrong.
2) integer properties set to no value, would set '0'. This would be properly shown with "print" and saved when "save" is call.
Note that 0 is a legit value there.
The right way to set them to their default value, is to set them with the "default" keyword. What we should expect when setting them to "", could be argued. I would let this as is.
So, addressing just point 1.
Please review attached patch.
(In reply to Francesco Giudici from comment #1)
> Created attachment 1383340[details]
> libnm-core: ensure alignment of team.config and other team properties
lgtm
Comment 3Francesco Giudici
2018-01-22 18:19:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHBA-2018:0778
Description of problem: when nmcli> set team.runner-agg-select-policy Allowed values for 'runner-agg-select-policy' property: lacp_prio, lacp_prio_stable, bandwidth, count, port_config Enter 'runner-agg-select-policy' value: nmcli> print <snip> team.config: {"runner": {"name": "lacp", "tx_hash": ["eth", "ipv4", "ipv6"], "tx_balancer": {"balancing_interval": 0}, "agg_select_policy": "count"}} team.notify-peers-count: 0 (disabled) team.notify-peers-interval: 0 (default) team.mcast-rejoin-count: 0 (disabled) team.mcast-rejoin-interval: 0 (default) team.runner: lacp team.runner-hwaddr-policy: -- team.runner-tx-hash: eth,ipv4,ipv6 team.runner-tx-balancer: -- team.runner-tx-balancer-interval: 0 team.runner-active: yes team.runner-fast-rate: no team.runner-sys-prio: 255 (default) team.runner-min-ports: 0 (default) team.runner-agg-select-policy: -- ^^ here it should go to default value for the runner as -- is incorrect and it leads to inconsistent state nmcli> sa Connection 'team' (f2cf351b-a3a0-4e63-979b-7103c716a205) successfully updated. nmcli> ac Error: connection is not saved. Type 'save' first. This issue is quite generic and should work with all values that has some defaults (so here min-ports,sys-prio, etc) Version-Release number of selected component (if applicable): 1.10.3