Bug 1534014 – Coverity scan on pyparted found possible NULL pointer dereferences

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1534014 - Coverity scan on pyparted found possible NULL pointer dereferences

Summary:	Coverity scan on pyparted found possible NULL pointer dereferences

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	pyparted (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	All Linux

Priority	unspecified Severity urgent
Target Milestone:	rc
Target Release:	---
Assigned To:	David Cantrell
QA Contact:	Release Test Team
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2018-01-12 14:12 EST by David Cantrell
Modified:	2018-04-10 12:55 EDT (History)
CC List:	3 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	Cause: Coverity scans of the source revealed potential NULL pointer dereferences in some functions in pyparted. Consequence: Dereferencing a NULL pointer would cause the calling program to crash. Fix: Patch the code to avoid dereferencing NULL pointers. Result: Calling program will no longer crash.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-04-10 12:55:39 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
pyparted-3.9-null-dereference.patch (807 bytes, text/plain) 2018-02-07 10:17 EST, David Cantrell	no flags	Details
pyparted-3.9-clang-warning.patch (1.47 KB, text/plain) 2018-02-07 10:18 EST, David Cantrell	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0923	None	None	None	2018-04-10 12:55 EDT

Groups: None (edit)

Description David Cantrell 2018-01-12 14:12:51 EST

Coverity as invoked by the Errata Tool found some legitimate bugs that we should fix.  I have patches for them, but in order to push my change and do a build, I need a Bugzilla bug with acks, so I'm filing this now.

The fixes are all in src/pydisk.c and involve adding guards around two variables.

Please ack me.

Comment 2 David Cantrell 2018-02-07 10:17 EST

Created attachment 1392726 [details]
pyparted-3.9-null-dereference.patch

Comment 3 David Cantrell 2018-02-07 10:18 EST

Created attachment 1392727 [details]
pyparted-3.9-clang-warning.patch

Comment 8 errata-xmlrpc 2018-04-10 12:55:39 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0923

Note You need to log in before you can comment on or make changes to this bug.