Spec URL: https://jjames.fedorapeople.org/gap-pkg-laguna/gap-pkg-laguna.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-laguna/gap-pkg-laguna-3.8.0-1.fc28.src.rpm Description: The LAGUNA package replaces the LAG package and provides functionality for calculation of the normalized unit group of the modular group algebra of the finite p-group and for investigation of Lie algebra associated with group algebras and other associative algebras. Fedora Account System Username: jjames
- Just a couble of trivial rpmlint errors: gap-pkg-laguna.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-laguna/COPYING You should notify upstream about this, they are using an obsolete FSF address. gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/laguna/doc/manual.bib gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/laguna/doc/theory.xml You should fix the line encodings for these files. Package otherwise approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 52 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gap-pkg-laguna /review-gap-pkg-laguna/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-laguna-3.8.0-1.fc28.noarch.rpm gap-pkg-laguna-3.8.0-1.fc28.src.rpm gap-pkg-laguna.noarch: W: only-non-binary-in-usr-lib gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/laguna/doc/manual.bib gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/laguna/doc/theory.xml gap-pkg-laguna.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-laguna/COPYING 2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Thank you again. (In reply to Robert-André Mauchin from comment #1) > gap-pkg-laguna.noarch: E: incorrect-fsf-address > /usr/share/licenses/gap-pkg-laguna/COPYING > > You should notify upstream about this, they are using an obsolete FSF > address. Okay, I will do so. That wrong address is pervasive throughout the GAP universe, I'm afraid. I'll do what I can to get it corrected. > gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding > /usr/lib/gap/pkg/laguna/doc/manual.bib > gap-pkg-laguna.noarch: W: wrong-file-end-of-line-encoding > /usr/lib/gap/pkg/laguna/doc/theory.xml > > You should fix the line encodings for these files. Hmmm, that's odd. I thought I had done so. I've got this in my copy of the spec file: # Fix end of line encodings sed -i 's/\r//' doc/{manual.bib,theory.xml} Did I submit the wrong version of the spec file? Well, I will investigate and make sure this is fixed before importing.
(In reply to Jerry James from comment #2) > Hmmm, that's odd. I thought I had done so. I've got this in my copy of the > spec file: > > # Fix end of line encodings > sed -i 's/\r//' doc/{manual.bib,theory.xml} > > Did I submit the wrong version of the spec file? Well, I will investigate > and make sure this is fixed before importing. Okay, I see the problem. Those files do not have newline-return pairs; they have returns only, like with old Apple files. So the correct invocation is this: sed -i 's/\r/\n/g' doc/{manual.bib,theory.xml} I will make that correction.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-laguna. You may commit to the branch "f27" in about 10 minutes.
gap-pkg-laguna-3.8.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d3d5146a89
gap-pkg-laguna-3.8.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d3d5146a89
gap-pkg-laguna-3.8.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.