Bug 1535001 - ovn localnet: read custom bridge/vlan from external provider to populate UI (and possibly REST too)
Summary: ovn localnet: read custom bridge/vlan from external provider to populate UI (...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.1.1
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ovirt-4.2.5
: ---
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-16 12:45 UTC by Michael Burman
Modified: 2018-07-31 15:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-31 15:28:34 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: ovirt-4.3+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 90682 0 master MERGED core: Add custom physnet parameters into ProviderNetwork 2020-11-03 12:21:51 UTC
oVirt gerrit 90683 0 master MERGED webadmin, core: Use the new custom physical network parameters 2020-11-03 12:22:07 UTC
oVirt gerrit 90684 0 master MERGED core: Map physical network properties from external network 2020-11-03 12:21:51 UTC
oVirt gerrit 90685 0 master MERGED db: Add query for getting network by vdsm name and data center 2020-11-03 12:21:50 UTC
oVirt gerrit 90686 0 master MERGED core: Properly import external network linked to physical network 2020-11-03 12:21:51 UTC
oVirt gerrit 91926 0 master MERGED core: Add query to get external network by external id 2020-11-03 12:21:51 UTC
oVirt gerrit 92135 0 master MERGED core: Use HashMap in sync network for physnet mapping lookup 2020-11-03 12:22:08 UTC
oVirt gerrit 92480 0 master MERGED core: Prevent attaching physnets to non OVS clusters 2020-11-03 12:21:51 UTC
oVirt gerrit 92930 0 ovirt-engine-4.2 MERGED core: Add custom physnet parameters into ProviderNetwork 2020-11-03 12:22:08 UTC
oVirt gerrit 92931 0 ovirt-engine-4.2 MERGED core: Map physical network properties from external network 2020-11-03 12:21:52 UTC
oVirt gerrit 92933 0 ovirt-engine-4.2 MERGED db: Add query for getting network by vdsm name and data center 2020-11-03 12:21:52 UTC
oVirt gerrit 92934 0 master MERGED core: fix name of upgrade script 2020-11-03 12:22:09 UTC
oVirt gerrit 92960 0 master MERGED core: Small refactor of BaseNetworkProviderProxy 2020-11-03 12:21:52 UTC
oVirt gerrit 93134 0 ovirt-engine-4.2 MERGED core: Properly import external network linked to physical network 2020-11-03 12:21:52 UTC
oVirt gerrit 93135 0 ovirt-engine-4.2 MERGED core: Add query to get external network by external id 2020-11-03 12:21:53 UTC
oVirt gerrit 93136 0 ovirt-engine-4.2 MERGED webadmin, core: Use the new custom physical network parameters 2020-11-03 12:21:52 UTC
oVirt gerrit 93137 0 ovirt-engine-4.2 MERGED core: Use HashMap in sync network for physnet mapping lookup 2020-11-03 12:22:10 UTC
oVirt gerrit 93138 0 ovirt-engine-4.2 MERGED core: Small refactor of BaseNetworkProviderProxy 2020-11-03 12:21:53 UTC

Description Michael Burman 2018-01-16 12:45:22 UTC
Description of problem:
ovn localnet: attachment of ovn network to Custom data center network is not displayed.

When setting a custom data center network for ovn local net, it is not saved.
Custom data center network is a long name=vdsm name

Version-Release number of selected component (if applicable):
4.2.1.1-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Create long name(more then 15 characters) and attach to host
2. Take it's vdsm name and create new ovn network and set in the custom filed the vdsm name
3. Press OK and edit the network

Actual results:
The custom name is gone

Expected results:
Should be displayed

Comment 1 Dan Kenigsberg 2018-01-21 15:12:39 UTC
This bug has very little to do with long names.

If a user defines an external network backed up by a localnet, and passes Custom brdige name and segmentation id, the custom values do not show up when the external network details are viewed.

This is because the Custom values are stored in the external provider, and the front-end (nor REST) fetches info only from Engine db.

I think that it would be nice to attempt to pull the information from the provider, and present it in UI and REST.

Comment 2 Ales Musil 2018-01-31 07:31:55 UTC
It is possible to pull the information. But the problem is how to represent it into our existing structure? 

VLAN tag is the same for both. The "provider:physical_network" which is vdsm switch name has no representation in our Network structure. 

In the UI there is way around to properly display it. 

REST would be able to display only VLAN tag. 

So is it ok?

Comment 3 Dan Kenigsberg 2018-02-08 12:35:06 UTC
I don't really understand your question. I *thought* that for "Custom" values we have plain strings to select both vdsm bridge name and vlan. They are passed verbatim to the provider.

Am I mistaken? Do we perform some non-reversable function onto these values?

Comment 4 Ales Musil 2018-02-09 08:04:33 UTC
You are right but we have no representation for the "custom" value in engine network entity. We are passing the value into provider via label. In the UI it doesn't really matter. This is problem for the REST as the "custom" name (vdsm bridge name) cannot be displayed there.

Comment 5 Dan Kenigsberg 2018-02-09 08:43:31 UTC
We need "custom" only for backward compatibility. So no need to worry about exposing it in REST if there is no field for it yet.

The current UI, however, is "write-only" and quite confusing. I hope you can fix it.

Comment 6 Michael Burman 2018-07-26 09:26:52 UTC
Testing on - 4.2.6_SNAPSHOT-84.gad3de30.0.scratch.master.el7ev

Custom bridge is populated in UI and REST. Start VM is working, but the custom bridge/vlan is not passed to guest and VM won't get the IP from the custom vlan network as it should.

"status": "ACTIVE",
"name": "test-local-net",
"provider:physical_network": "on7ac5f1d5d5d94",
"tenant_id": "00000000000000000000000000000001",
"provider:network_type": "flat",
"id": "3a72a74a-943f-4bb4-9d8c-f0069dd7b6c9",
"mtu": 1442


Port "on7ac5f1d5d5d94"
            tag: 163
            Interface "on7ac5f1d5d5d94"
                type: internal
        Port "eno2"
            Interface "eno2"

Guest should get an IP from vlan 163 in this case, but actually gets the native one and not 163. 
This can't be verified, moving back to assigned

Comment 7 Michael Burman 2018-07-26 12:47:46 UTC
After speaking with Dominik, i have reported new bug BZ 1608885, as this is a new functional problem and the current bug can be verified

Comment 8 Michael Burman 2018-07-26 12:54:04 UTC
Verified on - 4.2.6_SNAPSHOT-84.gad3de30.0.scratch.master.el7ev
Custom bridge is populated in UI and REST

Comment 9 Sandro Bonazzola 2018-07-31 15:28:34 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.