Description of problem: $ LC_ALL=C bash -n ./extras/hook-scripts/create/post/S10selinux-label-brick.sh ./extras/hook-scripts/create/post/S10selinux-label-brick.sh: line 46: syntax error near unexpected token `(' ./extras/hook-scripts/create/post/S10selinux-label-brick.sh: line 46: ` semanage fcontext --add -t glusterd_brick_t -r s0 $b(/.*)?' This prevent gluster volume from starting on latest Fedora, unless SElinux is disabled (since then, the code is not run). Version-Release number of selected component (if applicable): git head (7ba7a4b2) How reproducible: each time Steps to Reproduce: 1. git checkout 2. run the command 3. Actual results: syntax error near unexpected token Expected results: nothing, cause the syntax would be ok. Additional info: I have a patch ready. I would also like to know where/how we can lint shell script to prevent that from happening in the future.
REVIEW: https://review.gluster.org/19205 (Fix syntax of shell script use for selinux label) posted (#1) for review on master by Michael Scherer
This is still broken 5 months later, because of (from what I can see?) a build failure and then no follow-up on the Gerrit review. Can someone please pick this up again, since it's preventing volume starts?