Description of problem:

OSP10 -> OSP13 FFU upgrade: openstack overcloud config download fails with: Deployment NetworkDeployment with group:os-apply-config not supported with config-download

Steps to reproduce:

1. Deploy OSP10 undercloud + overcloud
2. Upgrade undercloud to OSP11
3. Upgrade undercloud to OSP12
4. Upgrade undercloud to OSP13
5. Update stack outputs:
openstack overcloud deploy \
--disable-validations \
--templates /usr/share/openstack-tripleo-heat-templates \
-e /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml \
--libvirt-type kvm \
--ntp-server clock.redhat.com \
--control-scale 1 \
--control-flavor controller \
--compute-scale 1 \
--compute-flavor compute \
-e /home/stack/virt/config_lvm.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e /home/stack/virt/hostnames.yml \
-e /home/stack/virt/debug.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker-ha.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/fast-forward-upgrade.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/noop-deploy-steps.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/config-download-environment.yaml \
-e /home/stack/docker_registry.yaml \

6. (undercloud) [stack@undercloud-0 ~]$ openstack overcloud config download

Deployment NetworkDeployment with group:os-apply-config not supported with config-download.

The nic templates in use on the overcloud do contain group: os-apply-config properties which were supported during OSP10 deployment. Here is the nic template for the controller role:

http://paste.openstack.org/show/645040/

config download works fine if before updating the stack outputs the nic templates are adjusted to use group: script. I think we need to provide a migration path(some script?) from old nic templates to the new required format because having to manually edit the nic templates is error prone and provides a terrible user experience.