Bug 1535324 - [UI] - Networks - Align the whole text in the External section to the left
Summary: [UI] - Networks - Align the whole text in the External section to the left
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.1.1
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.3.5
: 4.3.5.3
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-17 06:38 UTC by Michael Burman
Modified: 2019-07-30 14:08 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.3.5.3
Clone Of:
Environment:
Last Closed: 2019-07-30 14:08:24 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)
record1 (1.03 MB, application/x-gzip)
2018-01-17 06:38 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 100801 0 master MERGED webadmin: Fix indentation in Network popup 2019-06-25 11:25:47 UTC
oVirt gerrit 101229 0 ovirt-engine-4.3 MERGED webadmin: Fix indentation in Network popup 2019-07-02 05:52:53 UTC

Description Michael Burman 2018-01-17 06:38:02 UTC
Created attachment 1382225 [details]
record1

Description of problem:
[UI] - Networks - Align the whole text in the External section to the left.

Now that we have the ovn localnet feature , we added new text and radio buttons for the External section. The text and radio buttons should be aligned to the left, as the all other text parts in this dialog. The text that should be aligned to the left is:
'External Provider' - Text only (drop down list should stay in place)
'Connect to physical network' - Checkbox and text 
'Data Center Network - Radio button and text (drop down list should stay in place)
'Custom' - Radio button and text - (Field should stay in place)


Version-Release number of selected component (if applicable):
4.2.1.1-0.1.el7

How reproducible:
100%

Comment 1 Dan Kenigsberg 2018-01-18 19:59:30 UTC
I believe the indentation was intentional, but I'd let Ales and Eldan decide.

Comment 2 Ales Musil 2018-10-12 11:05:51 UTC
The indentation was intentional. Liz what do you think? Should we keep it as is?

Comment 3 Liz 2018-11-05 20:10:45 UTC
@Ales - I think aligning the "External Provider" and "Connect to Physical Network "options with the header makes sense since that's consistent with the rest of the form. I'm assuming that only if the user enables "Connect to physical network" that then they would be able to choose between Data Center Network and Custom? I think if that's the case, it's fine to keep these two options slightly indented to show the relationship.

Comment 4 Michael Burman 2019-07-08 08:33:40 UTC
Verified on - 4.3.5.3-0.1.el7

Comment 5 Sandro Bonazzola 2019-07-30 14:08:24 UTC
This bugzilla is included in oVirt 4.3.5 release, published on July 30th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.