Bug 1535402 - [trello lo6HwQgu] BC edit page "Triggers" part has no webhooks display and "Add Webhook" link not working/aligned
Summary: [trello lo6HwQgu] BC edit page "Triggers" part has no webhooks display and "A...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 3.9.0
Assignee: Jakub Hadvig
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-17 10:21 UTC by Xingxing Xia
Modified: 2018-03-27 09:44 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-24 15:54:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
"Add Webhook" aligment issue (79.07 KB, image/png)
2018-01-17 10:21 UTC, Xingxing Xia
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0489 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.9 RPM Release Advisory 2018-03-28 18:06:38 UTC

Description Xingxing Xia 2018-01-17 10:21:46 UTC
Created attachment 1382328 [details]
"Add Webhook" aligment issue

Description of problem:
Click of "Add Webhook" has no response in BC edit page

Version-Release number of selected component (if applicable):
v3.9.0-0.20.0

How reproducible:
Always

Steps to Reproduce:
1. Create BC
2. Login to web console, go to BC edit page, click "Show advanced options" and scroll down to "Triggers" part
3. Check "Add Webhook" link

Actual results:
3. Click of it has no response.
BTW, it is not left aligned (see screenshot) the text "Add Webhook" cannot be selected for copy. Other link such as "Create New Secret" is aligned and can be selected.

Expected results:
3. Click should work. The link text should be aligned and can be selected

Additional info:

Comment 1 Xingxing Xia 2018-01-17 10:53:43 UTC
One more actual result that isn't said: "Triggers" part does not show existing generic/github webhooks, though BC page's Configuration tab shows. Expected result is it should show in "Triggers" part.

Comment 2 Jakub Hadvig 2018-01-17 12:41:40 UTC
Can you please provide the BC that you have created ?
Tried to reproduce the issue with BC with no triggers and also with two triggers but could not reproduce.

Comment 5 Samuel Padgett 2018-01-18 18:41:47 UTC
Jakub, I think this is the underlying cause:

https://github.com/openshift/origin-web-console/issues/2682

Comment 6 openshift-github-bot 2018-01-18 22:32:28 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/1b92da9dfe038bd5ca214c529e5549a3aacac586
Bug 1535402 - Webhook trigger editor not responding + Webhook trigger editor should behave like envVar editor

Comment 8 Xingxing Xia 2018-01-23 04:53:15 UTC
Checked in v3.9.0-0.22.0, with steps in comment 0, now "Triggers" part has webhooks and can show and add webhooks well, the link text is aligned.


Note You need to log in before you can comment on or make changes to this bug.