Bug 1535782 - [RHV] Switch Smart State Analysis code for the oVIrt provider to work with APIv4 instead of deprecated APIv3
Summary: [RHV] Switch Smart State Analysis code for the oVIrt provider to work with AP...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.11.0
Assignee: Boriso
QA Contact: Angelina Vasileva
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-18 05:29 UTC by Boriso
Modified: 2019-12-12 13:34 UTC (History)
12 users (show)

Fixed In Version: 5.11.0.23
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-12 13:33:48 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ManageIQ manageiq-gems-pending pull 445 0 None None None 2019-09-02 19:18:54 UTC
Github ManageIQ manageiq-providers-ovirt pull 394 0 None None None 2019-09-02 19:18:54 UTC
Github ManageIQ manageiq-providers-ovirt pull 405 0 None None None 2019-09-02 19:18:54 UTC
Github ManageIQ manageiq-smartstate pull 100 0 None None None 2019-09-02 19:18:54 UTC
Github ManageIQ manageiq-smartstate pull 98 0 None None None 2019-09-02 19:18:54 UTC
Github ManageIQ manageiq pull 19179 0 None None None 2019-09-02 19:18:54 UTC
Red Hat Product Errata RHBA-2019:4199 0 None None None 2019-12-12 13:34:07 UTC

Description Boriso 2018-01-18 05:29:50 UTC
Description of problem:
Currently the Smart State Analysis uses the v3 api for the oVirt provider.
This should be fixed so that SSA will be able to work with the v4 of the API.

How reproducible:
100%

Steps to Reproduce:
This is defined in the code: https://github.com/ManageIQ/manageiq-providers-ovirt/pull/196/files#diff-d6125c21d43685840429020f8c5a57aaR81

1. Run SSA

Actual results:

V3 of the api is used.

Expected results:

When provider supports v4 and the setting for using v4 is enabled (use_ovirt_sdk) SSA uses v4.
Otherwise it uses v3.

Comment 2 Dave Johnson 2018-01-18 05:44:06 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 7 CFME Bot 2019-08-08 17:22:45 UTC
New commit detected on ManageIQ/manageiq-smartstate/master:

https://github.com/ManageIQ/manageiq-smartstate/commit/b0b5c7345ebac97fd445f60997b7513e779502e3
commit b0b5c7345ebac97fd445f60997b7513e779502e3
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Thu Jul 25 06:40:33 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Thu Jul 25 06:40:33 2019 -0400

    Remove v3 api form SSA

    Remove the usage of the ovirt gem and version 3 api from the SSA

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 lib/MiqVm/MiqRhevmVm.rb | 40 +-
 lib/MiqVm/MiqVm.rb | 2 +-
 2 files changed, 21 insertions(+), 21 deletions(-)

Comment 9 CFME Bot 2019-08-14 20:57:23 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/master:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/de7eb0eecd65e83451d452f7658f2bf19fd6eda4
commit de7eb0eecd65e83451d452f7658f2bf19fd6eda4
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Thu Jul 25 06:38:32 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Thu Jul 25 06:38:32 2019 -0400

    Remove v3 api form SSA

    Remove the usage of the ovirt gem and version 3 api from the SSA

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 app/models/manageiq/providers/redhat/infra_manager/vm_or_template_shared/scanning.rb | 2 +-
 app/models/manageiq/providers/redhat/inventory/collector.rb | 36 +
 2 files changed, 37 insertions(+), 1 deletion(-)

Comment 12 CFME Bot 2019-08-21 12:16:13 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/502927fa4305df92533d92740e3dad8bd05349e4
commit 502927fa4305df92533d92740e3dad8bd05349e4
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Wed Aug 21 03:24:07 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Wed Aug 21 03:24:07 2019 -0400

    Bump SSA gem

    Bump smartstate gem to 0.3.0
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 Gemfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 13 CFME Bot 2019-08-21 20:26:33 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/b0060d0dd545ad02f5492dd9ee1e2dba13f63a85
commit b0060d0dd545ad02f5492dd9ee1e2dba13f63a85
Author:     Adam Grare <agrare>
AuthorDate: Wed Aug 21 08:14:07 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Wed Aug 21 08:14:07 2019 -0400

    Merge pull request #19179 from borod108/bump_smartstate

    Bump SSA gem

    (cherry picked from commit 332ea95f8fd67d2461a1e39e6182418af553c28d)

    https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 Gemfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 14 CFME Bot 2019-08-21 20:27:39 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/ivanchuk:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/33059244eec76754dba2632c0832fa2645276542
commit 33059244eec76754dba2632c0832fa2645276542
Author:     Adam Grare <agrare>
AuthorDate: Wed Aug 14 16:54:40 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Wed Aug 14 16:54:40 2019 -0400

    Merge pull request #394 from borod108/bugs/1535782smart_no_v3

    Remove v3 api form SSA

    (cherry picked from commit 343edb5d474accae5c9fe7c1af33fe4a7eba7bcc)

    https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 app/models/manageiq/providers/redhat/infra_manager/vm_or_template_shared/scanning.rb | 2 +-
 app/models/manageiq/providers/redhat/inventory/collector.rb | 36 +
 2 files changed, 37 insertions(+), 1 deletion(-)

Comment 15 Angelina Vasileva 2019-08-28 10:22:44 UTC
Failed QA for 5.11.0.21.20190821214526_b0060d0.

The task is shown as successfully completed in the UI but log contains error starting like this:

[----] I, [2019-08-28T05:44:47.697502 #31294:2acae1a145c4]  INFO -- : Q-task_id([job_dispatcher]) MIQ(MiqQueue.put) Message id: [2725],  id: [], Zone: [default], Role: [smartstate], Server: [], MiqTask id: [], Ident: [generic], Target id:
 [], Instance id: [], Task id: [job_message_1566985487], Command: [Job.update_message], Timeout: [600], Priority: [100], State: [ready], Deliver On: [], Data: [], Args: ["d8d7e279-61eb-4004-902c-f9499545b3a0", "Scanning vmconfig"]
[----] I, [2019-08-28T05:44:47.697601 #31294:2acae1a145c4]  INFO -- : Q-task_id([job_dispatcher]) MIQ(ManageIQ::Providers::Redhat::InfraManager::Vm#scan_via_miq_vm) Scanning [vmconfig] information.  TaskId:[d8d7e279-61eb-4004-902c-f949954
5b3a0]  VM:[ghubale_vm_dnd]
[----] E, [2019-08-28T05:44:47.703809 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract can't modify frozen String
[----] E, [2019-08-28T05:44:47.704100 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/bundler/gems/cfme-gems-pending-ca1c762f8036/lib/gems/pending/util/xml/miq_rexml.rb:231:in `force_encoding'
[----] E, [2019-08-28T05:44:47.704168 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/bundler/gems/cfme-gems-pending-ca1c762f8036/lib/gems/pending/util/xml/miq_rexml.rb:231:in `add_attribute'
[----] E, [2019-08-28T05:44:47.704192 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/VmConfig/VmConfig.rb:317:in `insert_XML'
[----] E, [2019-08-28T05:44:47.704234 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/VmConfig/VmConfig.rb:177:in `block in to_xml'
[----] E, [2019-08-28T05:44:47.704266 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/VmConfig/VmConfig.rb:175:in `each'
[----] E, [2019-08-28T05:44:47.704323 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/VmConfig/VmConfig.rb:175:in `to_xml'
[----] E, [2019-08-28T05:44:47.704359 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/MIQExtract/MIQExtract.rb:161:in `getVMConfig'
[----] E, [2019-08-28T05:44:47.704378 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/MIQExtract/MIQExtract.rb:138:in `block in extract'
[----] E, [2019-08-28T05:44:47.704395 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/MIQExtract/MIQExtract.rb:130:in `each'
[----] E, [2019-08-28T05:44:47.704426 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/gems/manageiq-smartstate-0.3.0/lib/metadata/MIQExtract/MIQExtract.rb:130:in `extract'
[----] E, [2019-08-28T05:44:47.704445 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /var/www/miq/vmdb/app/models/mixins/scanning_mixin.rb:252:in `block in scan_via_miq_vm'
[----] E, [2019-08-28T05:44:47.704461 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /var/www/miq/vmdb/app/models/mixins/scanning_mixin.rb:248:in `each'
[----] E, [2019-08-28T05:44:47.704481 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /var/www/miq/vmdb/app/models/mixins/scanning_mixin.rb:248:in `scan_via_miq_vm'
[----] E, [2019-08-28T05:44:47.704537 #31294:2acae1a145c4] ERROR -- : Q-task_id([job_dispatcher]) MIQExtract.extract /opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-33059244eec7/app/models/manageiq/providers/redhat/infra_manager/vm_or_template_shared/scanning.rb:28:in `perform_metadata_scan'


Please contact me directly if you need a reproducer.

IMPORTANT NOTE: I did exactly the same with the same RHV on 5.11.0.18.20190806180636_1dd6378 and didn't get these errors.

Comment 18 Daniel Berger 2019-08-28 20:19:33 UTC
https://github.com/ManageIQ/manageiq-gems-pending/pull/445 to help

Comment 20 CFME Bot 2019-09-02 14:38:14 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/master:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/7315c056bc5c49662b1e280377b233e949d94e67
commit 7315c056bc5c49662b1e280377b233e949d94e67
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Mon Sep  2 10:09:45 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Mon Sep  2 10:09:45 2019 -0400

    Add a method for SSA

    Add a method for fixing SSA snapshot disks collection.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 app/models/manageiq/providers/redhat/inventory/collector.rb | 6 +
 1 file changed, 6 insertions(+)

Comment 21 Boriso 2019-09-02 14:40:42 UTC
Daniel Berger - thank you very much!

Added these:
https://github.com/ManageIQ/manageiq-smartstate/pull/100
https://github.com/ManageIQ/manageiq-providers-ovirt/pull/405

Comment 22 CFME Bot 2019-09-03 13:01:06 UTC
New commit detected on ManageIQ/manageiq-smartstate/master:

https://github.com/ManageIQ/manageiq-smartstate/commit/d487a1975ef474eb82d76b303aa1b1be849b3600
commit d487a1975ef474eb82d76b303aa1b1be849b3600
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Mon Sep  2 05:32:14 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Mon Sep  2 05:32:14 2019 -0400

    Remove using ovirt gem

    There were still places using the ovirt gem that uses the V3 rhv api.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 lib/metadata/VmConfig/VmConfig.rb | 33 +-
 1 file changed, 18 insertions(+), 15 deletions(-)

Comment 24 CFME Bot 2019-09-03 15:20:48 UTC
New commit detected on ManageIQ/manageiq-gems-pending/ivanchuk:

https://github.com/ManageIQ/manageiq-gems-pending/commit/6ac7a5d7dbe65f1b978066ef8721ea5e00dc65ce
commit 6ac7a5d7dbe65f1b978066ef8721ea5e00dc65ce
Author:     Richard Oliveri <roliveri>
AuthorDate: Fri Aug 30 11:21:39 2019 -0400
Commit:     Richard Oliveri <roliveri>
CommitDate: Fri Aug 30 11:21:39 2019 -0400

    Merge pull request #445 from djberg96/deal_with_frozen_strings

    Dup strings in case they're frozen before force_encoding

    (cherry picked from commit c84fb582648484fbf8c96f4a3d0ac88d49db6587)

    https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 lib/gems/pending/util/xml/miq_rexml.rb | 4 +-
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 25 CFME Bot 2019-09-03 15:21:01 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/ivanchuk:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/2257f78d70426bd4cf2413233feaa58b5cefc751
commit 2257f78d70426bd4cf2413233feaa58b5cefc751
Author:     Moti Asayag <masayag>
AuthorDate: Mon Sep  2 10:36:19 2019 -0400
Commit:     Moti Asayag <masayag>
CommitDate: Mon Sep  2 10:36:19 2019 -0400

    Merge pull request #405 from borod108/bugs/ssa_collect_snap_disks

    Add a method for SSA

    (cherry picked from commit 577c0a6ce6c39cd40860f4946f9f058d3fb8484f)

    https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 app/models/manageiq/providers/redhat/inventory/collector.rb | 6 +
 1 file changed, 6 insertions(+)

Comment 27 CFME Bot 2019-09-03 15:45:33 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/14e30830c91e0ab537f9b5129ab9340fc347e514
commit 14e30830c91e0ab537f9b5129ab9340fc347e514
Author:     Adam Grare <agrare>
AuthorDate: Tue Sep  3 11:41:11 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Tue Sep  3 11:41:11 2019 -0400

    Merge pull request #19245 from borod108/bump_ssa_31

    Bump SSA to 0.3.1

    (cherry picked from commit 94bcf4df8e31046179b3f0350cfed2004a9287c3)

    https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 Gemfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 28 CFME Bot 2019-09-03 15:45:34 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/35d3652c96a5c9e0ebc749c62ecd5db1006ae837
commit 35d3652c96a5c9e0ebc749c62ecd5db1006ae837
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Tue Sep  3 11:17:27 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Tue Sep  3 11:17:27 2019 -0400

    Bump SSA to 0.3.1

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

 Gemfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 29 Angelina Vasileva 2019-09-10 09:36:47 UTC
Fixed and verified in 5.11.0.23.20190904213640_d113674 for
RHV 4.2.8.5-0.1.el7ev and
RHV 4.3.5.4-0.1.el7.

SSA works as expected.

Comment 31 errata-xmlrpc 2019-12-12 13:33:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199


Note You need to log in before you can comment on or make changes to this bug.