Red Hat Bugzilla – Bug 1536088
bind PUT causes broker panic and 502 when ServiceInstance not found
Last modified: 2018-03-28 10:20:59 EDT
Created attachment 1382947 [details] reproducer script Reported upstream: https://github.com/openshift/ansible-service-broker/issues/652 Description of problem: I tried to PUT /v2/service_instances/$INSTANCE_ID/service_bindings/$BINDING_ID?accepts_incomplete=true where $INSTANCE_ID does not exist. This causes the broker to panic, resulting in a 502 response. Version-Release number of selected component (if applicable): master How reproducible: always Steps to Reproduce: 1. Configure the broker to run APBs for bind and unbind, and to auto-escalate. 2. Run the attached script. Actual results: broker panic Expected results: 400 response per OSB API spec
https://github.com/openshift/ansible-service-broker/pull/653
zitang, Please keep trace and try to reproduce.
Verified. asb image: registry.access.stage.redhat.com/openshift3/ose-ansible-service-broker:v3.9.0-0.23.0.1 asb version : 1.1.7 [root@dhcp-140-42 script]# sh ./reproducer.sh asb-1338-openshift-ansible-service-broker.apps.0125-tqt.qe.rhcloud.com asb-1338-openshift-ansible-service-broker.apps.0125-tqt.qe.rhcloud.com/ansible-service-broker/v2/service_instances/0aa60c8e-9b53-419f-b245-435906257c7d/service_bindings/f06f157d-c8d6-4ec8-ad8f-04bb59b6b907?accepts_incomplete=true HTTP/1.1 400 Bad Request Content-Type: application/json Date: Thu, 25 Jan 2018 09:54:08 GMT Content-Length: 33 Set-Cookie: 89a6d633054ded194d4e1360cdc1fbef=e2b8f07960b52ab9f5242c04f027c1e1; path=/; HttpOnly; Secure { "description": "not found" } ASB Log: [2018-01-25T09:54:08.602Z] [ERROR] - Could not find a service instance in dao - 100: Key not found (/service_instance/0aa60c8e-9b53-419f-b245-435906257c7d) [262] 10.129.0.1 - - [25/Jan/2018:09:54:08 +0000] "PUT /ansible-service-broker/v2/service_instances/0aa60c8e-9b53-419f-b245-435906257c7d/service_bindings/f06f157d-c8d6-4ec8-ad8f-04bb59b6b907?accepts_incomplete=true HTTP/1.1" 400 33
Created attachment 1385992 [details] verify script
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0489