Bug 1536284 - ktorrent reports wrong client ID
Summary: ktorrent reports wrong client ID
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ktorrent
Version: 26
Hardware: i686
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-19 03:06 UTC by Steve
Modified: 2018-01-30 17:32 UTC (History)
4 users (show)

Fixed In Version: ktorrent-5.1.0-3.fc26
Clone Of:
Environment:
Last Closed: 2018-01-30 17:32:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to fix bug (531 bytes, patch)
2018-01-19 03:06 UTC, Steve
no flags Details | Diff

Description Steve 2018-01-19 03:06:52 UTC
Created attachment 1383129 [details]
Patch to fix bug

Description of problem:
ktorrent reports the wrong client ID.
Even though it's version 5.0.1 release, it's reporting itself as 5.0.1 development.
Some torrent-trackers whitelist torrent-clients.

Version-Release number of selected component (if applicable):
ktorrent 5.0.1

Additional info:

Enclosed is a patch that fixes the problem.

Comment 1 Rex Dieter 2018-01-19 14:36:54 UTC
I can look into it

Comment 2 Rex Dieter 2018-01-19 14:45:24 UTC
Upstream has fixed the number to be accurate (5.1.0), but left the "type" to devel rather than including your additional change to "normal".

It would *appear* that normal is still the right thing to do, but I'd rather upstream be consulted first.

Comment 3 Rex Dieter 2018-01-19 14:56:46 UTC
nevermind, the upstream version bump was made only to master/ branch.  So all looks good to me, I'll apply it.

Comment 4 Fedora Update System 2018-01-19 16:02:05 UTC
ktorrent-5.1.0-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-da53d5d38d

Comment 5 Fedora Update System 2018-01-21 09:43:04 UTC
ktorrent-5.1.0-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-da53d5d38d

Comment 6 Steve 2018-01-24 02:29:09 UTC
Thanks for the quick response on this!

Comment 7 Fedora Update System 2018-01-30 17:32:32 UTC
ktorrent-5.1.0-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.