Bug 1536375 - disk over-commit still not correctly calculated during live migration
Summary: disk over-commit still not correctly calculated during live migration
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-nova
Version: 12.0 (Pike)
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 13.0 (Queens)
Assignee: Matthew Booth
QA Contact: OSP DFG:Compute
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-19 09:46 UTC by Matthew Booth
Modified: 2023-03-21 18:44 UTC (History)
7 users (show)

Fixed In Version: openstack-nova-17.0.9-9.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-14 14:49:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1744079 0 None None None 2018-01-19 09:46:53 UTC
OpenStack gerrit 602478 0 None MERGED Refix disk size during live migration with disk over-commit 2020-10-31 15:41:42 UTC

Description Matthew Booth 2018-01-19 09:46:54 UTC
Change I8a705114d47384fcd00955d4a4f204072fed57c2 (written by me... sigh) addressed a bug which prevented live migration to a target host with overcommitted disk when made with microversion <2.25. It achieved this, but the fix is still not correct. We now do:

        if disk_over_commit:
            disk_available_gb = dst_compute_info['local_gb']

Unfortunately local_gb is *total* disk, not available disk. We actually want free_disk_gb. Fun fact: due to the way we calculate this for filesystems, without taking into account reserved space, this can also be negative.

The test we're currently running is: could we fit this guest's allocated disks on the target if the target disk was empty. This is at least better than it was before, as we don't spuriously fail early. In fact, we're effectively disabling a test which is disabled for microversion >=2.25 anyway. IOW we should fix it, but it's probably not a high priority.

Comment 1 Matthew Booth 2019-05-14 14:49:31 UTC
This was merged into upstream stable 17.0.9, which we have already released downstream.


Note You need to log in before you can comment on or make changes to this bug.