Bug 1536408 - Review Request: perl-AtteanX-Compatibility-Trine - Compatibility layer between RDF::Trine and Attean
Summary: Review Request: perl-AtteanX-Compatibility-Trine - Compatibility layer betwee...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1528845
TreeView+ depends on / blocked
 
Reported: 2018-01-19 11:16 UTC by Petr Pisar
Modified: 2018-01-19 16:20 UTC (History)
2 users (show)

Fixed In Version: perl-AtteanX-Compatibility-Trine-0.001-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-19 16:20:08 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2018-01-19 11:16:06 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-AtteanX-Compatibility-Trine/perl-AtteanX-Compatibility-Trine.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-AtteanX-Compatibility-Trine/perl-AtteanX-Compatibility-Trine-0.001-1.fc28.src.rpm
Description:
This is a compatibility layer between RDF::Trine and Attean Perl modules. For
now, only certain methods of RDF::Trine nodes are supported.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-01-19 12:10:12 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-AtteanX-Compatibility-Trine-0.001-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Attean)
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(strict)
      1 perl(:VERSION) >= 5.10.1
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-AtteanX-Compatibility-Trine-0.001-1.fc28.noarch.rpm | sort | uniq -c
      1 perl(Attean::Blank)
      1 perl(Attean::IRI)
      1 perl(Attean::Literal)
      1 perl(AtteanX::Compatibility::Trine) = 0.001
      1 perl-AtteanX-Compatibility-Trine = 0.001-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-AtteanX-Compatibility-Trine*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2018-01-19 14:10:16 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-AtteanX-Compatibility-Trine

Comment 3 Petr Pisar 2018-01-19 16:20:08 UTC
Thank you for the review end the repository.


Note You need to log in before you can comment on or make changes to this bug.